Re: [PATCH] emacs: fix notmuch-search-line-faces defcustom
Mark Walters writes: > In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default value > for notmuch-search-line-faces was changed so that it didn't match the > specification in the corresponding defcustom. This meant that it was > difficult for the user to customize this variable as they got a type > mismatch error. Mark, thanks for fixing the defcustom that I broke. :-) I have verified that it now works for me. This testing induced me to zero-out my notmuch face customizations, which reminded me that the defaults are bad in places for Emacs themes with dark backgrounds. I'll send a patch for that. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: fix notmuch-search-line-faces defcustom
Mark Walters writes: > In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default value > for notmuch-search-line-faces was changed so that it didn't match the > specification in the corresponding defcustom. This meant that it was > difficult for the user to customize this variable as they got a type > mismatch error. > > Note anyone who had already customised this variable would not see > this bug as their customisation would match the defcustom. pushed this (and the other 2a7b1 fix) to release and master. Mark, would you mind writing a short NEWS entry for 0.23.1? d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: fix notmuch-search-line-faces defcustom
Mark Walters writes: > Getting this defcustom to work was quite tricky, so please could > people test: just try M-x customize-variable notmuch-search-line-faces > and see if a custom widget displays correctly (in particular that it > doesn't complaine about a type mismatch. it works for me, fwiw > I am not certain this is better than just reverting 2a7b -- even with > the above the customisation for notmuch-search-line-faces is more > complex (to the user as well as in the code) I think I can live with the complexity from a UI point of view. I agree it's a bit aesthetically displeasing, but I don't think it prevents the user from getting the face customized. > Finally, the docstring says that a list of faces is also allowed. I > believe that is true but making that work with the customize widget > would be horrible. I think we should remove the documentation for it > from the defcustom and just put a lisp comment in the source code -- > if the user wants to set it with a "setq" then they can read the > actual source. OK; this could be a followup patch. I'll wait a few more days for discussion and testing. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
