Re: [PATCH v3 0/2] notmuch hooks

2011-12-08 Thread Tomi Ollila
On Wed, 07 Dec 2011 14:13:13 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula j...@nikula.org wrote: I wonder, though, whether the samples should be created only when creating the database, or whenever the hooks directory does not

Re: [PATCH v3 0/2] notmuch hooks

2011-12-08 Thread Jameson Graef Rollins
On Thu, 08 Dec 2011 10:49:43 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: If the hooks are named as 'pre-new.sample' and 'post-new.sample' and executable then users need just copy the file and start editing (and not remember to do any chmod's)... It seems simpler and cleaner to me to just have

Re: [PATCH v3 0/2] notmuch hooks

2011-12-07 Thread Jani Nikula
On Tue, 06 Dec 2011 22:16:37 -0500, Tom Prince tom.pri...@ualberta.net wrote: On Tue, 06 Dec 2011 18:47:01 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Also, what if we make it so that the post-new hook script only runs if notmuch new processes new messages? All of my

Re: [PATCH v3 0/2] notmuch hooks

2011-12-07 Thread Jameson Graef Rollins
On Wed, 07 Dec 2011 20:05:22 +0200, Jani Nikula j...@nikula.org wrote: It would, but as I wrote in id:87mxb8kt5r@nikula.org, I think that should come as another patch afterwards. I know I can't decide yet what should be passed and how. Processed message counts (added, deleted, renamed)

Re: [PATCH v3 0/2] notmuch hooks

2011-12-07 Thread Jani Nikula
On Tue, 06 Dec 2011 18:27:27 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 6 Dec 2011 15:22:36 +0200, Jani Nikula j...@nikula.org wrote: Hi all, this is v3 of the notmuch hooks patches. I think this is nearing completion apart from final review and, most notably,

Re: [PATCH v3 0/2] notmuch hooks

2011-12-07 Thread Austin Clements
Quoth Jani Nikula on Dec 07 at 8:05 pm: On Tue, 06 Dec 2011 22:16:37 -0500, Tom Prince tom.pri...@ualberta.net wrote: On Tue, 06 Dec 2011 18:47:01 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Also, what if we make it so that the post-new hook script only runs if

Re: [PATCH v3 0/2] notmuch hooks

2011-12-07 Thread Jameson Graef Rollins
On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula j...@nikula.org wrote: I wonder, though, whether the samples should be created only when creating the database, or whenever the hooks directory does not exist? The latter, I guess. Otherwise existing notmuch users would hardly get the sample

Re: [PATCH v3 0/2] notmuch hooks

2011-12-06 Thread Tom Prince
On Tue, 06 Dec 2011 18:47:01 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Also, what if we make it so that the post-new hook script only runs if notmuch new processes new messages? All of my post-new functions don't need to be run at all if there is no new mail. Or would it