Re: [Nouveau] [PATCH drm-next v4 14/14] drm/nouveau: debugfs: implement DRM GPU VA debugfs

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Provide the driver indirection iterating over all DRM GPU VA spaces to > enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces. > > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39

Re: [Nouveau] [PATCH drm-next v4 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to request

Re: [Nouveau] [PATCH 01/10] drm/nouveau/nvkm: fini object children in reverse order

2023-06-13 Thread Lyude Paul
For the whole series: Reviewed-by: Lyude Paul On Thu, 2023-05-25 at 10:30 +1000, Ben Skeggs wrote: > From: Ben Skeggs > > Turns out, we're currently tearing down the disp core channel *before* > the satellite channels (wndw, etc) during suspend. > > This makes RM return NV_ERR_NOT_SUPPORTED

Re: [Nouveau] [PATCH 10/10] drm/nouveau/kms: don't call drm_dp_cec_set_edid() on TMDS

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > RM complains very loudly at the aux transaction attempts. > > Signed-off-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_connector.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [Nouveau] [PATCH 09/10] drm/nouveau/nvif: fix potential double-free

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > DRM cleanup paths unconditionally call nvif_mmu_dtor() for clients, > which would result in a double-free if nvif_mmu_ctor()'d previously > failed. > > Signed-off-by: Ben Skeggs > --- >

Re: [Nouveau] [PATCH 08/10] drm/nouveau/fifo/ga100-: add per-runlist nonstall intr handling

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > GSP-RM will enforce this, so implement on HW too so we can share code. > > Signed-off-by: Ben Skeggs > --- > .../drm/nouveau/include/nvkm/core/engine.h| 1 + > .../gpu/drm/nouveau/nvkm/engine/ce/ga100.c| 10

Re: [Nouveau] [PATCH 07/10] drm/nouveau/fifo/ga100-: remove individual runlists rather than failing oneinit

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > We're adding better support for the non-stall interrupt, which will need > to fetch the interrupt vector from the runlist's primary engine. > > NVKM doesn't support all target engines (ie. NVDEC etc), and it wouldn't > be

Re: [Nouveau] [PATCH 06/10] drm/nouveau/fifo: return ERR_PTR from nvkm_runl_new()

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > Callers expect this - not NULL. > > Signed-off-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Nouveau] [PATCH 05/10] drm/nouveau/fifo: remove left-over references to nvkm_fifo_chan

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > This was renamed to nvkm_chan in the host rework. > > Signed-off-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/include/nvkm/core/engine.h | 5 ++--- > drivers/gpu/drm/nouveau/include/nvkm/core/os.h | 5 - >

Re: [Nouveau] [PATCH 03/10] drm/nouveau/fb/gp102-ga100: switch to simpler vram size detection method

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > Also exposes this for use by upcoming GSP-RM initialisation code. > > Signed-off-by: Ben Skeggs > --- > .../gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/Kbuild | 1 + >

Re: [Nouveau] [PATCH 02/10] drm/nouveau/nvkm: punt spurious irq messages to debug level

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > This can be completely normal in some situations (ie. non-stall intrs > when nothing is waiting on them). > > Signed-off-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nvkm/core/intr.c | 4 ++-- > 1 file changed, 2

Re: [Nouveau] [PATCH 01/10] drm/nouveau/nvkm: fini object children in reverse order

2023-06-13 Thread Karol Herbst
On Thu, May 25, 2023 at 2:31 AM Ben Skeggs wrote: > > From: Ben Skeggs > > Turns out, we're currently tearing down the disp core channel *before* > the satellite channels (wndw, etc) during suspend. > > This makes RM return NV_ERR_NOT_SUPPORTED on attempting to reallocate > the core channel on

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv50-: Fix drm_dp_remove_payload() invocation

2023-06-13 Thread Karol Herbst
On Tue, Jun 13, 2023 at 11:05 PM Lyude Paul wrote: > > We changed the semantics for this in: > > e761cc20946a ("drm/display/dp_mst: Handle old/new payload states in > drm_dp_remove_payload()") > > But I totally forgot to update this properly in nouveau. So, let's do that. > > Signed-off-by:

[Nouveau] [PATCH] drm/nouveau/kms/nv50-: Fix drm_dp_remove_payload() invocation

2023-06-13 Thread Lyude Paul
We changed the semantics for this in: e761cc20946a ("drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()") But I totally forgot to update this properly in nouveau. So, let's do that. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 ++--

Re: [Nouveau] [PATCH] nouveau_connector: add nv_encoder pointer check for NULL

2023-06-13 Thread Lyude Paul
Nice catch! Reviewed-by: Lyude Paul Will push upstream On Fri, 2023-05-12 at 13:33 +0300, Natalia Petrova wrote: > Pointer nv_encoder could be dereferenced at nouveau_connector.c > in case it's equal to NULL by jumping to goto label. > This patch adds a NULL-check to avoid it. > > Found by

Re: [Nouveau] [PATCH] drm/nouveau/dp: check for NULL nv_connector->native_mode

2023-06-13 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a bit On Fri, 2023-05-12 at 14:15 +0300, Natalia Petrova wrote: > Add checking for NULL before calling nouveau_connector_detect_depth() in > nouveau_connector_get_modes() function because nv_connector->native_mode > could be dereferenced there since

Re: [Nouveau] [PATCH drm-next v4 02/14] maple_tree: split up MA_STATE() macro

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:31]: > Split up the MA_STATE() macro such that components using the maple tree > can easily inherit from struct ma_state and build custom tree walk > macros to hide their internals from users. > > Example: > > struct sample_iterator { > struct ma_state mas; >

Re: [Nouveau] [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-13 Thread Danilo Krummrich
Hi Donald, On 6/9/23 13:56, Donald Robson wrote: On Wed, 2023-06-07 at 00:31 +0200, Danilo Krummrich wrote: Christian König (1): drm: execution context for GEM buffers v4 Danilo Krummrich (13): maple_tree: split up MA_STATE() macro drm: manager to keep track of GPUs VA mappings I