Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Emil Velikov
On 24 August 2016 at 13:11, Martin Peres wrote: > On 23/08/16 17:43, Emil Velikov wrote: >> >> On 23 August 2016 at 00:42, Martin Peres wrote: >>> >>> v2: >>> - guard LED framework calls with ifdef CONFIG_LEDS_CLASS >>> >> IIRC kernel has the

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Karol Herbst
https://www.kernel.org/doc/Documentation/CodingStyle "Chapter 20: Conditional Compilation" ;) 2016-08-24 14:11 GMT+02:00 Martin Peres : > On 23/08/16 17:43, Emil Velikov wrote: >> >> On 23 August 2016 at 00:42, Martin Peres wrote: >>> >>> v2: >>> -

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Lukas Wunner
On Wed, Aug 24, 2016 at 03:11:12PM +0300, Martin Peres wrote: > On 23/08/16 17:43, Emil Velikov wrote: > > On 23 August 2016 at 00:42, Martin Peres wrote: > > > v2: > > > - guard LED framework calls with ifdef CONFIG_LEDS_CLASS > > > > > IIRC kernel has the tendency of

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-24 Thread Martin Peres
On 23/08/16 17:43, Emil Velikov wrote: On 23 August 2016 at 00:42, Martin Peres wrote: v2: - guard LED framework calls with ifdef CONFIG_LEDS_CLASS IIRC kernel has the tendency of using static inlines in the headers when CONFIG_foo is not set. Worth using that and

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Emil Velikov
On 23 August 2016 at 00:42, Martin Peres wrote: > v2: > - guard LED framework calls with ifdef CONFIG_LEDS_CLASS > IIRC kernel has the tendency of using static inlines in the headers when CONFIG_foo is not set. Worth using that and removing the ifdef from the source file ?

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Karol Herbst
2016-08-23 16:06 GMT+02:00 Martin Peres : > On 23/08/16 11:31, Karol Herbst wrote: >> >> maybe it makes sense to expose the SLI LED, too. >> >> Regardless of my comments this patch is reviewed-by me. > > > You reviewed the wrong patch, I should have named the re-send v3. > >

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Martin Peres
On 23/08/16 11:31, Karol Herbst wrote: maybe it makes sense to expose the SLI LED, too. Regardless of my comments this patch is reviewed-by me. You reviewed the wrong patch, I should have named the re-send v3. I accidentally sent the v1 patch as a v2 :s 2016-08-23 1:39 GMT+02:00 Martin

[Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Martin Peres
v2: - guard LED framework calls with ifdef CONFIG_LEDS_CLASS Signed-off-by: Martin Peres --- For real this time! Sorry for the noise drm/nouveau/Kbuild | 1 + drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nouveau_drm.c

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

2016-08-23 Thread Karol Herbst
maybe it makes sense to expose the SLI LED, too. Regardless of my comments this patch is reviewed-by me. 2016-08-23 1:39 GMT+02:00 Martin Peres : > We received a donation of a Titan which has this useless feature > allowing users to control the brightness of the LED behind