Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes

On 21/03/2021 22:02, Juha-Pekka Heikkila wrote: On 18.3.2021 8.41, Martin Peres wrote: On 18/03/2021 00:44, Lyude wrote: From: Lyude Paul Currently, nouveau doesn't support having a CRTC without a primary FB set. We won't reject such configurations, but the behavior is undefined which

Re: [Nouveau] [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_cursor_crc: Probe kernel for cursor size support

any other test. Not sure I can comment on the implementation details of require_cursor_size(), but everything else, and the series is: Reviewed-by: Martin Peres Signed-off-by: Lyude Paul Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline --- tests/kms_cursor_crc.c |

Re: [Nouveau] [igt-dev] [PATCH i-g-t 0/3] tests/kms_color: Fixup for nouveau

kernel patches to fix these in nouveau very shortly. The series is: Reviewed-by: Martin Peres Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline Lyude Paul (3): tests/kms_color: Don't opencode igt_check_crc_equal() tests/kms_color: Allow tests to run on any driver tests/kms_color

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't unset primary_fb when testing other planes

-primary planes. Looks good to me: Reviewed-by: Martin Peres Signed-off-by: Lyude Paul Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline --- tests/kms_plane.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 298a9375

Re: [Nouveau] [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work

On 18/03/2021 00:49, Lyude wrote: From: Lyude Paul These are just a couple of small fixes that didn't seem important enough to stick in their own patch series, but were various issues with igt that I found along the way during my recent nouveau igt work. Cc: Martin Peres Cc: Jeremy Cline

Re: [Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library

tests which test tiling formats to run on nouveau, and fix some seemingly random test failures as a result of not having zero-filled buffers in a few other tests like kms_cursor_crc. \o/ More comments inline :) Signed-off-by: Lyude Paul Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline

Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

that Intel should add skips or fix the kernel to support these 32xXX format. @Petri, could you get someone to investigate this? In the mean time, here is my: Reviewed-by: Martin Peres Martin Signed-off-by: Lyude Paul Cc: Martin Peres Cc: Ben Skeggs Cc: Jeremy Cline --- tests

Re: [Nouveau] [PATCH] drm/nouveau: Don't disable polling in fallback mode

called when changing the pstate. However, in the absence of ANY information, we fallback to a temperature-based management which requires constant polling, so the patch is accurate and poll = false should only be set if we have a cstate. So, the patch is Reviewed-by: Martin Peres > >>

Re: [Nouveau] Aspirant for GSOC 2018 for Nouveau Vulkan driver

Hi Anusha, Sorry, I was under the expectation that userspace developers would answer you after your first message, and I missed your second one! My sincere apologies. Generally, the process is that the student should research the topic by first asking questions to developers about the effort,

[Nouveau] Google Summer of Code 2018

Hi everyone, Just a quick word to remind you that the X.Org Foundation got accepted to the Google Summer of Code 2018! As a potential mentor, if you have a project falling under the foundation's (large) umbrella that you would like to kick start or get help finishing, please add it to the list

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

On 07/02/18 05:31, John Hubbard wrote: > On 01/28/2018 04:05 PM, Martin Peres wrote: >> On 29/01/18 01:24, Martin Peres wrote: >>> On 28/11/17 07:32, John Hubbard wrote: >>>> On 11/23/2017 02:48 PM, Martin Peres wrote: >>>>> On 23/11/17 10:06, John

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

On 29/01/18 09:51, John Hubbard wrote: > On 01/28/2018 04:05 PM, Martin Peres wrote: >> On 29/01/18 01:24, Martin Peres wrote: >>> On 28/11/17 07:32, John Hubbard wrote: >>>> On 11/23/2017 02:48 PM, Martin Peres wrote: >>>>> On 23/11/17 10:06, John

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

On 28/11/17 07:32, John Hubbard wrote: > On 11/23/2017 02:48 PM, Martin Peres wrote: >> On 23/11/17 10:06, John Hubbard wrote: >>> On 11/22/2017 05:07 PM, Martin Peres wrote: >>>> Hey, >>>> >>>> Thanks for your answer, Andy! >>>&g

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

On 29/01/18 01:24, Martin Peres wrote: > On 28/11/17 07:32, John Hubbard wrote: >> On 11/23/2017 02:48 PM, Martin Peres wrote: >>> On 23/11/17 10:06, John Hubbard wrote: >>>> On 11/22/2017 05:07 PM, Martin Peres wrote: >>>>> Hey, >>>>> &g

Re: [Nouveau] [RFC v3 2/4] drm/nouveau: Add support for BLCG on Kepler1

g up the GPU. However, the values used by > the vbios are more power hungry then they need to be, so the nvidia driver then -> than. With the comment about not exposing clock gating until patch 2, 3, and 4 have landed addressed, the series is: Reviewed-by: Martin Peres <martin.pe...@free

Re: [Nouveau] [RFC v3 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

m/Kbuild > @@ -10,6 +10,7 @@ nvkm-y += nvkm/subdev/therm/nv50.o > nvkm-y += nvkm/subdev/therm/g84.o > nvkm-y += nvkm/subdev/therm/gt215.o > nvkm-y += nvkm/subdev/therm/gf119.o > +nvkm-y += nvkm/subdev/therm/gk104.o > nvkm-y += nvkm/subdev/therm/gm107.o > nvkm-

Re: [Nouveau] [RFC 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

drivers/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild > @@ -10,6 +10,7 @@ nvkm-y += nvkm/subdev/therm/nv50.o > nvkm-y += nvkm/subdev/therm/g84.o > nvkm-y += nvkm/subdev/therm/gt215.o > nvkm-y += nvkm/subdev/therm/gf119.o > +nvkm-y += nvkm/subdev/therm/gk104.o > nvkm-y += nvkm/subdev/t

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

On 23/11/17 10:06, John Hubbard wrote: > On 11/22/2017 05:07 PM, Martin Peres wrote: >> Hey, >> >> Thanks for your answer, Andy! >> >> On 22/11/17 04:06, Ilia Mirkin wrote: >>> On Tue, Nov 21, 2017 at 8:29 PM, Andy Ritger <arit...@nvidia.co

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

Hey, Thanks for your answer, Andy! On 22/11/17 04:06, Ilia Mirkin wrote: > On Tue, Nov 21, 2017 at 8:29 PM, Andy Ritger wrote: >> Hi Martin, > > Martin should have complete answers, > >> >> I was asked to clarify a few things: >> >> (1) Are all the user reports of loud

Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

On 22/11/17 03:42, Karol Herbst wrote: > On Wed, Nov 22, 2017 at 1:32 AM, Martin Peres <martin.pe...@free.fr> wrote: >> On 17/11/17 02:04, Karol Herbst wrote: >>> The current hwmon code doesn't check if the returned value was actually an >>> error. >>> >

Re: [Nouveau] [PATCH 03/32] therm: Split return code and value in nvkm_get_temp

On 17/11/17 02:04, Karol Herbst wrote: > The current hwmon code doesn't check if the returned value was actually an > error. > > Since Kepler temperature sensors are able to report negative values. Those > negative values are not for error reporting, but rather when you buried > your GPU in snow

Re: [Nouveau] [PATCH 02/32] debugfs: Wake up GPU before doing any reclocking

GPU from sleeping): Signed-off-by: Martin Peres <martin.pe...@free.fr> > > Signed-off-by: Karol Herbst <karolher...@gmail.com> > --- > drm/nouveau/nouveau_debugfs.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drm/nouveau/nouveau_debugfs.c b/d

Re: [Nouveau] [PATCH 01/32] bios/vpstate: There are some fermi vbios with no boost or tdp entry

er commit message, this patch is: Signed-off-by: Martin Peres <martin.pe...@free.fr> > --- > drm/nouveau/nvkm/subdev/bios/vpstate.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drm/nouveau/nvkm/subdev/bios/vpstate.c > b/drm/nouveau/n

Re: [Nouveau] Addressing the problem of noisy GPUs under Nouveau

Hello, On 13/11/17 09:15, John Hubbard wrote: > On 11/12/2017 06:29 PM, Martin Peres wrote: >> Hello, >> >> Some users have been complaining for years about their GPU sounding like >> a jet engine at take off. Last year, I finally laid my hand on one of >> these

[Nouveau] Addressing the problem of noisy GPUs under Nouveau

Hello, Some users have been complaining for years about their GPU sounding like a jet engine at take off. Last year, I finally laid my hand on one of these GPUs and have been trying to fix this issue on and off since then. After failing to find anything in the HW, I figured out that the duty

Re: [Nouveau] Project ideas for GSoC/EVoC

On 15/10/17 22:13, Karol Herbst wrote: > Hi everybody, > > currently on the Xorg Wiki page [1] there are only three projects > ideas, two being quite similiar: > 1. Instruction scheduling > 2. Maxwell Video Accel Decoding > 3. Kepler Video Accel Encoding > and also the reference to our Trello

Re: [Nouveau] [PATCH] drm/nouveau: Document nouveau support for Tegra in DRIVER_DESC

ro/Tesla/Tegra" The problem is that we do not support all Tegras. How about Tegra TK1+? I really do not care much about this string, but I guess I probably should a bit. With the TK1 added, this is: Reviewed-by" Martin Peres <martin.pe...@free.fr> > #define DRIVER_DATE

[Nouveau] XDC 2017 : Call for paper

/questions, please send them to Stéphane Marchesin (please also CC: board at foundation.x.org). Martin Peres ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v5 5/5] nouveau_hwmon: Change permissions to numeric

e author of something. Just add yourself if you care about this (I did not care to add my name when I wrote in this file, because the git history makes more sense nowadays. Otherwise, I have no strong opinions on this patch. I guess the numeric representation is easier to read, so I will give you my R

Re: [Nouveau] [PATCH v5 4/5] nouveau_hwmon: Add support for auto_point attributes

dev and split special_groups on the following line. > if (IS_ERR(hwmon_dev)) { > ret = PTR_ERR(hwmon_dev); > NV_ERROR(drm, "Unable to register hwmon device: %d\n", ret); > This commit breaks bisectability, so Ben may have to squash it in the previous one. Otherwise, this looks good to me: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v5 3/5] nouveau_hwmon: Remove old code, add .write/.read operations

, > _temp_attrgroup); > - if (ret) > - goto error; > - } > - > - /* if the card has a pwm fan */ > - /*XXX: incorrect, need better detection for this, some boards > have > - * the gpio entries for pwm fan control even when there's no > - * actual fan connected to it... therm table? */ > - if (therm->fan_get && therm->fan_get(therm) >= 0) { > - ret = sysfs_create_group(_dev->kobj, > - _pwm_fan_attrgroup); > - if (ret) > - goto error; > - } > - } > - > - /* if the card can read the fan rpm */ > - if (therm && nvkm_therm_fan_sense(therm) >= 0) { > - ret = sysfs_create_group(_dev->kobj, > - _fan_rpm_attrgroup); > - if (ret) > - goto error; > - } > - > - if (volt && nvkm_volt_get(volt) >= 0) { > - ret = sysfs_create_group(_dev->kobj, > - _in0_attrgroup); > - > - if (ret) > - goto error; > - } > - > - if (iccsense && iccsense->data_valid && !list_empty(>rails)) { > - ret = sysfs_create_group(_dev->kobj, > - _power_attrgroup); > - > - if (ret) > - goto error; > - > - if (iccsense->power_w_max && iccsense->power_w_crit) { > - ret = sysfs_create_group(_dev->kobj, > - _power_caps_attrgroup); > - if (ret) > - goto error; > - } > - } > > hwmon->hwmon = hwmon_dev; > - > return 0; > - > -error: > - NV_ERROR(drm, "Unable to create some hwmon sysfs files: %d\n", ret); > - hwmon_device_unregister(hwmon_dev); > - hwmon->hwmon = NULL; > - return ret; > #else > return 0; > #endif > @@ -1037,17 +822,8 @@ nouveau_hwmon_fini(struct drm_device *dev) > #if defined(CONFIG_HWMON) || (defined(MODULE) && > defined(CONFIG_HWMON_MODULE)) > struct nouveau_hwmon *hwmon = nouveau_hwmon(dev); > > - if (hwmon->hwmon) { > - sysfs_remove_group(>hwmon->kobj, > _default_attrgroup); > - sysfs_remove_group(>hwmon->kobj, _temp_attrgroup); > - sysfs_remove_group(>hwmon->kobj, > _pwm_fan_attrgroup); > - sysfs_remove_group(>hwmon->kobj, > _fan_rpm_attrgroup); > - sysfs_remove_group(>hwmon->kobj, _in0_attrgroup); > - sysfs_remove_group(>hwmon->kobj, _power_attrgroup); > - sysfs_remove_group(>hwmon->kobj, > _power_caps_attrgroup); > - > + if (hwmon->hwmon) > hwmon_device_unregister(hwmon->hwmon); > - } > > nouveau_drm(dev)->hwmon = NULL; > kfree(hwmon); > Thanks a lot, this patch makes a huge improvement in readability! With the comments addressed, this patch is: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v5 2/5] nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string

> + > +static int > +nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 > attr, > + int channel, char **buf) Same as above. > +{ > + if (type == hwmon_in && attr == hwmon_in_label) { >

Re: [Nouveau] [PATCH] volt: Improve min/max deteaction of range based volting

volt->vid_nr++; + volt->min_uv = min(volt->min_uv, info.base); + volt->max_uv = max(volt->max_uv, info.base); } info.base += info.step;

Re: [Nouveau] A request for Virtual GPU based on Nouveau

On 25/02/17 05:39, Zhengjie (PARC) wrote: Hi, I’m a developer from Huawei Technologies Co.,Ltd. China. I’m working on GPU Virtualization. I found some academic papers on google which describe how to virtualize GPU on Cloud based on Nouveau, Such as < TimeGraph: GPU Scheduling for Real-Time

Re: [Nouveau] [PATCH 9/9] clk: Check pm_runtime status before reclocking

On 05/03/17 18:35, Karol Herbst wrote: We don't want to change anything on the GPU if it's suspended. Also we need to increase the refcount on the pm_runtime counter so that the GPU won't be suspended while reclocking. Signed-off-by: Karol Herbst ---

Re: [Nouveau] [PATCH 8/9] clk: Set clocks to pre suspend state after suspend

viewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nvkm/subdev/clk/base.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/clk/base.c b/drm/nouveau/nvkm/subdev/clk/base.c index 54a4b7fa..bc65906e 100644 --- a/drm/nouveau/nvkm/subdev/clk/

Re: [Nouveau] [PATCH 5/9] clk: We should pass the pstate id around not the index in the list

bst <karolher...@gmail.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nouveau_debugfs.c | 6 +-- drm/nouveau/nvkm/subdev/clk/base.c | 78 +++--- 2 files changed, 41 insertions(+), 43 deletions(-) diff --git a/drm/nouveau/nouveau_

Re: [Nouveau] [PATCH 3/9] clk: Make pstate a pointer to nvkm_pstate

ng them up every second. Signed-off-by: Karol Herbst <karolher...@gmail.com> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/include/nvkm/subdev/clk.h | 4 +++- drm/nouveau/nvkm/engine/device/ctrl.c | 5 - drm/nouveau/nvkm/subdev/clk/base.c| 17 -

Re: [Nouveau] [PATCH 1/9] clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it

On 05/03/17 18:34, Karol Herbst wrote: This function will be used to update the current clock state. This will happen for various reasons: * Temperature changes * User changes clocking state * Load changes Signed-off-by: Karol Herbst ---

[Nouveau] [PATCH] drm/nouveau/led: prevent a possible use-after-free

scosta <emmanuelpescosta...@gmail.com> Signed-off-by: Martin Peres <martin.pe...@free.fr> --- Ben, I do not have a 4.10 kernel available to at least test-compile the patch. Could you make sure it works before applying it? After all the trouble we got from the LED before, I don't want to add

Re: [Nouveau] nouveau_drm.c: undefined reference to `nouveau_led_init'

On 12/01/17 09:55, George Spelvin wrote: If CONFIG_DRM_NOUVEAU=y and CONFIG_LEDS_CLASS=m, then nouveau_led.o is neither stubbed out nor compiled in and the compile fails with undefined symbols in nouveau_drm.c. I'm guessing it's commit 8d021d71b324. (Thanks for the cool hack, BTW, even if I

[Nouveau] [PATCH] nouveau/led: prevent compiling the led-code if nouveau=y and leds=m

rgmann <a...@arndb.de> Reported-by: Intel's 0-DAY Fixes: 8d021d71b324 ("drm/nouveau/drm/nouveau: add a LED driver for the NVIDIA logo") Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu/drm/nouveau/nouveau_led.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Nouveau] [PATCH] nouveau/led: introduce CONFIG_DRM_NOUVEAU_LEDS

On 07/12/16 05:32, Martin Peres wrote: This fixes the auto-magic detection of LEDS_CLASS by fixing the case where nouveau would be built-in and the LEDS_CLASS would be built as as module. Cc: <sta...@vger.kernel.org> # 4.9.x- Reported-by: Intel's 0-DAY Signed-off-by: Martin Peres <

[Nouveau] [PATCH] nouveau/led: introduce CONFIG_DRM_NOUVEAU_LEDS

This fixes the auto-magic detection of LEDS_CLASS by fixing the case where nouveau would be built-in and the LEDS_CLASS would be built as as module. Cc: <sta...@vger.kernel.org> # 4.9.x- Reported-by: Intel's 0-DAY Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drivers/gpu

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

On 08/11/16 15:56, Arnd Bergmann wrote: The newly introduced LED handling for nouveau fails to link when the driver is built-in but the LED subsystem is a loadable module: drivers/gpu/drm/nouveau/nouveau.o: In function `nouveau_do_suspend': tvnv17.c:(.text.nouveau_do_suspend+0x10): undefined

Re: [Nouveau] [PATCH 3/3] hwmon: expose power_max and power_crit

On 25/10/16 00:11, Karol Herbst wrote: Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_hwmon.c | 44 1 file changed, 44 insertions(+) diff --git a/drm/nouveau/nouveau_hwmon.c b/drm/nouveau/nouveau_hwmon.c index

Re: [Nouveau] [PATCH 2/3] subdev/iccsense: Parse max and crit power level

On 25/10/16 00:11, Karol Herbst wrote: Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c| 13 - 2 files changed, 15 insertions(+), 1 deletion(-) What is the point of duplicating

Re: [Nouveau] [PATCH 1/3] nvbios/power_budget: Add basic power budget parsing

On 25/10/16 00:11, Karol Herbst wrote: Signed-off-by: Karol Herbst --- .../include/nvkm/subdev/bios/power_budget.h| 20 drm/nouveau/nvkm/subdev/bios/Kbuild| 1 + drm/nouveau/nvkm/subdev/bios/power_budget.c| 108

Re: [Nouveau] RFC [PATCH 0/3] Expose power budget cap via hwmon

On 25/10/16 00:11, Karol Herbst wrote: There is an optinal header field in the power budget table we can use to read out the power cap of the GPU. Sadly it is optional and if that field isn't sad, things beome oh why would it be sad? Poor little one :p complicated. Anyhow, this is good

Re: [Nouveau] [PATCH 5/5] recognize and accelerate GM20x

On 18/10/16 12:19, Alexandre Courbot wrote: On Mon, Oct 17, 2016 at 6:47 PM, Samuel Pitoiset wrote: This requires at least a quick test. :-) Acked-by: Samuel Pitoiset On 10/16/2016 09:14 PM, Ilia Mirkin wrote: Signed-off-by: Ilia

[Nouveau] [PATCH] drm/therm/fan: add a fallback if no fan control is specified in the vbios

This seems to be absolutely necessary for a lot of NV40. Reported-by: gsgf on IRC/freenode Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nvkm/subdev/therm/base.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drm/nouvea

Re: [Nouveau] [PATCH 1/2] Revert "bus: remove cpu_coherent flag"

On 19/09/16 06:50, Alexandre Courbot wrote: On Mon, Sep 19, 2016 at 12:43 PM, Ilia Mirkin wrote: On Sun, Sep 18, 2016 at 11:39 PM, Alexandre Courbot wrote: On Sun, Sep 18, 2016 at 7:21 PM, Karol Herbst wrote: This reverts

[Nouveau] [PATCH] drm/nouveau/led: make all the stub functions static inline

Suggested-by: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nouveau_led.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drm/nouveau/nouveau_led.h b/drm/nouveau/nouveau_led.h index 750a0d9..187ecdb 1006

Re: [Nouveau] [PATCH 2/3] drm/nouveau/led: guard against a division by 0

On 16/09/16 10:42, Karol Herbst wrote: Reviewed-by: Karol Herbst <karolher...@gmail.com> 2016-09-16 9:34 GMT+02:00 Martin Peres <martin.pe...@free.fr>: Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nouveau_led.c | 5 - 1 file changed, 4 inserti

[Nouveau] [PATCH 3/3] drm/nouveau/led: abort early if the device does not have GPIOs

Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nouveau_led.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c index 1f731da..3e2f1b6 100644 --- a/drm/nouveau/nouveau_led.c +++ b/drm/nouveau/nouveau_led.c @@

[Nouveau] [PATCH 1/3] drm/nouveau/led: don't access led subdev if it wasn't initialized

From: Karol Herbst Fixes a kernel crash on suspend/resume. --- drm/nouveau/nouveau_led.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c index 9eed5a6..5e28b5f 100644 ---

[Nouveau] [PATCH 2/3] drm/nouveau/led: guard against a division by 0

Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nouveau_led.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nouveau_led.c b/drm/nouveau/nouveau_led.c index 5e28b5f..1f731da 100644 --- a/drm/nouveau/nouveau_led.c +++ b/drm/n

[Nouveau] [PATCH v3 take 2] drm/nouveau: add a LED driver for the NVIDIA logo

ifdefs everywhere, follow the recommendations of /doc/Documentation/CodingStyle. Suggested by Emil Velikov. Signed-off-by: Martin Peres <martin.pe...@free.fr> --- I again managed to send the wrong patch... I guess porting patches between kernels and then scp'ing at 4am is not something I

[Nouveau] [PATCH v3] drm/nouveau: add a LED driver for the NVIDIA logo

ifdefs everywhere, follow the recommendations of /doc/Documentation/CodingStyle. Suggested by Emil Velikov. Reviewed-by: Karol Herbst <karolher...@gmail.com> Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/Kbuild | 1 + drm/nouveau/include

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

On 23/08/16 17:43, Emil Velikov wrote: On 23 August 2016 at 00:42, Martin Peres <martin.pe...@free.fr> wrote: v2: - guard LED framework calls with ifdef CONFIG_LEDS_CLASS IIRC kernel has the tendency of using static inlines in the headers when CONFIG_foo is not set. Worth

Re: [Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

ED/PWM to the LED subsystem which allows blinking it in sync with cpu/disk/network/whatever activity (heartbeat is quite nice!). Users may also implement some breathing effect or morse code support in the userspace if they feel like it. Signed-off-by: Martin Peres <martin.pe...@free.fr> ---

[Nouveau] [PATCH v2] drm/nouveau: add a LED driver for the NVIDIA logo

v2: - guard LED framework calls with ifdef CONFIG_LEDS_CLASS Signed-off-by: Martin Peres <martin.pe...@free.fr> --- For real this time! Sorry for the noise drm/nouveau/Kbuild | 1 + drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nouveau

Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

On 07/05/16 23:44, karol herbst wrote: looks good, just a minor thing: You need to check for CONFIG_LEDS_CLASS, otherwise the compile throws out "warnings": WARNING: "led_classdev_register" [/home/karol/Dokumente/repos/nouveau/drm/nouveau/nouveau.ko] undefined! WARNING: "led_classdev_resume"

Re: [Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

On 04/05/16 02:57, Ilia Mirkin wrote: On Tue, May 3, 2016 at 7:51 PM, Martin Peres <martin.pe...@free.fr> wrote: We received a donation of a Titan which has this useless feature allowing users to control the brightness of the LED behind the logo of NVIDIA. In the true spirit of open

[Nouveau] [PATCH] drm/nouveau: add a LED driver for the NVIDIA logo

allows blinking it in sync with cpu/disk/network/whatever activity (heartbeat is quite nice!). Users may also implement some breathing effect or morse code support in the userspace if they feel like it. Signed-off-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/

Re: [Nouveau] [PATCH v4 27/37] clk: make pstate a pointer to nvkm_pstate

On 21/04/16 00:46, karol herbst wrote: 2016-04-20 20:53 GMT+00:00 Martin Peres <martin.pe...@free.fr>: On 18/04/16 22:14, Karol Herbst wrote: we will access the current set cstate at least every second and this safes us saves some CPU cycles looking them up every second. Sign

Re: [Nouveau] [PATCH v4 37/37] volt: add NvVoltOffsetmV option

nvkm_volt_map(volt, volt->max2_id, temp, false)); So, this ugly dance of having true or flase depending on whether we are looking for a pstate or a cstate looks really ugly, but it does make some sense. Given how useful this may be to debug voltage-related issues, I would say it is worth the

Re: [Nouveau] [PATCH v4 36/37] WIP volt/gk104: readout speedo

and get rid of this confusing talk about the PWM voltage management, because I really do not get how it is relevant. With this addressed: Reviewed-by: Martin Peres <martin.pe...@free.fr> + ret = nvkm_fuse_read(fuse, 0x3a8); + nvkm_wr32(device, 0x122634, 0x41); + return ret; +} + s

Re: [Nouveau] [PATCH v4 35/37] clk: set clocks to pre suspend state after suspend

On 18/04/16 22:14, Karol Herbst wrote: Signed-off-by: Karol Herbst <nouv...@karolherbst.de> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nvkm/subdev/clk/base.c | 19 +++ drm/nouveau/nvkm/subdev/clk/gf100.c | 4 ++-- drm/nouveau/nvkm/subde

Re: [Nouveau] [PATCH v4 34/37] mc: fix NULL pointer access in libnouveau

On 18/04/16 22:14, Karol Herbst wrote: Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/mc/base.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nvkm/subdev/mc/base.c b/drm/nouveau/nvkm/subdev/mc/base.c index

Re: [Nouveau] [PATCH v4 33/37] therm: trigger reclock in temperature daemon

On 18/04/16 22:14, Karol Herbst wrote: depending on the temperature, cstates might become unreachable or the maped voltage of a cstate changes. We want to adjust to that. Yeah! That was a lot of plumbing to get to this, but it is here! Reviewed-by: Martin Peres <martin.pe...@free.fr>

Re: [Nouveau] [PATCH v4 32/37] clk: only do partial reclocks as required

On 18/04/16 22:14, Karol Herbst wrote: we don't want to reclock to the same pstate or cstate over and over again, so only do things we actually have to do. v4: move into gf100 Reviewed-by: Martin Peres <martin.pe...@free.fr> Signed-off-by: Karol Herbst <nouv...@karolherbst.de&g

Re: [Nouveau] [PATCH v4 31/37] clk: split out update code to nv40

On 18/04/16 22:14, Karol Herbst wrote: this code will change for gf100 and newer Reviewed-by: Martin Peres <martin.pe...@free.fr> Signed-off-by: Karol Herbst <nouv...@karolherbst.de> --- drm/nouveau/nvkm/subdev/clk/base.c | 14 ++ drm/nouveau/nvkm/subdev/clk/

Re: [Nouveau] [PATCH v4 30/37] clk: seperate the locking from the implementation in nvkm_clk_update

sepArate On 18/04/16 22:14, Karol Herbst wrote: Would be nice to say what for. With a better commit message and the typo fixed: Reviewed-by: Martin Peres <martin.pe...@free.fr> Signed-off-by: Karol Herbst <nouv...@karolherbst.de> --- drm/nouveau/nvkm/subdev/clk

Re: [Nouveau] [PATCH v4 29/37] clk: we should pass the pstate id around not the index in the list

On 18/04/16 22:14, Karol Herbst wrote: this makes the code easier, because we can compare the id with pstate->pstate and safe us the trouble iterating over the entire pstate list save us. Not the easiest patch to read, but it seems alright and it has been tested, so: Reviewed-by: Mar

Re: [Nouveau] [PATCH v4 28/37] clk: hold information about the current cstate status

; else clk->ustate_dc = ret; + clk->exp_cstate = NVKM_CLK_CSTATE_HIGHEST; I am really not a fan of this astate. We will revisit this when we are done with manual reclocking! In the mean time, this is: Reviewed-by: Martin Peres <martin.pe.

Re: [Nouveau] [PATCH v4 27/37] clk: make pstate a pointer to nvkm_pstate

On 18/04/16 22:14, Karol Herbst wrote: we will access the current set cstate at least every second and this safes us saves some CPU cycles looking them up every second. Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/clk.h | 2 +-

Re: [Nouveau] [PATCH v4 26/37] therm: don't cancel the timer

On 18/04/16 22:14, Karol Herbst wrote: we will need a always running therm daemon to adjust the voltage/clocks on the fly. Signed-off-by: Karol Herbst <nouv...@karolherbst.de> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/nvkm/subdev/therm/base.c | 9 ++

Re: [Nouveau] [PATCH v4 25/37] clk: remove dstate and tstate

On 20/04/16 23:45, Martin Peres wrote: On 18/04/16 22:13, Karol Herbst wrote: we won't need them, because we will adjust the clocks depending on engine loads later on anyway. It also simplifies the clocking logic. You can also say that the code was just mocked up anyway. Forgot to give my R

Re: [Nouveau] [PATCH v4 25/37] clk: remove dstate and tstate

On 18/04/16 22:13, Karol Herbst wrote: we won't need them, because we will adjust the clocks depending on engine loads later on anyway. It also simplifies the clocking logic. You can also say that the code was just mocked up anyway. Signed-off-by: Karol Herbst ---

Re: [Nouveau] [PATCH v4 22/37] clk: rename nvkm_pstate_calc to nvkm_clk_update

On 18/04/16 22:13, Karol Herbst wrote: this function will be used to update the current clock state. This will happen for various reasons: * temperature changes (may change cstate and/or voltage) * user changes boost mode * load changes v2: add wait parameter Signed-off-by: Karol Herbst

Re: [Nouveau] [PATCH v4 21/37] clk: save the max clock we can set

On 18/04/16 22:13, Karol Herbst wrote: Signed-off-by: Karol Herbst <nouv...@karolherbst.de> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/include/nvkm/subdev/clk.h | 1 + drm/nouveau/nvkm/subdev/clk/base.c| 2 ++ 2 files changed, 3 insertions(+) diff

Re: [Nouveau] [PATCH v4 20/37] volt: add coefficients

On 20/04/16 00:54, Ilia Mirkin wrote: On Tue, Apr 19, 2016 at 5:52 PM, Martin Peres <martin.pe...@free.fr> wrote: + result = ((s64)info.arg[0] * 15625) >> 18; + result += ((s64)info.arg[1] * volt->speedo

Re: [Nouveau] [PATCH v4 20/37] volt: add coefficients

until we know better, let's stick to them. Hopefully, we can figure out where this 15625 comes from. This patch is: Reviewed-by: Martin Peres <martin.pe...@free.fr> + case 0x3: + result = (info.min + info.max) / 2; +

Re: [Nouveau] [PATCH v4 19/37] volt: add gf100 subdev with speedo

; + + return nvkm_voltgpio_init(volt); +} This is OK because fuse is initialized before volt (drm/nouveau/include/nvkm/core/device.h). This is: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freed

Re: [Nouveau] [PATCH v4 16/37] volt: don't require perfect fit

ou may set best_err to the maximum voltage, anything under that may fail in theory. With this fixed, this is: Reviewed-by: Martin Peres <martin.pe...@free.fr> if (volt->func->volt_set) return volt->func->volt_set(volt, uv); for (i = 0; i < volt-&

Re: [Nouveau] [PATCH v4 17/37] bios/vmap: unk0 field is the mode

Herbst <nouv...@karolherbst.de> Reviewed-by: Martin Peres <martin.pe...@free.fr> --- drm/nouveau/include/nvkm/subdev/bios/vmap.h | 2 +- drm/nouveau/nvkm/subdev/bios/vmap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev

Re: [Nouveau] [PATCH v4 18/37] volt: add speedo

atch) to read the speedo. Either way, I do not really care, as this won't go in the kernel anyway and it does not hurt to enable this a little early. Reviewed-by: Martin Peres <martin.pe...@free.fr> (1ULL << NVKM_SUBDEV_GPIO) | // (1

Re: [Nouveau] [PATCH v4 15/37] clk: allow boosting only when NvBoost is set

make 1 the default. Please change it to keep my R-b :) 2: boost to max clock available v2: moved into nvkm_cstate_valid v4: check the existence of the clocks before limiting Signed-off-by: Karol Herbst <nouv...@karolherbst.de> Reviewed-by: Martin Peres <martin.pe...@free.fr> ---

Re: [Nouveau] [PATCH v4 13/37] clk: respect voltage limits in nvkm_cstate_prog

ate, cstatei); + cstate = nvkm_cstate_find_best(clk, pstate, cstate); } else { cstate = >base; } Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v4 10/37] add daemon to compare nouveau with blob voltage

tage, new_nouveau_voltage - new_voltage, + 100 * (double)new_nouveau_voltage / new_voltage, + new_pstate, new_cstate, new_temp); + } + usleep(10); + } + + return 0; +} I am surprised by how short this tool is.

Re: [Nouveau] [PATCH v4 11/37] volt: add temperature parameter to nvkm_volt_map

ret = nvkm_volt_set(volt, ret); With the commit message and the max() duplication fixed, this is: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v4 08/37] clk: export nvkm_volt_map

struct nvkm_volt *volt, u8 id) { struct nvkm_bios *bios = volt->subdev.device->bios; Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH v4 06/37] volt: parse the max voltage map entries

lt->max1_id = vmap.max1; + volt->max2_id = vmap.max2; + } else { + volt->max0_id = 0xff; + volt->max1_id = 0xff; + volt->max2_id = 0xff; + } } if (volt->v

Re: [Nouveau] [PATCH v2 16/22] volt: don't require perfect fit

On 21/03/16 18:16, Karol Herbst wrote: if we calculate the voltage in the table right, we get all kinds of values, which never fit the hardware steps, so we use the closest higher value the hardware can do This is indeed the goal. Signed-off-by: Karol Herbst ---

Re: [Nouveau] [PATCH v2 18/22] volt: add coefficients I found on my gpu

On 21/03/16 18:16, Karol Herbst wrote: I am sure that those are a bit different on other GPUs, but while testing the error range compared to nvidia was around 100%+-3%. Without this change we are most of the time around 10% below nvidias voltage, so this change causes no harm and improves the

Re: [Nouveau] [PATCH v2 06/22] volt: parse the both max voltage entries

On 28/03/16 23:49, Martin Peres wrote: On 21/03/16 18:16, Karol Herbst wrote: these entries specify a maximum voltage nvidia never exceeds, we shouldn't do that, too. Signed-off-by: Karol Herbst <nouv...@karolherbst.de> --- drm/nouveau/include/nvkm/subdev/bios/vmap.h | 2 ++ drm/n

Re: [Nouveau] [PATCH v2 22/22] debugfs: add boost interface to change the boost_mode

On 21/03/16 18:16, Karol Herbst wrote: Signed-off-by: Karol Herbst <nouv...@karolherbst.de> 21-22 are: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop

Re: [Nouveau] [PATCH v2 07/22] volt: add min_id parameter to nvkm_volt_set_id

On 28/03/16 23:52, Martin Peres wrote: On 21/03/16 18:16, Karol Herbst wrote: min_id indicates a volt map entry which acts as a floor value, this will be used to set the lower voltage limit through pstates Please state that this comes that this min_id is different for each pstate, hence why

Re: [Nouveau] [PATCH v2 07/22] volt: add min_id parameter to nvkm_volt_set_id

To me, volt should just allow you to read back and set a voltage. All the rest of the logic should be in clk. Since this is my first NAK, here are my R-b for 3, 4 and 5: Reviewed-by: Martin Peres <martin.pe...@free.fr> ___ Nouveau mailing

  1   2   3   4   >