On 24 August 2016 at 13:11, Martin Peres wrote:
> On 23/08/16 17:43, Emil Velikov wrote:
>>
>> On 23 August 2016 at 00:42, Martin Peres wrote:
>>>
>>> v2:
>>> - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>>>
>> IIRC kernel has the tendency of using static inlines in the headers
>> w
https://www.kernel.org/doc/Documentation/CodingStyle
"Chapter 20: Conditional Compilation" ;)
2016-08-24 14:11 GMT+02:00 Martin Peres :
> On 23/08/16 17:43, Emil Velikov wrote:
>>
>> On 23 August 2016 at 00:42, Martin Peres wrote:
>>>
>>> v2:
>>> - guard LED framework calls with ifdef CONFIG_L
On Wed, Aug 24, 2016 at 03:11:12PM +0300, Martin Peres wrote:
> On 23/08/16 17:43, Emil Velikov wrote:
> > On 23 August 2016 at 00:42, Martin Peres wrote:
> > > v2:
> > > - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
> > >
> > IIRC kernel has the tendency of using static inlines in t
On 23/08/16 17:43, Emil Velikov wrote:
On 23 August 2016 at 00:42, Martin Peres wrote:
v2:
- guard LED framework calls with ifdef CONFIG_LEDS_CLASS
IIRC kernel has the tendency of using static inlines in the headers
when CONFIG_foo is not set. Worth using that and removing the ifdef
from th
On 23 August 2016 at 00:42, Martin Peres wrote:
> v2:
> - guard LED framework calls with ifdef CONFIG_LEDS_CLASS
>
IIRC kernel has the tendency of using static inlines in the headers
when CONFIG_foo is not set. Worth using that and removing the ifdef
from the source file ?
-Emil
2016-08-23 16:06 GMT+02:00 Martin Peres :
> On 23/08/16 11:31, Karol Herbst wrote:
>>
>> maybe it makes sense to expose the SLI LED, too.
>>
>> Regardless of my comments this patch is reviewed-by me.
>
>
> You reviewed the wrong patch, I should have named the re-send v3.
>
> I accidentally sent the
On 23/08/16 11:31, Karol Herbst wrote:
maybe it makes sense to expose the SLI LED, too.
Regardless of my comments this patch is reviewed-by me.
You reviewed the wrong patch, I should have named the re-send v3.
I accidentally sent the v1 patch as a v2 :s
2016-08-23 1:39 GMT+02:00 Martin Per
v2:
- guard LED framework calls with ifdef CONFIG_LEDS_CLASS
Signed-off-by: Martin Peres
---
For real this time! Sorry for the noise
drm/nouveau/Kbuild | 1 +
drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 +
drm/nouveau/nouveau_drm.c | 7 ++
maybe it makes sense to expose the SLI LED, too.
Regardless of my comments this patch is reviewed-by me.
2016-08-23 1:39 GMT+02:00 Martin Peres :
> We received a donation of a Titan which has this useless feature
> allowing users to control the brightness of the LED behind the
> logo of NVIDIA. I