Re: Contributing to wix-maven-plugin

2012-01-05 Thread Brett Porter
Yep, that would be great. On 06/01/2012, at 2:35 AM, Adrián Boimvaser wrote: > Hi Brett, > > Thanks. I'd like to contribute some refactorings I made to AbstractWixMojo, > CandleMojo and LightMojo to remove some duplication. Should I file a JIRA > issue and attach a patch like I did with NPANDAY-

Re: Contributing to wix-maven-plugin

2012-01-05 Thread Adrián Boimvaser
Hi Brett, Thanks. I'd like to contribute some refactorings I made to AbstractWixMojo, CandleMojo and LightMojo to remove some duplication. Should I file a JIRA issue and attach a patch like I did with NPANDAY-510? Adrián 2012/1/5 Brett Porter > Hi Adrián, > > Sorry for the delay... I applied y

Re: Contributing to wix-maven-plugin

2012-01-05 Thread Brett Porter
Hi Adrián, Sorry for the delay... I applied your patch. Since it was helpful in my env., I made a few enhancements based on the comments in the issue (set a default from the environment, and dealt with spaces in the wixHome variable). Do those work for you? We'd be very happy if you're interes

Re: Contributing to wix-maven-plugin

2011-12-22 Thread Lars Corneliussen
Hi Adrián, I'm a little bit christmas-offline now. So Sit and wait can happen sometimes :) There is a way to become an NPanday developer, but it'll require a couple of good patches that drive the project in the right direction. It also usually takes some time until patches are available in a ne

Re: Contributing to wix-maven-plugin

2011-12-22 Thread Adrián Boimvaser
Hi Lars? What's next? Sit and wait? I made some refactorings and improvements to wix-maven plugin I would also like to contribute. Is there a way I can become a NPanday developer? Thanks. Adrián. 2011/12/21 Adrián Boimvaser > Thanks Lars, > > I created the issue and attached the patch. > > htt

Re: Contributing to wix-maven-plugin

2011-12-21 Thread Adrián Boimvaser
Thanks Lars, I created the issue and attached the patch. https://issues.apache.org/jira/browse/NPANDAY-510 Adrián. 2011/12/21 Lars Corneliussen > Hi Adrián, > > happy to hear that. > The best is, if you create an issue and attach the patch here: > > https://issues.apache.org/jira/secure/Creat

Re: Contributing to wix-maven-plugin

2011-12-21 Thread Lars Corneliussen
Hi Adrián, happy to hear that. The best is, if you create an issue and attach the patch here: https://issues.apache.org/jira/secure/CreateIssue.jspa?pid=12311182&issuetype=4&Create=Create Is that ok for you? _ Lars Am 21.12.2011 um 13:35 schrieb Adrián Boimvaser: > Hi, I'd like to make a contri

Contributing to wix-maven-plugin

2011-12-21 Thread Adrián Boimvaser
Hi, I'd like to make a contribution to wix-maven-plugin. Where should I send the patch? Thanks. Adrián Boimvaser