[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Andrew Nelson
On Mon, 9 Oct 2023 at 23:50, Matthew Brett wrote: > Hi, > > On Mon, Oct 9, 2023 at 11:49 AM Andrew Nelson wrote: > Could you say more about why you consider: > np.mean(x, dropna=True) > to be less clear in intent than: > np.nanmean(x) > ? Is it just that someone could accidentally forget that

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Oscar Benjamin
On Mon, 9 Oct 2023 at 23:12, Nathan wrote: > On Mon, Oct 9, 2023 at 3:58 PM Oscar Benjamin > wrote: >> >> On Mon, 9 Oct 2023 at 22:30, Nathan wrote: >> > >> > On Mon, Oct 9, 2023 at 3:12 PM Oscar Benjamin >> > wrote: >> >> >> >> I guess that makes it possible in some way to convert formats

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Nathan
On Mon, Oct 9, 2023 at 3:58 PM Oscar Benjamin wrote: > On Mon, 9 Oct 2023 at 22:30, Nathan wrote: > > > > On Mon, Oct 9, 2023 at 3:12 PM Oscar Benjamin < > oscar.j.benja...@gmail.com> wrote: > >> > >> On Mon, 9 Oct 2023 at 21:57, Nathan wrote: > >> > > >> > On Mon, Oct 9, 2023 at 2:44 PM Oscar

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Stephan Hoyer
On Mon, Oct 9, 2023 at 2:29 PM Nathan wrote: > However, one thing we can do now is, for that one particular symbol that > we know is going to be in every pickle file and probably never elsewhere, > is intercept that one import and instead of generating a generic warning > about np.core being

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Oscar Benjamin
On Mon, 9 Oct 2023 at 22:30, Nathan wrote: > > On Mon, Oct 9, 2023 at 3:12 PM Oscar Benjamin > wrote: >> >> On Mon, 9 Oct 2023 at 21:57, Nathan wrote: >> > >> > On Mon, Oct 9, 2023 at 2:44 PM Oscar Benjamin >> > wrote: >> >> Suppose that there is NumPy v1 and that in future there will be

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Nathan
On Mon, Oct 9, 2023 at 3:12 PM Oscar Benjamin wrote: > On Mon, 9 Oct 2023 at 21:57, Nathan wrote: > > > > On Mon, Oct 9, 2023 at 2:44 PM Oscar Benjamin < > oscar.j.benja...@gmail.com> wrote: > >> Suppose that there is NumPy v1 and that in future there will be NumPy > >> v2. Also suppose that

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Oscar Benjamin
On Mon, 9 Oct 2023 at 21:57, Nathan wrote: > > On Mon, Oct 9, 2023 at 2:44 PM Oscar Benjamin > wrote: >> Suppose that there is NumPy v1 and that in future there will be NumPy >> v2. Also suppose that there will be two NumPy pickle formats fmtA and >> a future fmtB. One possibility is that NumPy

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Nathan
On Mon, Oct 9, 2023 at 2:44 PM Oscar Benjamin wrote: > On Mon, 9 Oct 2023 at 17:03, Nathan wrote: > > > > On Mon, Oct 9, 2023 at 12:57 AM Aaron Meurer wrote: > >> > >> Is it possible to convert a NumPy 1 pickle file into a generic pickle > >> file that works in both NumPy 1 and 2? As far as I

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Oscar Benjamin
On Mon, 9 Oct 2023 at 17:03, Nathan wrote: > > On Mon, Oct 9, 2023 at 12:57 AM Aaron Meurer wrote: >> >> Is it possible to convert a NumPy 1 pickle file into a generic pickle >> file that works in both NumPy 1 and 2? As far as I understand, pickle >> is Turing complete, so I imagine it should be

[Numpy-discussion] *New Time* Next Documentation team meeting

2023-10-09 Thread Mukulika Pahari
Hi all, sorry for the late notice. Our next Documentation Team meeting will happen on *Monday, October 9* at *11PM UTC*. If this time slot is inconvenient for you to join, please let me know in the replies or Slack and we will try to add another time slot. All are welcome - you don't need to

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Nathan
On Mon, Oct 9, 2023 at 12:57 AM Aaron Meurer wrote: > Is it possible to convert a NumPy 1 pickle file into a generic pickle > file that works in both NumPy 1 and 2? As far as I understand, pickle > is Turing complete, so I imagine it should be theoretically possible, > but I don't know how easy

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Matthew Brett
Hi, On Mon, Oct 9, 2023 at 11:49 AM Andrew Nelson wrote: > > On Mon, 9 Oct 2023 at 20:34, wrote: >> >> Surely you can do this for all functions of eg.nan*. Why separate them is >> the only thing that distinguishes them. Setting the parameter seems to be >> more handy and user-friendly. Well

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Mateusz Sokol
Just to mention for visibility: Introducing a "nan" option and deprecating nan* functions was considered for 2.0 main namespace refactor but it was deemed large enough to be (hopefully) tackled in a separate story/project. https://github.com/numpy/numpy/issues/24306#issuecomment-1660073584 (first

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Andrew Nelson
On Mon, 9 Oct 2023 at 20:34, wrote: > Surely you can do this for all functions of eg.nan*. Why separate them is > the only thing that distinguishes them. Setting the parameter seems to be > more handy and user-friendly. Well for me it's seems better to do it right > away in NumPy 2.0 > I

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread norbertpiotraduckir
Surely you can do this for all functions of eg.nan*. Why separate them is the only thing that distinguishes them. Setting the parameter seems to be more handy and user-friendly. Well for me it's seems better to do it right away in NumPy 2.0 ___

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Matthew Brett
Hi, Is there any reason to have separate functions - or to keep enforcing that?I agree, an equivalent of R's rm.na argument seems like a very reasonable and useful addition, such as (sorry for the obviousness): np.mean(x, dropna=True) and so on, Cheers, Matthew On Mon, Oct 9, 2023 at

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Juan Nunez-Iglesias
On Mon, 9 Oct 2023, at 7:07 PM, Andrew Nelson wrote: > On Mon, 9 Oct 2023 at 16:36, Jerome Kieffer wrote: > I'd be ambivalent on making this change. THere are a whole host of other > `np.nan*` functions, would they all need to be modified as well? e.g. > nanprod, nansum, nanargmin, .. I

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Andrew Nelson
On Mon, 9 Oct 2023 at 16:36, Jerome Kieffer wrote: > On Fri, 06 Oct 2023 19:17:22 - > norbertpiotraduc...@gmail.com wrote: > > > Hi, > > I have an idea to change the numpy.percentile. Think numpy.percentile > and numpy.nanpercentyl are the same features, and the only difference is > that

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Ronald van Elburg
OK. Then we will just weight for 2.x and test then. ___ NumPy-Discussion mailing list -- numpy-discussion@python.org To unsubscribe send an email to numpy-discussion-le...@python.org https://mail.python.org/mailman3/lists/numpy-discussion.python.org/

[Numpy-discussion] Re: Adding NumpyUnpickler to Numpy 1.26 and future Numpy 2.0

2023-10-09 Thread Aaron Meurer
Is it possible to convert a NumPy 1 pickle file into a generic pickle file that works in both NumPy 1 and 2? As far as I understand, pickle is Turing complete, so I imagine it should be theoretically possible, but I don't know how easy it would be to actually do this or how it would affect the

[Numpy-discussion] Re: Change in numpy.percentile

2023-10-09 Thread Jerome Kieffer
On Fri, 06 Oct 2023 19:17:22 - norbertpiotraduc...@gmail.com wrote: > Hi, > I have an idea to change the numpy.percentile. Think numpy.percentile and > numpy.nanpercentyl are the same features, and the only difference is that > numpy.nanpercentyl doesn't include NaN values. Wouldn't it be