Re: [Numpy-discussion] Deprecate Promotion of numbers to strings?

2020-04-30 Thread Sebastian Berg
On Thu, 2020-04-30 at 18:47 +0100, Eric Wieser wrote: > > Another larger visible change will be code such as: > > > > np.concatenate([np.array(["string"]), np.array([2])]) > > > > will result in an error instead of returning a string array. (Users > > will have to cast manually here.) > > I

Re: [Numpy-discussion] Deprecate Promotion of numbers to strings?

2020-04-30 Thread Stephan Hoyer
On Thu, Apr 30, 2020 at 10:32 AM Sebastian Berg wrote: > Hi all, > > in https://github.com/numpy/numpy/pull/15925 I propose to deprecate > promotion of strings and numbers. I have to double check whether this > has a large effect on pandas, but it currently seems to me that it will > be

Re: [Numpy-discussion] Deprecate Promotion of numbers to strings?

2020-04-30 Thread Eric Wieser
> Another larger visible change will be code such as: > > np.concatenate([np.array(["string"]), np.array([2])]) > > will result in an error instead of returning a string array. (Users > will have to cast manually here.) I wonder if we can lessen the blow by allowing

[Numpy-discussion] Deprecate Promotion of numbers to strings?

2020-04-30 Thread Sebastian Berg
Hi all, in https://github.com/numpy/numpy/pull/15925 I propose to deprecate promotion of strings and numbers. I have to double check whether this has a large effect on pandas, but it currently seems to me that it will be reasonable. This means that `np.promote_types("S", "int8")`, etc. will lead