Re: [Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

2011-02-20 Thread Arjen de Korte
Citeren Michal Soltys sol...@ziu.info: the likely options are: - handle this at driver level - e.g. preserve the immutable flag if already set without setting rw (if necessary, e.g. in apcsmart if ignorelb is set), ignore polling, adjust the code so it works fine, etc. - go back to

Re: [Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

2011-01-26 Thread Arjen de Korte
Citeren rasengan rootish r...@relay.ppgk.com.pl: So basically what you have in mind is putting such checks in main.c's loop somewhere after upsdrv_updateinfo() call, and then updating ups.status ? Yes. That would also warrant adding options enabling such functionality (separately for

Re: [Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

2011-01-26 Thread Michal Soltys
On 11-01-26 16:36, Arjen de Korte wrote: Citeren Michal Soltys sol...@ziu.info: I think I found one bug with flag handling though: dstate_setflags() uses = when setting new flags. This has a side effect, that any later setflags() call will override earlier flags (as expected), but that also

Re: [Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

2011-01-26 Thread Michal Soltys
On 11-01-26 20:28, Arjen de Korte wrote: Citeren Michal Soltys sol...@ziu.info: The point is about override.* values, as they are implemented through immutable flag. If I added for example [apctest] override.battery.minutes.low = 0 or override.battery.minutes.low = -1 How is this supposed

Re: [Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

2011-01-25 Thread Arjen de Korte
Citeren Michal Soltys sol...@ziu.info: Summary: - new driver options: ignorelb, minbatt, mintime, wugrace, advorder - expanded: sdtype - few more types in compatibility table - minor fixes and adjustments First of all, thanks for the effort of working on this driver. The lack of an active