[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12364544 ]
Andrzej Bialecki commented on NUTCH-169:
-
This patch looks good! If there are no further objections, I'll test it and
commit it within the next 12 hours.
remove
Andrzej Bialecki (JIRA) wrote:
[ http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12364544 ]
Andrzej Bialecki commented on NUTCH-169:
-
This patch looks good! If there are no further objections, I'll test it and
commit it within
Well, it was at least the best way we had seen, since NutchConfigured
require to implement a constructor that in most cases was unused as
well, since most classes are instantiated class.newInstance().
So both solutions was optimal, and we decide for the interface solution.
I'm pretty sure
Sami Siren wrote:
Andrzej Bialecki (JIRA) wrote:
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12364544
]
Andrzej Bialecki commented on NUTCH-169:
-
This patch looks good! If there are no further objections, I'll test
it
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12363114 ]
Andrzej Bialecki commented on NUTCH-169:
-
I noticed only minor issues in this patch, here's the list (all line numbers
below refer to the line numbers in the patch
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12363116 ]
Stefan Groschupf commented on NUTCH-169:
Thanks, we will fix this in the beginning of next week.
remove static NutchConf
---
Key:
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12362438 ]
Andrzej Bialecki commented on NUTCH-169:
-
Overall, good work! I have some comments regarding the details:
* I wonder what is the performance impact of this patch - in
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12362447 ]
Stefan Groschupf commented on NUTCH-169:
I wonder what is the performance impact of this patch - in many places, where
previously we used the static methods on classes
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12362334 ]
Stefan Groschupf commented on NUTCH-169:
I missed to mentioned that is the first version just for discussing and provide
Jerome the changed API it is not the final
[
http://issues.apache.org/jira/browse/NUTCH-169?page=comments#action_12362393 ]
Stefan Groschupf commented on NUTCH-169:
Great! Thanks a lot Jerome!!! We will continue to fix some smaller bugs we
introduced and JobConf related issue and hopefully
10 matches
Mail list logo
