Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
I see two similar classes - org.apache.jackrabbit.oak.plugins.document.rdb.SynchronizedDocumentStoreWrapper - org.apache.jackrabbit.oak.plugins.document.util.SynchronizingDocumentStoreWrapper And these are not being used anywhere. Further I am not sure what purpose it would serve. Should they

jackrabbit-oak build #3895: Fixed

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3895 Status: Fixed Duration: 2674 seconds Commit: e2fdea48970ac1456d986a3486d3e9980e4d9f06 (trunk) Author: Marcel Reutegger Message: OAK-1626: RDBBlobStoreTest fails occasionally Disabled the test for now

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Julian Reschke
On 2014-03-27 09:54, Chetan Mehrotra wrote: I see two similar classes - org.apache.jackrabbit.oak.plugins.document.rdb.SynchronizedDocumentStoreWrapper - org.apache.jackrabbit.oak.plugins.document.util.SynchronizingDocumentStoreWrapper And these are not being used anywhere. Further I am not

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally for debugging. (it's similar to the Logging*Wrapper. Please do not remove. Okie but there already one preset in Util. Are they different? If not we should keep only one

RE: svn commit: r1581376 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/NodeStoreFixture.java

2014-03-27 Thread Marcel Reutegger
OK, now I got the OOME as well with my local in-memory H2 changes. it failed in ObservationRefreshTest. I analyzed the heap dump and it looks like the memory usage of this particular test is quite high because it uses orderable child nodes and adds child nodes one by one. I think that can be

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Thomas Mueller
Hi, I think proxies are a bit problematic. I would prefer the non-proxy version. Regards, Thomas On 27/03/14 10:41, Chetan Mehrotra chetan.mehro...@gmail.com wrote: On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Julian Reschke
On 2014-03-27 10:41, Chetan Mehrotra wrote: On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally for debugging. (it's similar to the Logging*Wrapper. Please do not remove. Okie but there already one preset in Util. Are

Re: svn commit: r1581376 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/NodeStoreFixture.java

2014-03-27 Thread Julian Reschke
On 2014-03-27 10:53, Marcel Reutegger wrote: OK, now I got the OOME as well with my local in-memory H2 changes. it failed in ObservationRefreshTest. I analyzed the heap dump and it looks like the memory usage of this particular test is quite high because it uses orderable child nodes and adds

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
On Thu, Mar 27, 2014 at 4:00 PM, Julian Reschke julian.resc...@gmx.de wrote: We can kill the one in rdb (I didn't see the other one when I added it). Would do Chetan Mehrotra

jackrabbit-oak build #3897: Fixed

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3897 Status: Fixed Duration: 2826 seconds Commit: 62a9e0ace988f42e73a0b2021505469fece2efe6 (trunk) Author: Marcel Reutegger Message: OAK-1627: Use non-orderable child nodes in ObservationRefreshTest git-svn-id:

jackrabbit-oak build #3900: Errored

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3900 Status: Errored Duration: 1079 seconds Commit: f43a1720c1fbe3ef91c925e821cc897a746bcb84 (trunk) Author: Julian Reschke Message: OAK-1544 - handle too wide keys more gracefully (see also OAK-1629)

AbstractBlobStoreTest

2014-03-27 Thread Julian Reschke
Hi there, I'd like to run the tests against a blob store that might not be empty, and thus rewrite the tests so that they do not assume to run on an empty store, and just to cleanup what they created. Please let me know ASAP if there's a reason not to... Best regards, Julian

Re: AbstractBlobStoreTest

2014-03-27 Thread Chetan Mehrotra
On Thu, Mar 27, 2014 at 10:08 PM, Julian Reschke julian.resc...@gmx.de wrote: if there's a reason not to It might effect test related to GC as GC logic would clean more than expected set of blobs Chetan Mehrotra

[DocumentNodeStore] Clarify behaviour for Commit.getModified

2014-03-27 Thread Chetan Mehrotra
Hi, Currently Commit.getModified has following impl - public static long getModified(long timestamp) { // 5 second resolution return timestamp / 1000 / 5; } - The result when treated as timestamp cause the time to set to 0 i.e. 1970 I intend to fix this with (looking

jackrabbit-oak build #3906: Fixed

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3906 Status: Fixed Duration: 2681 seconds Commit: 07e1737953eb1c84680efb923adbaf998196bd9f (trunk) Author: Julian Reschke Message: fix svn:eol-style git-svn-id:

jackrabbit-oak build #3907: Fixed

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3907 Status: Fixed Duration: 2912 seconds Commit: d4c79f39b6dbcb46b5f8cc41a2b664ab633edbeb (trunk) Author: Chetan Mehrotra Message: OAK-1341 - DocumentNodeStore: Implement revision garbage collection (WIP)

jackrabbit-oak build #3914: Passed

2014-03-27 Thread Travis CI
Build Update for apache/jackrabbit-oak - Build: #3914 Status: Passed Duration: 2799 seconds Commit: 6d8146f847e04e5172defb11c1d3d3bdf008c774 (trunk) Author: Jukka Zitting Message: OAK-1624: Item names with trailing spaces should not be allowed Prevent names