Re: CachingFileDataStore vs DataStoreBlobStore

2020-02-24 Thread Amit Jain
Hi, Yes you should be using OakFileDataStore. You should be able to just instantiate with this. Thanks Amit On Tue, Feb 25, 2020 at 12:04 PM Marco Piovesana wrote: > Hi Amit, thanks for the clarification. Right now I'm using Oak with the > FileDataStore wrapped into a DataStoreBlobStore.

Re: CachingFileDataStore vs DataStoreBlobStore

2020-02-24 Thread Marco Piovesana
Hi Amit, thanks for the clarification. Right now I'm using Oak with the FileDataStore wrapped into a DataStoreBlobStore. Should I change it to OakFileDataStore then? If yes, do I have to do an upgrade for that or I just need to instantiate my storage with the new class? Marco. On Tue, Feb 25,

Re: CachingFileDataStore vs DataStoreBlobStore

2020-02-24 Thread Amit Jain
Hi, OakFileDataStore is an extension of the JR2 FileDataStore and implements required methods to work in Oak to support DSGC etc. So, in Oak OakFileDataStore should only be used. Thanks Amit On Tue, Feb 25, 2020 at 6:01 AM Marco Piovesana wrote: > Hi guys, > what's the difference between the

Re: CachingFileDataStore vs DataStoreBlobStore

2020-02-24 Thread Marco Piovesana
Hi guys, what's the difference between the FileDataStore and the OakFileDataStore? I've seen that the one is an extension of the other and it implements the SharedDataStore interface, but I did not found other documentation on it. Is it just the oak implementation of the same storage? Or there are

Re: Versionable node deletion

2020-02-24 Thread jorgeeflorez .
Hi Marco, I agree, it is related to OAK-8048. > But since it > isn't, there is still one node that references the binary, so (the binary) > is not removed when running the garbage collector. > > I am not sure about this. I just printed the rootVersion node and it has nothing related to the node

Re: Versionable node deletion

2020-02-24 Thread Marco Piovesana
Hi Jorge, I'm not an expert, but I think it might be related to OAK-804 . The root version should be automatically removed when removing the last version. But since it isn't, there is still one node that references the binary, so (the binary) is not

Re: Versionable node deletion

2020-02-24 Thread jorgeeflorez .
Hi, I managed to delete all versions for nodes that no longer exist (except the jcr:rootVersion nodes, they are "protected"). I was expecting that the total size of my binary storage would decrease (I am using OakFileDataStore), since some files are no longer referenced in any nodes. But that did

Re: CachingFileDataStore vs DataStoreBlobStore

2020-02-24 Thread Amit Jain
Hi, CachingFileDataStore is only a sort of wrapper to cache files locally (and upload async) when the actual backend is some sort of NFS and is slow for the parameters you care about. OakFileDataStore is what'll work for your purpose if you don't care about local caching. >> it feels like this