Re: svn commit: r1806894 - /jackrabbit/oak/trunk/oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/S3DataStoreFactory.java

Yes +1 for backporting. Thanks Amit On Fri, Sep 1, 2017 at 2:15 PM, Tomek Rekawek wrote: > Hi Amit, > > thanks for noticing this. I’ve used the native S3DataStore#close() method. > Also, I think it’s a good backport candidate (there were customers > complaining on

Re: svn commit: r1806894 - /jackrabbit/oak/trunk/oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/S3DataStoreFactory.java

Just saw that you already did that. Thanks Amit On Fri, Sep 1, 2017 at 1:46 PM, Amit Jain wrote: > Hi Tomek, > > The {{asCloseable}} should also be changed to not take in the > CachingDataStore but either the AbstractSharedCachingDataStore or > S3DataStore instead and

Re: svn commit: r1806894 - /jackrabbit/oak/trunk/oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/cli/blob/S3DataStoreFactory.java

Hi Tomek, The {{asCloseable}} should also be changed to not take in the CachingDataStore but either the AbstractSharedCachingDataStore or S3DataStore instead and subsequently the import for CachingDataStore also removed. Thanks Amit On Fri, Sep 1, 2017 at 1:00 PM, wrote: >