Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
I see two similar classes - org.apache.jackrabbit.oak.plugins.document.rdb.SynchronizedDocumentStoreWrapper - org.apache.jackrabbit.oak.plugins.document.util.SynchronizingDocumentStoreWrapper And these are not being used anywhere. Further I am not sure what purpose it would serve. Should they

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Julian Reschke
On 2014-03-27 09:54, Chetan Mehrotra wrote: I see two similar classes - org.apache.jackrabbit.oak.plugins.document.rdb.SynchronizedDocumentStoreWrapper - org.apache.jackrabbit.oak.plugins.document.util.SynchronizingDocumentStoreWrapper And these are not being used anywhere. Further I am not

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally for debugging. (it's similar to the Logging*Wrapper. Please do not remove. Okie but there already one preset in Util. Are they different? If not we should keep only one

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Thomas Mueller
Hi, I think proxies are a bit problematic. I would prefer the non-proxy version. Regards, Thomas On 27/03/14 10:41, Chetan Mehrotra chetan.mehro...@gmail.com wrote: On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Julian Reschke
On 2014-03-27 10:41, Chetan Mehrotra wrote: On Thu, Mar 27, 2014 at 2:30 PM, Julian Reschke julian.resc...@gmx.de wrote: I created the first one, and use it occasionally for debugging. (it's similar to the Logging*Wrapper. Please do not remove. Okie but there already one preset in Util. Are

Re: Remove SynchronizedDocumentStoreWrapper

2014-03-27 Thread Chetan Mehrotra
On Thu, Mar 27, 2014 at 4:00 PM, Julian Reschke julian.resc...@gmx.de wrote: We can kill the one in rdb (I didn't see the other one when I added it). Would do Chetan Mehrotra