Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-04-02 Thread Jukka Zitting
Hi, On Tue, Apr 1, 2014 at 9:29 AM, Michael Dürig mdue...@apache.org wrote: 3rd try: http://svn.apache.org/r1583661 Looks good, thanks! On Mon, Mar 31, 2014 at 11:56 PM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: +1. I also missed getting a clean way to get blobId from Blob. So adding

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-04-02 Thread Chetan Mehrotra
On Wed, Apr 2, 2014 at 12:18 PM, Jukka Zitting jukka.zitt...@gmail.com wrote: The getContentIdentity() method has a specific contract and the return value should generally not be interpreted as a referenceable identifier. Ack. If you need a method that exposes the blobId, it would be best to

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-04-01 Thread Michael Dürig
3rd try: http://svn.apache.org/r1583661 Michael On 1 April 2014 05:56, Chetan Mehrotra chetan.mehro...@gmail.com wrote: +1. I also missed getting a clean way to get blobId from Blob. So adding this method would be useful in other cases also Chetan Mehrotra On Tue, Apr 1, 2014 at 8:05 AM,

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-03-31 Thread Jukka Zitting
Hi, On Mon, Mar 31, 2014 at 6:14 AM, mdue...@apache.org wrote: +@Override +public String getContentIdentity() { +return getBlob().getReference(); +} This is a bit troublesome, as the getContentIdentity() contract requires that Once an identifier is available, it will

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-03-31 Thread Michael Dürig
2nd try: http://svn.apache.org/r1583413 Michael On 31 March 2014 17:35, Jukka Zitting jukka.zitt...@gmail.com wrote: Hi, On Mon, Mar 31, 2014 at 6:14 AM, mdue...@apache.org wrote: +@Override +public String getContentIdentity() { +return getBlob().getReference(); +}

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-03-31 Thread Jukka Zitting
Hi, On Mon, Mar 31, 2014 at 3:25 PM, Michael Dürig mdue...@apache.org wrote: 2nd try: http://svn.apache.org/r1583413 That's more correct, but has horrible performance with any implementation (including BlobStoreBlob and SegmentBlob) that doesn't precompute the hash. As mentioned earlier, a

Re: svn commit: r1583285 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/value/ValueImpl.java

2014-03-31 Thread Chetan Mehrotra
+1. I also missed getting a clean way to get blobId from Blob. So adding this method would be useful in other cases also Chetan Mehrotra On Tue, Apr 1, 2014 at 8:05 AM, Jukka Zitting jukka.zitt...@gmail.com wrote: Hi, On Mon, Mar 31, 2014 at 3:25 PM, Michael Dürig mdue...@apache.org wrote: