hi francesco
i disagree with your statement below. having tests even for trivial
changes just limits the risk of regressions now and for any later
modifications... hoping for others having covered your code with
some test, is IMO not good enough :-)
so, please add some tests or verify that it's a
I don't think that in this case a test is necessary, given the
triviality of the change. Type is used by almost the whole stack, and
the fixes are about the comparison between types. If I introduced a
regression, it should have been caught by at least one test
(hopefully).
2015-10-23 12:08 GMT+02:
On Fri, Oct 23, 2015 at 3:15 PM, wrote:
> public final class Type implements Comparable> {
>
> -private static final Map> TYPES = newHashMap();
> +private static final Map> TYPES = new HashMap Type>();
>
> private static Type create(int tag, boolean array, String string)
> {
>
