Hello I would appreciate a review of PR #665 [0], which fixes OAK-9897 [1].
When running GC on a SegmentStore setup with SplitPersistence, it happens regularly that the tar archives of the "read-only" part of the persistence are identified for removal during the "cleanup" phase. However, these can never be deleted (read-only), which leads to the FileReaper thread to retry over and over again to delete them. I noticed the issue while writing tests, but I am sure this happens only in production systems. The impact AFAICS is limited to some warning logs and excess resource-usage. To address the issue I introduced an API change. Namely I added the method "SegmentArchiveManager#isReadOnly(String archiveName)" with a default implementation returning "false". This allows for exclusion of read-only archives from the cleanup process (both the "mark" and the "sweep" phases). Thank you for your comments. Regards Julian [0] https://github.com/apache/jackrabbit-oak/pull/665 [1] https://issues.apache.org/jira/browse/OAK-9897
