+1, the patch looks good to me.
Tommaso
Il giorno mer 19 set 2018 alle ore 22:33 Matt Ryan ha scritto:
>
> Hi oak-dev,
>
> I’ve just created OAK-7769 in which I would like us to consider backporting
> the similarity search feature that Tommaso implemented in OAK-7575 to Oak
> 1.8. There is a patch file included in the issue which applies cleanly to
> 1.8 and all unit tests pass. It includes unit tests written for OAK-7575.
> The change is almost all additive, meaning there is little existing
> functionality in 1.8 that is being modified.
>
> Tommaso has viewed the patch; IIUC he feels comfortable with it but I will
> allow him to speak for himself and comment further one way or the other.
>
>
> -MR
