Re: svn commit: r1798453 - in /jackrabbit/oak/trunk: oak-api/src/main/java/org/apache/jackrabbit/oak/api/jmx/package-info.java oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/pac
Opened OAK-6337 to track this. In the meantime, re-added the method with deprecation flag and reverted version bump. Thanks, Vikas
Re: svn commit: r1798453 - in /jackrabbit/oak/trunk: oak-api/src/main/java/org/apache/jackrabbit/oak/api/jmx/package-info.java oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/pac
> 1. Deprecate the method instead of removing it > The added method was part of 1.7.1 and is gone by 1.7.2. Deprecating seems overkill to me from that pov. > 2. Or better specify comparisonVersion to 1.6 via [1] > I like this idea ... although, it probably adds complexity while branching new version (whenever we'd have 1.9.*... someone would have to remember to bump base version to 1.8) > [1] > http://felix.apache.org/components/bundle-plugin/baseline-mojo.html#comparisonVersion That said, is it fair to expect clients bumping to major version of oak AND depend on o.a.j.o.api.jmx AND not have compile their own bundles against the upgraded version? Thanks, Vikas
Re: svn commit: r1798453 - in /jackrabbit/oak/trunk: oak-api/src/main/java/org/apache/jackrabbit/oak/api/jmx/package-info.java oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/pac
On Mon, Jun 12, 2017 at 6:13 PM, wrote:
> -@Version("4.6.0")
> +@Version("5.0.0")
> @Export(optional = "provide:=true")
> package org.apache.jackrabbit.oak.api.jmx;
This would cause potential issue for the clients as this package is
meant to be used by user of Oak as an API. I know that newly removed
method is not yet part of stable release but then we had a unstable
release with new method. I see 2 options
1. Deprecate the method instead of removing it
2. Or better specify comparisonVersion to 1.6 via [1]
Chetan Mehrotra
[1]
http://felix.apache.org/components/bundle-plugin/baseline-mojo.html#comparisonVersion
