Re: Feedback on S3DataStore JMX stats patch (OAK-4712)

Thanks Matt!! I will take a look tomorrow. Regards Amit On Thu, Sep 8, 2016 at 8:53 PM, Matt Ryan wrote: > New patch attached to address feedback in OAK-4712 on the last patch. > > On Thu, Sep 1, 2016 at 11:00 AM, Matt Ryan wrote: > >> This patch I believe

Re: Feedback on S3DataStore JMX stats patch (OAK-4712)

New patch attached to address feedback in OAK-4712 on the last patch. On Thu, Sep 1, 2016 at 11:00 AM, Matt Ryan wrote: > This patch I believe addresses the issues identified with the previous > patch. I've also uploaded it to OAK-4712. > > Looking for review and feedback. > >

Re: Feedback on S3DataStore JMX stats patch (OAK-4712)

This patch I believe addresses the issues identified with the previous patch. I've also uploaded it to OAK-4712. Looking for review and feedback. This patch introduces a new interface I've named NodeIdMapper.java. Not sure where to put this. I've added it in order to be able to obtain the

Re: Feedback on S3DataStore JMX stats patch (OAK-4712)

Hi Matt, I have directly replied to your comments on the jira. Thanks Amit On Sat, Aug 27, 2016 at 4:22 AM, Matt Ryan wrote: > Use this patch instead; updated patch from latest in trunk. > > On Fri, Aug 26, 2016 at 4:41 PM, Matt Ryan wrote: > >> Hi Oak Devs,

Re: Feedback on S3DataStore JMX stats patch (OAK-4712)

Use this patch instead; updated patch from latest in trunk. On Fri, Aug 26, 2016 at 4:41 PM, Matt Ryan wrote: > Hi Oak Devs, > > I've created OAK-4712 and submitted a patch for the same. I've attached > the same patch to this email. > > The submission is to add a new MBean,

Feedback on S3DataStore JMX stats patch (OAK-4712)

Hi Oak Devs, I've created OAK-4712 and submitted a patch for the same. I've attached the same patch to this email. The submission is to add a new MBean, S3DataStoreStats, which will allow reporting via JMX about the state of the S3DataStore. Two metrics are intended. The first is to report