Re: ContentSession.getCurrentRoot() is slow

2012-09-14 Thread Thomas Mueller
Hi, What about renaming ContentSession.getCurrentRoot() to getHeadRoot() or getCurrentHeadRoot()? About workspaces - I know we said we don't support workspaces currently, but there still is ContentSession.getWorkspaceName(). Could we remove this method for now? The problem is that it's not clear

Re: ContentSession.getCurrentRoot() is slow

2012-09-14 Thread Jukka Zitting
Hi, On Fri, Sep 14, 2012 at 7:32 AM, Thomas Mueller muel...@adobe.com wrote: This is actually what I expected that ContentSession.getCurrentRoot() would provide me: I expected getCurrentRoot() would always return the same root until the session has committed or refreshed. It wasn't obvious to

Re: ContentSession.getCurrentRoot() is slow

2012-09-14 Thread Jukka Zitting
Hi, On Fri, Sep 14, 2012 at 9:47 AM, Thomas Mueller muel...@adobe.com wrote: About workspaces - I know we said we don't support workspaces currently, but there still is ContentSession.getWorkspaceName(). Could we remove this method for now? The problem is that it's not clear whether

Re: ContentSession.getCurrentRoot() is slow

2012-09-14 Thread Thomas Mueller
Hi, About workspaces - I know we said we don't support workspaces currently, but there still is ContentSession.getWorkspaceName(). Could we remove this method for now? Currently the workspace root and the repository root are the same thing, while we only support a single workspace. Once we get

Re: ContentSession.getCurrentRoot() is slow

2012-09-14 Thread Michael Dürig
Hi, On 14.9.12 9:52, Thomas Mueller wrote: Hi, About workspaces - I know we said we don't support workspaces currently, but there still is ContentSession.getWorkspaceName(). Could we remove this method for now? Currently the workspace root and the repository root are the same thing, while

Re: ContentSession.getCurrentRoot() is slow

2012-09-13 Thread Michael Dürig
On 13.9.12 16:42, Thomas Mueller wrote: Hi, To read a node, the query engine currently uses: session.getCurrentRoot().getTree(path); The query engine calls this whenever it has to evaluate a property. It turns out internally the getCurrentRoot() method always calls

Re: ContentSession.getCurrentRoot() is slow

2012-09-13 Thread Jukka Zitting
Hi, On Thu, Sep 13, 2012 at 5:42 PM, Thomas Mueller muel...@adobe.com wrote: Should I cache the Root instance in the query engine for the duration of a query? Or would it be possible to change the Root implementation so this is not needed? It would be better if the query engine used the same

Re: ContentSession.getCurrentRoot() is slow

2012-09-13 Thread Thomas Mueller
Hi, It would be better if the query engine used the same tree snapshot as the rest of the session. There shouldn't be any need to call getCurrentRoot(). This is actually what I expected that ContentSession.getCurrentRoot() would provide me: I expected getCurrentRoot() would always return the