Re: guava ByteStreams.equal()

2016-12-02 Thread Torgeir Veimo
Ok, filed https://issues.apache.org/jira/browse/OAK-5215 with a patch. It makes it possible to run with guava up to version 19.0. There are a few additional changes required to run with version 20.0. On 1 December 2016 at 23:58, Alex Parvulescu wrote: > Hi, > > It's

Re: guava ByteStreams.equal()

2016-12-01 Thread Alex Parvulescu
Hi, It's not a bad idea, I see we use this method only in 2 places [0] and [1], and this change would not even need to have the guava version updated on oak as far as I see it. It would be good if you could create an issue and attach a patch for review. best, alex [0]

guava ByteStreams.equal()

2016-12-01 Thread Torgeir Veimo
The method ByteStreams.equal(InputSupplier, InputSupplier) is deprecated in guava 17 and removed in guava 18. Would it be an idea to replace the call to it by using the ByteSource.contentEquals(ByteSource) as suggested in guava 17? This would make it easier to deploy in a non-ogsi environment