[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528895#comment-13528895
]
Thomas Mueller commented on OAK-355:
rootState and rootTree: makes sense, I will do that.
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528834#comment-13528834
]
Michael Dürig commented on OAK-355:
---
bq. Also, what I don't like, is that QueryEngineImpl h
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528829#comment-13528829
]
Thomas Mueller commented on OAK-355:
Looking at it again, I think there is even more to r
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528820#comment-13528820
]
Jukka Zitting commented on OAK-355:
---
> I'm also in favor of renaming it. E.g. from SessionQ
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528812#comment-13528812
]
Marcel Reutegger commented on OAK-355:
--
The only thing left is the name of the class. I'
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527991#comment-13527991
]
Thomas Mueller commented on OAK-355:
To me it looks like this issue is resolve.
Marcel,
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488692#comment-13488692
]
Jukka Zitting commented on OAK-355:
---
bq. Jukka, are you still working on this? Otherwise I
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488686#comment-13488686
]
Marcel Reutegger commented on OAK-355:
--
Removed Root param from SessionQueryEngine.execu
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488661#comment-13488661
]
Marcel Reutegger commented on OAK-355:
--
Jukka, are you still working on this? Otherwise
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484139#comment-13484139
]
Thomas Mueller commented on OAK-355:
> we wanted to get rid of having to pass the Root in
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484115#comment-13484115
]
Jukka Zitting commented on OAK-355:
---
bq. the reason why this was changed
To give more back
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484083#comment-13484083
]
Thomas Mueller commented on OAK-355:
> doesn't explain why the QueryEngine needs a sessio
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483158#comment-13483158
]
Alex Parvulescu commented on OAK-355:
-
> Alex, could you quickly tell me what was the rea
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478968#comment-13478968
]
Thomas Mueller commented on OAK-355:
Related to OAK-241
> Move QueryEngi
[
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478890#comment-13478890
]
Thomas Mueller commented on OAK-355:
Alex, could you quickly tell me what was the reason
15 matches
Mail list logo
