[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748702#comment-15748702 ] Michael Dürig commented on OAK-5293: [~frm], [~dulceanu], please have a look of my last couple of

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748696#comment-15748696 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774280=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748688#comment-15748688 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774278=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748689#comment-15748689 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774278=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748678#comment-15748678 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774277=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748664#comment-15748664 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774275=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748656#comment-15748656 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774273=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748652#comment-15748652 ] Michael Dürig commented on OAK-5293: At http://svn.apache.org/viewvc?rev=1774272=rev I fixed a potential

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748629#comment-15748629 ] Michael Dürig commented on OAK-5293: While going through the warnings of possible {{null}} dereferences,

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748337#comment-15748337 ] Michael Dürig commented on OAK-5293: I will follow up with a couple of more findings re. null

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748335#comment-15748335 ] Michael Dürig commented on OAK-5293: Committed an initial set of findings. I added the IntelliJ

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747987#comment-15747987 ] Andrei Dulceanu commented on OAK-5293: -- [~mduerig], it looks good to me. > Static code analysis and

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745519#comment-15745519 ] Andrei Dulceanu commented on OAK-5293: -- [~mduerig] Didn't have time to look over the patch yet. I will

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745141#comment-15745141 ] Francesco Mari commented on OAK-5293: - It would be nice if we could agree on a shared IDE configuration

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745066#comment-15745066 ] Michael Dürig commented on OAK-5293: I used the IntelliJ's built in inspections for these. > Static

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745050#comment-15745050 ] Francesco Mari commented on OAK-5293: - It looks good to me. How did you catch those? Did you use any

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744892#comment-15744892 ] Michael Dürig commented on OAK-5293: Proposed changes:

[jira] [Commented] (OAK-5293) Static code analysis and code cleanup

[ https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744807#comment-15744807 ] Michael Dürig commented on OAK-5293: I think now is a good time to do this as currently we don't have to