[jira] [Commented] (OAK-4517) sub-rooted index definition not respecting the includedPaths
[
https://issues.apache.org/jira/browse/OAK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353369#comment-15353369
]
Ravi Kiran Papani commented on OAK-4517:
During the discussion with [~catholicon], it looks like sub rooted index
definition isn't respecting the absolute includedPaths. we've tried to modify
the includedPaths to use relative to the index definition as
{code:xml}
includedPaths="[/blog,/support]"
{code}
Then it worked.
cc: [~catholicon], [~chetanm]
> sub-rooted index definition not respecting the includedPaths
>
>
> Key: OAK-4517
> URL: https://issues.apache.org/jira/browse/OAK-4517
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.2.14
>Reporter: Ravi Kiran Papani
>
> I've created an sub-rooted index definition at /content/geometrixx/en as
> follows
> {code:xml}
>
> jcr:primaryType="oak:QueryIndexDefinition"
> async="async"
> compatVersion="{Long}2"
>
> includedPaths="[/content/geometrixx/en/blog,/content/geometrixx/en/support]"
> indexPath="/content/geometrixx/en/oak:index/cqPageLucene"
> name="cq:Page"
> reindex="{Boolean}false"
> reindexCount="{Long}2"
> type="lucene">
>
>
> jcr:primaryType="nt:unstructured"
> path="jcr:content"
> relativeNode="{Boolean}true"/>
>
>
> jcr:primaryType="nt:unstructured"
> path="jcr:content"
> relativeNode="{Boolean}false"/>
>
>
> jcr:primaryType="nt:unstructured"
> path="*"
> relativeNode="{Boolean}false"/>
> jcr:primaryType="nt:unstructured"
> path="*/*"
> relativeNode="{Boolean}false"/>
> jcr:primaryType="nt:unstructured"
> path="*/*/*"
> relativeNode="{Boolean}false"/>
> jcr:primaryType="nt:unstructured"
> path="*/*/*/*"
> relativeNode="{Boolean}false"/>
>
>
>
>
>
> jcr:primaryType="nt:unstructured"
> name="jcr:content/cq:lastModified"
> ordered="{Boolean}true"
> propertyIndex="{Boolean}true"
> type="Date"/>
> jcr:primaryType="nt:unstructured"
> analyzed="{Boolean}true"
> name="jcr:content/jcr:title"
> ordered="{Boolean}false"
> propertyIndex="{Boolean}true"
> type="String"
> useInSuggest="{Boolean}true"/>
>
>
>
>
>
> {code}
> when I'm trying to execute the query
> "/jcr:root/content/geometrixx/en/blog//element(*,
> cq:Page)[rep:suggest('le')]/(rep:suggest())" , It's using the correct
> definition but the results are not coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OAK-4517) sub-rooted index definition not respecting the includedPaths
Ravi Kiran Papani created OAK-4517:
--
Summary: sub-rooted index definition not respecting the
includedPaths
Key: OAK-4517
URL: https://issues.apache.org/jira/browse/OAK-4517
Project: Jackrabbit Oak
Issue Type: Bug
Components: lucene
Affects Versions: 1.2.14
Reporter: Ravi Kiran Papani
I've created an sub-rooted index definition at /content/geometrixx/en as follows
{code:xml}
{code}
when I'm trying to execute the query
"/jcr:root/content/geometrixx/en/blog//element(*,
cq:Page)[rep:suggest('le')]/(rep:suggest())" , It's using the correct
definition but the results are not coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-3403) Multiplexing store support in Property indexes
[
https://issues.apache.org/jira/browse/OAK-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra updated OAK-3403:
-
Attachment: OAK-3403-v1.patch
[current patch|^OAK-3403-v1.patch] for the same
[~tmueller] [~alex.parvulescu] Can you review the patch and provide the feedback
> Multiplexing store support in Property indexes
> --
>
> Key: OAK-3403
> URL: https://issues.apache.org/jira/browse/OAK-3403
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: query
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Attachments: OAK-3403-v1.patch
>
>
> In Oak one can define an index anywhere in the repository under a special
> node name {{oak:index}}. For e.g. if you want a property index for
> {{sling:resourceType}} at root level then you can create the index at
> /oak:index/resourceType and this index would store the index content at
> /oak:index/resourceType/:index.
> # Writing - At time of commit the IndexEditor would need to decide where the
> indexed content for a given path should be stored. To start with it can make
> use of PathToStoreMapper to decide which node to use the indexed content. For
> e.g. for /libs the indexed content is stored under :index-pr and for /content
> :index-sr is used. This is simpler for PropertyIndex where IndexStoreStrategy
> can be passed the right node
> # Reading - At time of reading the QueryIndex implementation would need to
> provide a union cursor which can perform lookup from all such store
> directories for a given index.
> *Open Items*
> # Supporting unique indexes
> # Introducing new oak:index - Node under oak:index node are special.
> Depending on parent path it might be possible that they would have to be
> created in both repositories. For e.g. /oak:index would have to be present in
> both PR and SR. While /content/foo/oak:index can live only in SR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352916#comment-15352916 ] Julian Reschke edited comment on OAK-4494 at 6/28/16 3:55 PM: -- Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750512 http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750537 http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750542 http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 was (Author: reschke): Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750512 http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750537 http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Labels: (was: candidate_oak_1_0) > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Fix Version/s: 1.0.32 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-4494. - Resolution: Fixed > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352916#comment-15352916 ] Julian Reschke edited comment on OAK-4494 at 6/28/16 3:22 PM: -- Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750512 http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750537 http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 was (Author: reschke): Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750512 http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0 > Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Fix Version/s: 1.2.17 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0 > Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Labels: candidate_oak_1_0 (was: candidate_oak_1_0 candidate_oak_1_2) > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0 > Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4503) Update count increases with rebase
[
https://issues.apache.org/jira/browse/OAK-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-4503:
--
Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 (was: )
> Update count increases with rebase
> --
>
> Key: OAK-4503
> URL: https://issues.apache.org/jira/browse/OAK-4503
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, documentmk
>Affects Versions: 1.0, 1.2, 1.4
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.6, 1.5.5
>
>
> The update count in {{DocumentRootBuilder}} increases with the number of
> changes in memory when {{rebase()}} is called. The update count should stay
> the same because a rebase does not affect the number of in-memory changes.
> This may lead to premature creation of a branch when pending changes are
> rebased too often. E.g. when Node.isLocked() is called frequently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352916#comment-15352916 ] Julian Reschke edited comment on OAK-4494 at 6/28/16 2:03 PM: -- Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750512 http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 was (Author: reschke): Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.6, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3404) Path to logical store mapping
[
https://issues.apache.org/jira/browse/OAK-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353012#comment-15353012
]
Chetan Mehrotra commented on OAK-3404:
--
[patch|^OAK-3404-v1.patch] for new SPI interface
[MountInfoProvider|https://github.com/rombert/jackrabbit-oak/blob/features/docstore-multiplex/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/mount/MountInfoProvider.java]
and related implementation
> Path to logical store mapping
> -
>
> Key: OAK-3404
> URL: https://issues.apache.org/jira/browse/OAK-3404
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: core
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Attachments: OAK-3404-v1.patch
>
>
> Need to provide an API {{MountInfoProvider}} which would be responsible for
> mapping a given path to logical store name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Labels: candidate_oak_1_0 candidate_oak_1_2 (was: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4) > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.6, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Fix Version/s: 1.4.5 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.6, 1.5.5, 1.4.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-3404) Path to logical store mapping
[
https://issues.apache.org/jira/browse/OAK-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra updated OAK-3404:
-
Attachment: OAK-3404-v1.patch
> Path to logical store mapping
> -
>
> Key: OAK-3404
> URL: https://issues.apache.org/jira/browse/OAK-3404
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: core
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Attachments: OAK-3404-v1.patch
>
>
> Need to provide an API {{MountInfoProvider}} which would be responsible for
> mapping a given path to logical store name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4516) Configurable option to lucene index defs to index original (unanalyzed value as well)
[
https://issues.apache.org/jira/browse/OAK-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352948#comment-15352948
]
Vikas Saurabh commented on OAK-4516:
One of the possible solution could be to utilize
[WordDelimiterFilter.html#PRESERVE_ORIGINAL|https://lucene.apache.org/core/4_4_0/analyzers-common/org/apache/lucene/analysis/miscellaneous/WordDelimiterFilter.html#PRESERVE_ORIGINAL]
feature in default {{OakAnalyzer}}.
This has an obvious downside that it'd increase index size. So, we would
probably want to keep this configurable.
/cc [~chetanm]
> Configurable option to lucene index defs to index original (unanalyzed value
> as well)
> -
>
> Key: OAK-4516
> URL: https://issues.apache.org/jira/browse/OAK-4516
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
>
> It's sometimes useful to have original value being indexed to be stored as a
> term. One use-case could be like:
> * consider a couple of values to be indexed as {{abc_def}}, {{abcdef}}
> * On query, it seems reasonable to get both values for a query for {{abc*}}
> Currently, the values would get indexed like:
> * {{abc_def}} -> {{\[abc], \[def]}}
> * {{abcdef}} -> {{\[abcdef]}}
> So, the query {{abc*}} would only fetch {{abcdef}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OAK-4516) Configurable option to lucene index defs to index original (unanalyzed value as well)
Vikas Saurabh created OAK-4516:
--
Summary: Configurable option to lucene index defs to index
original (unanalyzed value as well)
Key: OAK-4516
URL: https://issues.apache.org/jira/browse/OAK-4516
Project: Jackrabbit Oak
Issue Type: Improvement
Components: lucene
Reporter: Vikas Saurabh
Assignee: Vikas Saurabh
Priority: Minor
It's sometimes useful to have original value being indexed to be stored as a
term. One use-case could be like:
* consider a couple of values to be indexed as {{abc_def}}, {{abcdef}}
* On query, it seems reasonable to get both values for a query for {{abc*}}
Currently, the values would get indexed like:
* {{abc_def}} -> {{\[abc], \[def]}}
* {{abcdef}} -> {{\[abcdef]}}
So, the query {{abc*}} would only fetch {{abcdef}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Attachment: OAK-4494-RDB-1.4.diff proposed RDB patch for 1.4 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.6, 1.5.5 > > Attachments: OAK-4494-RDB-1.4.diff, OAK-4494-RDB.diff, > OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-2819) Persistent cache: tool to dump the contents
[ https://issues.apache.org/jira/browse/OAK-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352927#comment-15352927 ] Vikas Saurabh commented on OAK-2819: [~tmueller], may be we can make this a part of oak-run. Of course, we can add/remove features later on as use-cases turn up. This has been very useful for some of the investigations I had done recently to peek into what the cache contained. > Persistent cache: tool to dump the contents > --- > > Key: OAK-2819 > URL: https://issues.apache.org/jira/browse/OAK-2819 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: DumpCache.java > > > To analyze a system, it would be good to have a tool that can dump (a portion > of) the persistent cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352916#comment-15352916 ] Julian Reschke commented on OAK-4494: - Aggregated changes: trunk: http://svn.apache.org/r1750495 http://svn.apache.org/r1750287 http://svn.apache.org/r1749875 http://svn.apache.org/r1749645 1.4: http://svn.apache.org/r1750292 http://svn.apache.org/r1749890 http://svn.apache.org/r1749879 1.2: http://svn.apache.org/r1750293 http://svn.apache.org/r1749893 http://svn.apache.org/r1749880 1.0: http://svn.apache.org/r1750294 http://svn.apache.org/r1749905 http://svn.apache.org/r1749881 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.6, 1.5.5 > > Attachments: OAK-4494-RDB.diff, OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Fix Version/s: 1.5.5 > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.6, 1.5.5 > > Attachments: OAK-4494-RDB.diff, OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4475) CI failing on branches due to unknown fixture SEGMENT_TAR
[
https://issues.apache.org/jira/browse/OAK-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352830#comment-15352830
]
Chetan Mehrotra commented on OAK-4475:
--
Applied the patch to trunk and branches. It ensures that if SEGMENT_TAR is
passed and enum is not found for that then it is ignored otherwise the
exception is propoagated.
Would monitor the build results now
> CI failing on branches due to unknown fixture SEGMENT_TAR
> -
>
> Key: OAK-4475
> URL: https://issues.apache.org/jira/browse/OAK-4475
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Michael Dürig
>Assignee: Chetan Mehrotra
> Labels: CI, build, jenkins
> Fix For: 1.6
>
> Attachments: OAK-4475-v1.patch
>
>
> These failures are caused by adding the SEGMENT_TAR fixture to the matrix.
> That one doesn't exit in the branches thus the {{IllegalArgumentException}}
> "No enum constant".
> See discussion http://markmail.org/message/oaptnvco5y2a4rjk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4512) Detect and log commits to the read-only stores
[ https://issues.apache.org/jira/browse/OAK-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352795#comment-15352795 ] Florin Iordache commented on OAK-4512: -- hi [~chetanm], Thanks for the feedback, I'll come back with an updated patch after integrating your suggestions. > Detect and log commits to the read-only stores > -- > > Key: OAK-4512 > URL: https://issues.apache.org/jira/browse/OAK-4512 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Reporter: Florin Iordache > Attachments: OAK-4512-patch.diff > > > Since the read-only stores will be immutable we should be able to detect > commits made against them and log an error message via a commit validation > provider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352675#comment-15352675
]
Julian Reschke edited comment on OAK-4514 at 6/28/16 11:04 AM:
---
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
1.2: http://svn.apache.org/r1750464
1.0: http://svn.apache.org/r1750469
was (Author: reschke):
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
1.2: http://svn.apache.org/r1750464
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Labels: (was: candidate_oak_1_0)
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Fix Version/s: 1.0.32
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.6, 1.0.32, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4513) Detect and log references across stores
[
https://issues.apache.org/jira/browse/OAK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352792#comment-15352792
]
Florin Iordache edited comment on OAK-4513 at 6/28/16 11:04 AM:
hi [~chetanm], thanks for the feedback.
{quote}
This needs to be an OSGi component. Further the validator provides should only
be registered if there are more than 1 mount i.e. ensure that it does not get
activated for normal setups so as to minimize any potential overhead
Would need test coverage for the implementation
{quote}
Agreed, I'll work on it and come back with an updated patch.
{quote}
As for IdentifierManager - Would need to think on that as the query it fires
would need to be run against indexes stored both in private and shared repo. So
you cannot just construct it from default PropertyIndexProvider. Having a test
would confirm the theory
{quote}
A query is the easiest way to find references based on a given uuid, and the
{{IdentifierManager}} was implemented for this purpose. Do we already have some
any IndexProvider implementation for the private repository that we could use
in a real multiplexed scenario?
If using a query is not the desired way to go here, I'm open to any other
suggestions on how we could validate the reference properties.
was (Author: florin.iordache):
hi [~chetanm], thanks for the feedback.
> This needs to be an OSGi component. Further the validator provides should
> only be registered if there are more than 1 mount i.e. ensure that it does
> not get activated for normal setups so as to minimize any potential overhead
> Would need test coverage for the implementation
Agreed, I'll work on it and come back with an updated patch.
>As for IdentifierManager - Would need to think on that as the query it fires
>would need to be run against indexes stored both in private and shared repo.
>So you cannot just construct it from default PropertyIndexProvider. Having a
>test would confirm the theory
A query is the easiest way to find references based on a given uuid, and the
{{IdentifierManager}} was implemented for this purpose. Do we already have some
any IndexProvider implementation for the private repository that we could use
in a real multiplexed scenario?
If using a query is not the desired way to go here, I'm open to any other
suggestions on how we could validate the reference properties.
> Detect and log references across stores
> ---
>
> Key: OAK-4513
> URL: https://issues.apache.org/jira/browse/OAK-4513
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Florin Iordache
> Attachments: OAK-4513-patch.diff
>
>
> References across different stores will not be allowed at runtime, we need a
> commit validator to detect and log such cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4513) Detect and log references across stores
[
https://issues.apache.org/jira/browse/OAK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352792#comment-15352792
]
Florin Iordache commented on OAK-4513:
--
hi [~chetanm], thanks for the feedback.
> This needs to be an OSGi component. Further the validator provides should
> only be registered if there are more than 1 mount i.e. ensure that it does
> not get activated for normal setups so as to minimize any potential overhead
> Would need test coverage for the implementation
Agreed, I'll work on it and come back with an updated patch.
>As for IdentifierManager - Would need to think on that as the query it fires
>would need to be run against indexes stored both in private and shared repo.
>So you cannot just construct it from default PropertyIndexProvider. Having a
>test would confirm the theory
A query is the easiest way to find references based on a given uuid, and the
{{IdentifierManager}} was implemented for this purpose. Do we already have some
any IndexProvider implementation for the private repository that we could use
in a real multiplexed scenario?
If using a query is not the desired way to go here, I'm open to any other
suggestions on how we could validate the reference properties.
> Detect and log references across stores
> ---
>
> Key: OAK-4513
> URL: https://issues.apache.org/jira/browse/OAK-4513
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Florin Iordache
> Attachments: OAK-4513-patch.diff
>
>
> References across different stores will not be allowed at runtime, we need a
> commit validator to detect and log such cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4512) Detect and log commits to the read-only stores
[
https://issues.apache.org/jira/browse/OAK-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352773#comment-15352773
]
Chetan Mehrotra commented on OAK-4512:
--
[~florin.iordache] As noted in OAK-4513
# Would need an accompanying testcase which validates the implementation
# Make it an OSGi component which registers the validator only when multiple
mount points are configured
{noformat}
+private Validator logReadOnlyMountCommit(String nodeName, NodeState
nodeState) throws CommitFailedException {
+Tree nodeStateTree = TreeFactory.createReadOnlyTree(nodeState);
+String nodePath = nodeStateTree.getPath();
+String changeNodePath = nodeStateTree.isRoot()
+? nodePath + nodeName
+: nodePath + "/" + nodeName;
{noformat}
This would not work as {{nodePath}} would always be '/'. You would need to
manage the current path as you traverse down.
> Detect and log commits to the read-only stores
> --
>
> Key: OAK-4512
> URL: https://issues.apache.org/jira/browse/OAK-4512
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Florin Iordache
> Attachments: OAK-4512-patch.diff
>
>
> Since the read-only stores will be immutable we should be able to detect
> commits made against them and log an error message via a commit validation
> provider.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4513) Detect and log references across stores
[
https://issues.apache.org/jira/browse/OAK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352768#comment-15352768
]
Chetan Mehrotra commented on OAK-4513:
--
[~florin.iordache] Couple of comments
# This needs to be an OSGi component. Further the validator provides should
only be registered if there are more than 1 mount i.e. ensure that it does not
get activated for normal setups so as to minimize any potential overhead
# Would need test coverage for the implementation
As for {{IdentifierManager}} - Would need to think on that as the query it
fires would need to be run against indexes stored both in private and shared
repo. So you cannot just construct it from default PropertyIndexProvider.
Having a test would confirm the theory
> Detect and log references across stores
> ---
>
> Key: OAK-4513
> URL: https://issues.apache.org/jira/browse/OAK-4513
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Florin Iordache
> Attachments: OAK-4513-patch.diff
>
>
> References across different stores will not be allowed at runtime, we need a
> commit validator to detect and log such cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352675#comment-15352675
]
Julian Reschke edited comment on OAK-4514 at 6/28/16 10:24 AM:
---
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
1.2: http://svn.apache.org/r1750464
was (Author: reschke):
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
1.4: http://svn.apache.org/r1750464
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0
> Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Labels: candidate_oak_1_0 (was: candidate_oak_1_0 candidate_oak_1_2)
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0
> Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352675#comment-15352675
]
Julian Reschke edited comment on OAK-4514 at 6/28/16 10:24 AM:
---
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
1.4: http://svn.apache.org/r1750464
was (Author: reschke):
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0
> Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Fix Version/s: 1.2.17
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0
> Fix For: 1.6, 1.2.17, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (OAK-4515) Catch NPE and log serverResult in MongoDocumentStore.determineServerTimeDifferenceMillis
[
https://issues.apache.org/jira/browse/OAK-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved OAK-4515.
--
Resolution: Fixed
* backported OAK-4107 to 1.4.5, including additional log details in
http://svn.apache.org/viewvc?view=revision=1750459
* applied additional log details change also to trunk in
http://svn.apache.org/viewvc?view=revision=1750460
> Catch NPE and log serverResult in
> MongoDocumentStore.determineServerTimeDifferenceMillis
>
>
> Key: OAK-4515
> URL: https://issues.apache.org/jira/browse/OAK-4515
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.5.4, 1.4.4
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: 1.6, 1.5.5, 1.4.5
>
>
> As a follow-up of OAK-4107 this is about
> * backporting OAK-4107 to 1.4.5
> * but additionally, log more details, including
> {{serverStatus.getErrorMessage()}} and {{serverStatus.getException()}}
> ** apply this to both 1.4.5 and 1.5.5
> See OAK-4107 and there-attached
> [patch|https://issues.apache.org/jira/secure/attachment/12814064/OAK-4107.1_4_branch.patch]
> (with suggested change from [~chetanm])
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OAK-4475) CI failing on branches due to unknown fixture SEGMENT_TAR
[
https://issues.apache.org/jira/browse/OAK-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra reassigned OAK-4475:
Assignee: Chetan Mehrotra
> CI failing on branches due to unknown fixture SEGMENT_TAR
> -
>
> Key: OAK-4475
> URL: https://issues.apache.org/jira/browse/OAK-4475
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Michael Dürig
>Assignee: Chetan Mehrotra
> Labels: CI, build, jenkins
> Fix For: 1.6
>
> Attachments: OAK-4475-v1.patch
>
>
> These failures are caused by adding the SEGMENT_TAR fixture to the matrix.
> That one doesn't exit in the branches thus the {{IllegalArgumentException}}
> "No enum constant".
> See discussion http://markmail.org/message/oaptnvco5y2a4rjk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4475) CI failing on branches due to unknown fixture SEGMENT_TAR
[
https://issues.apache.org/jira/browse/OAK-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra updated OAK-4475:
-
Attachment: OAK-4475-v1.patch
[patch|^OAK-4475-v1.patch] which ignore the case for SEGMENT_TAR only
[~edivad] Can you review once. Would apply and backport it to branches then
> CI failing on branches due to unknown fixture SEGMENT_TAR
> -
>
> Key: OAK-4475
> URL: https://issues.apache.org/jira/browse/OAK-4475
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Michael Dürig
> Labels: CI, build, jenkins
> Fix For: 1.6
>
> Attachments: OAK-4475-v1.patch
>
>
> These failures are caused by adding the SEGMENT_TAR fixture to the matrix.
> That one doesn't exit in the branches thus the {{IllegalArgumentException}}
> "No enum constant".
> See discussion http://markmail.org/message/oaptnvco5y2a4rjk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4494) Stale documents after revision GC in cluster
[ https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4494: Attachment: OAK-4494-RDB.diff Proposed patch for RDB - this adds additional checks for a matching lastmodified value (this is sufficient to make the new test pass, but we probably need to review the code for other places where we rely solely on MODCOUNT). > Stale documents after revision GC in cluster > > > Key: OAK-4494 > URL: https://issues.apache.org/jira/browse/OAK-4494 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk, mongomk, rdbmk >Reporter: Marcel Reutegger >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.6 > > Attachments: OAK-4494-RDB.diff, OAK-4494.patch, OAK-4494.patch > > > Implement additional tests for revision GC in a cluster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Labels: candidate_oak_1_0 candidate_oak_1_2 (was: candidate_oak_1_0
candidate_oak_1_2 candidate_oak_1_4)
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.6, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Fix Version/s: 1.4.5
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.6, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352675#comment-15352675
]
Julian Reschke edited comment on OAK-4514 at 6/28/16 9:49 AM:
--
trunk: http://svn.apache.org/r1750457
1.4: http://svn.apache.org/r1750458
was (Author: reschke):
trunk: http://svn.apache.org/r1750457
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.6, 1.5.5, 1.4.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4515) Catch NPE and log serverResult in MongoDocumentStore.determineServerTimeDifferenceMillis
[
https://issues.apache.org/jira/browse/OAK-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-4515:
-
Fix Version/s: 1.6
> Catch NPE and log serverResult in
> MongoDocumentStore.determineServerTimeDifferenceMillis
>
>
> Key: OAK-4515
> URL: https://issues.apache.org/jira/browse/OAK-4515
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.5.4, 1.4.4
>Reporter: Stefan Egli
>Assignee: Stefan Egli
> Fix For: 1.6, 1.5.5, 1.4.5
>
>
> As a follow-up of OAK-4107 this is about
> * backporting OAK-4107 to 1.4.5
> * but additionally, log more details, including
> {{serverStatus.getErrorMessage()}} and {{serverStatus.getException()}}
> ** apply this to both 1.4.5 and 1.5.5
> See OAK-4107 and there-attached
> [patch|https://issues.apache.org/jira/secure/attachment/12814064/OAK-4107.1_4_branch.patch]
> (with suggested change from [~chetanm])
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-4514:
--
Fix Version/s: 1.6
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.6, 1.5.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-4514.
-
Resolution: Fixed
Fix Version/s: 1.5.5
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.5.5
>
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-4514:
Summary: ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS
disposal (was: AbstractDocumentStore to cleanup may interfere with DS disposal)
> ResurrectNodeAfterRevisionGCTest's cleanup may interfere with DS disposal
> -
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4107) NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
[
https://issues.apache.org/jira/browse/OAK-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352655#comment-15352655
]
Stefan Egli edited comment on OAK-4107 at 6/28/16 9:23 AM:
---
bq. Also would be better to have a new issue and fix this both on trunk and 1.4
branch
Probably better, yes, to have this separated. Created OAK-4515 for that. So
OAK-4107 can stay closed as is and we can continue discussing on OAK-4515.
was (Author: egli):
bq. Also would be better to have a new issue and fix this both on trunk and 1.4
branch
Probably better yet, to have this separated. Created OAK-4515 for that. So
OAK-4107 can stay closed as is and we can continue discussing on OAK-4515.
> NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
> -
>
> Key: OAK-4107
> URL: https://issues.apache.org/jira/browse/OAK-4107
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Reporter: Chetan Mehrotra
>Assignee: Stefan Egli
>Priority: Minor
> Labels: candidate_oak_1_4
> Fix For: 1.6, 1.5.2
>
> Attachments: OAK-4107.1_4_branch.patch, OAK-4107.patch
>
>
> On system startup with Mongo following exception is seen
> {noformat}
> 07.03.2016 06:26:10.529 *WARN* [FelixStartLevel]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService
> registerNodeStore: got RuntimeException while trying to determine time
> difference to server: java.lang.NullPointerException
> java.lang.NullPointerException: null
> at
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoDocumentStore.determineServerTimeDifferenceMillis(MongoDocumentStore.java:1568)
> at
> org.apache.jackrabbit.oak.plugins.document.util.LeaseCheckDocumentStoreWrapper.determineServerTimeDifferenceMillis(LeaseCheckDocumentStoreWrapper.java:203)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStore(DocumentNodeStoreService.java:514)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStoreIfPossible(DocumentNodeStoreService.java:371)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.bindBlobStore(DocumentNodeStoreService.java:554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> Per code {{serverLocalTime}} appears to be null
> {code}
> final Date serverLocalTime = db.command("serverStatus").getDate("localTime");
> final long end = System.currentTimeMillis();
> final long midPoint = (start + end) / 2;
> final long serverLocalTimeMillis = serverLocalTime.getTime();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4107) NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
[
https://issues.apache.org/jira/browse/OAK-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352643#comment-15352643
]
Chetan Mehrotra commented on OAK-4107:
--
Looks good. Just minor change
{noformat}+ LOG.warn("determineServerTimeDifferenceMillis:
db.serverStatus.localTime returned null - cannot determine time difference -
assuming 0ms. "
+ + "(Result details: exception=" +
serverStatus.getException() + ", errorMessage=" +
serverStatus.getErrorMessage() + ")");
+ return 0;
{noformat}
Instead of that have it like
{noformat}
+ LOG.warn("determineServerTimeDifferenceMillis:
db.serverStatus.localTime returned null - cannot determine time difference -
assuming 0ms. "
+ + "(Result details: server error message {}",
serverStatus.getErrorMessage(), serverStatus.getException());
+ return 0;
{noformat}
This would ensure the any exception stacktrace gets also dumped. Also would be
better to have a new issue and fix this both on trunk and 1.4 branch
> NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
> -
>
> Key: OAK-4107
> URL: https://issues.apache.org/jira/browse/OAK-4107
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Reporter: Chetan Mehrotra
>Assignee: Stefan Egli
>Priority: Minor
> Labels: candidate_oak_1_4
> Fix For: 1.6, 1.5.2
>
> Attachments: OAK-4107.1_4_branch.patch, OAK-4107.patch
>
>
> On system startup with Mongo following exception is seen
> {noformat}
> 07.03.2016 06:26:10.529 *WARN* [FelixStartLevel]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService
> registerNodeStore: got RuntimeException while trying to determine time
> difference to server: java.lang.NullPointerException
> java.lang.NullPointerException: null
> at
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoDocumentStore.determineServerTimeDifferenceMillis(MongoDocumentStore.java:1568)
> at
> org.apache.jackrabbit.oak.plugins.document.util.LeaseCheckDocumentStoreWrapper.determineServerTimeDifferenceMillis(LeaseCheckDocumentStoreWrapper.java:203)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStore(DocumentNodeStoreService.java:514)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStoreIfPossible(DocumentNodeStoreService.java:371)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.bindBlobStore(DocumentNodeStoreService.java:554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> Per code {{serverLocalTime}} appears to be null
> {code}
> final Date serverLocalTime = db.command("serverStatus").getDate("localTime");
> final long end = System.currentTimeMillis();
> final long midPoint = (start + end) / 2;
> final long serverLocalTimeMillis = serverLocalTime.getTime();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4514) AbstractDocumentStore to cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352631#comment-15352631
]
Marcel Reutegger commented on OAK-4514:
---
Sure, feel free to commit.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (OAK-4107) NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
[
https://issues.apache.org/jira/browse/OAK-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352560#comment-15352560
]
Stefan Egli edited comment on OAK-4107 at 6/28/16 8:47 AM:
---
[~chetanm], good point. I've modified the original patch for the 1.4 branch,
and added logging the exception (probably null though) and errorMessage.
Attached [^OAK-4107.1_4_branch.patch]. wdyt?
(EDIT: I'd also apply this additional logging to trunk as that makes sense
there too of course)
was (Author: egli):
[~chetanm], good point. I've modified the original patch for the 1.4 branch,
and added logging the exception (probably null though) and errorMessage.
Attached [^OAK-4107.1_4_branch.patch]. wdyt?
> NPE in MongoDocumentStore.determineServerTimeDifferenceMillis
> -
>
> Key: OAK-4107
> URL: https://issues.apache.org/jira/browse/OAK-4107
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Reporter: Chetan Mehrotra
>Assignee: Stefan Egli
>Priority: Minor
> Labels: candidate_oak_1_4
> Fix For: 1.6, 1.5.2
>
> Attachments: OAK-4107.1_4_branch.patch, OAK-4107.patch
>
>
> On system startup with Mongo following exception is seen
> {noformat}
> 07.03.2016 06:26:10.529 *WARN* [FelixStartLevel]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService
> registerNodeStore: got RuntimeException while trying to determine time
> difference to server: java.lang.NullPointerException
> java.lang.NullPointerException: null
> at
> org.apache.jackrabbit.oak.plugins.document.mongo.MongoDocumentStore.determineServerTimeDifferenceMillis(MongoDocumentStore.java:1568)
> at
> org.apache.jackrabbit.oak.plugins.document.util.LeaseCheckDocumentStoreWrapper.determineServerTimeDifferenceMillis(LeaseCheckDocumentStoreWrapper.java:203)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStore(DocumentNodeStoreService.java:514)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.registerNodeStoreIfPossible(DocumentNodeStoreService.java:371)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService.bindBlobStore(DocumentNodeStoreService.java:554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> Per code {{serverLocalTime}} appears to be null
> {code}
> final Date serverLocalTime = db.command("serverStatus").getDate("localTime");
> final long end = System.currentTimeMillis();
> final long midPoint = (start + end) / 2;
> final long serverLocalTimeMillis = serverLocalTime.getTime();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4514) AbstractDocumentStore to cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352586#comment-15352586
]
Julian Reschke commented on OAK-4514:
-
I can make the {{dispose}} method tolerant.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) AbstractDocumentStore to cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-4514:
--
Attachment: OAK-4514.patch
Proposed fix.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-4514.patch
>
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-4514) AbstractDocumentStore to cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-4514:
--
Description:
{{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
instances when cleaning up.
This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
store instances on top of the document stores, and calls {{dispose()}} on them,
leading to multiple calls to {{dispose}} on the same instance.
was:
{{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
instances when cleaning up.
This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
store instances on top of the document stores, and calls {{dispose()} on them,
leading to multiple calls to {{dispose}} on the same instance.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()}} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4514) AbstractDocumentStore to cleanup may interfere with DS disposal
[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352441#comment-15352441
]
Marcel Reutegger commented on OAK-4514:
---
So far we made sure the test doesn't close the store twice. Well, except for
this one ;)
For now, I would change the test, but in the long run it may be better to have
the same behavior for all implementations. I'd say if there is no way to find
out whether a store is disposed already, then the store should not throw on
multiple dispose calls. Otherwise we should add a method that allows you to
check whether a store is already disposed. I prefer the first.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
