[jira] [Commented] (OAK-3201) Use static references in SecurityProviderImpl for composite services

2015-09-15 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744985#comment-14744985 ] Francesco Mari commented on OAK-3201: - I'm pretty satisfied with the result, I'm going to commit this

[jira] [Commented] (OAK-3390) Avoid instanceof check in DocumentNodeStore

2015-09-15 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744991#comment-14744991 ] Marcel Reutegger commented on OAK-3390: --- This issue is specifically about the instanceof check in

[jira] [Created] (OAK-3405) Avoid instanceof check in LastRevRecoveryAgent

2015-09-15 Thread Marcel Reutegger (JIRA)
Marcel Reutegger created OAK-3405: - Summary: Avoid instanceof check in LastRevRecoveryAgent Key: OAK-3405 URL: https://issues.apache.org/jira/browse/OAK-3405 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-3201) Use static references in SecurityProviderImpl for composite services

2015-09-15 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745023#comment-14745023 ] Chetan Mehrotra commented on OAK-3201: -- Missed reviewing it due to other issues. Some quick comments *

[jira] [Resolved] (OAK-3118) Strange error message when using FileDataStore with minRecordLength=1m

2015-09-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-3118. - Resolution: Duplicate OK, so resolved as duplicate. Thanks! > Strange error message when using

[jira] [Commented] (OAK-3399) 5sec retry loop before declaring lease failure (was: as a last resort try to update it there)

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745175#comment-14745175 ] Stefan Egli commented on OAK-3399: -- implemented this idea in http://svn.apache.org/r1703137 > 5sec retry

[jira] [Commented] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745040#comment-14745040 ] Stefan Egli commented on OAK-3311: -- OAK-3396 shows details of the NPE showing up thanks to oak patched with

[jira] [Commented] (OAK-3238) fine tune clock-sync check vs lease-check settings

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745194#comment-14745194 ] Stefan Egli commented on OAK-3238: -- Note that with OAK-3398 and OAK-3399 incorporated in 1.3.7 the timing

[jira] [Commented] (OAK-3398) make lease update more robust

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745133#comment-14745133 ] Stefan Egli commented on OAK-3398: -- third point done too: * only update the lease when {{state}} and

[jira] [Resolved] (OAK-3398) make lease update more robust

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-3398. -- Resolution: Fixed > make lease update more robust > - > >

[jira] [Commented] (OAK-2739) take appropriate action when lease cannot be renewed (in time)

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745177#comment-14745177 ] Stefan Egli commented on OAK-2739: -- bq. but can we make this a bit more developer friendly? yes we can:

[jira] [Resolved] (OAK-3399) 5sec retry loop before declaring lease failure (was: as a last resort try to update it there)

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-3399. -- Resolution: Fixed > 5sec retry loop before declaring lease failure (was: as a last resort try to >

[jira] [Updated] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-3250: - Issue Type: Wish (was: Improvement) > Restart DocumentNodeStore on lease timeout instead of System.exit >

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-09-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745601#comment-14745601 ] Tobias Bocanegra commented on OAK-3396: --- [~egli] thanks. can you also create a test case? > NPE

[jira] [Commented] (OAK-3372) Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745626#comment-14745626 ] Vikas Saurabh commented on OAK-3372: Ack > Collapsing external events in BackgroundObserver even before

[jira] [Updated] (OAK-3382) Improve Registration Of ConflictHandlers

2015-09-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-3382: Component/s: core > Improve Registration Of ConflictHandlers > > >

[jira] [Updated] (OAK-3358) Make SecurityProviderImpl independent from OSGi

2015-09-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-3358: Component/s: (was: security) > Make SecurityProviderImpl independent from OSGi >

[jira] [Assigned] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-09-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra reassigned OAK-3396: - Assignee: Tobias Bocanegra > NPE during syncAllExternalUsers in

[jira] [Updated] (OAK-3374) Concurrent Updates of Group's Membership Results in Conflict

2015-09-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-3374: Component/s: (was: security) > Concurrent Updates of Group's Membership Results in Conflict >

[jira] [Updated] (OAK-3302) ExternalLoginModule:193 can never be reached

2015-09-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-3302: Component/s: (was: auth-ldap) > ExternalLoginModule:193 can never be reached >

[jira] [Updated] (OAK-3371) Wrong evaluation of NOT clause

2015-09-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-3371: Attachment: OAK-3371-3-oak-core.patch OAK-3371-3-oak-core.patch (just the oak-core part). More work

[jira] [Updated] (OAK-3348) Cross gc sessions might introduce references to pre-compacted segments

2015-09-15 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-3348: --- Attachment: OAK-3348-2.patch [^OAK-3348-2.patch]: updated patch again. Turns out that adding node to

[jira] [Commented] (OAK-3372) Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used

2015-09-15 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745607#comment-14745607 ] Michael Dürig commented on OAK-3372: bq. I assume whenever cluster support comes it there'd some way

[jira] [Assigned] (OAK-3394) RDBDocumentStore startup: log more DDL information (incl. index information)

2015-09-15 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned OAK-3394: --- Assignee: Julian Reschke > RDBDocumentStore startup: log more DDL information (incl. index

[jira] [Commented] (OAK-3382) Improve Registration Of ConflictHandlers

2015-09-15 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746049#comment-14746049 ] Michael Dürig commented on OAK-3382: This has been addressed with OAK-2387. That issue introduced

[jira] [Created] (OAK-3408) RDBDocumentStore: improve MySQL diagnostics

2015-09-15 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-3408: --- Summary: RDBDocumentStore: improve MySQL diagnostics Key: OAK-3408 URL: https://issues.apache.org/jira/browse/OAK-3408 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-3399) 5sec retry loop before declaring lease failure (was: as a last resort try to update it there)

2015-09-15 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745276#comment-14745276 ] Stefan Egli commented on OAK-3399: -- plus a buglet fix in http://svn.apache.org/r1703156 > 5sec retry loop

[jira] [Updated] (OAK-3406) Configuration to rank exact match suggestions over partial match suggestions

2015-09-15 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated OAK-3406: - Assignee: Vikas Saurabh > Configuration to rank exact match suggestions over partial match

[jira] [Updated] (OAK-3201) Use static references in SecurityProviderImpl for composite services

2015-09-15 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Mari updated OAK-3201: Attachment: OAK-3201-07.patch [~chetanm], the latest patch should address your concerns. In

[jira] [Commented] (OAK-3201) Use static references in SecurityProviderImpl for composite services

2015-09-15 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745497#comment-14745497 ] Francesco Mari commented on OAK-3201: - I'm also wondering if explicit synchronization could be removed

[jira] [Commented] (OAK-3156) Lucene suggestions index definition can't be restricted to a specific type of node

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745499#comment-14745499 ] Vikas Saurabh commented on OAK-3156: I meant we maintain the status-quo as today i.e. suggest and spell

[jira] [Commented] (OAK-3407) Configuration to have more coarse suggested phrases

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745417#comment-14745417 ] Vikas Saurabh commented on OAK-3407: [~teofili], can you please assign, fixVersion, attach labels and

[jira] [Commented] (OAK-3156) Lucene suggestions index definition can't be restricted to a specific type of node

2015-09-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745420#comment-14745420 ] Thomas Mueller commented on OAK-3156: - > For the specific case of suggest (and spellcheck) we currently

[jira] [Updated] (OAK-3395) RevisionGC fails for JCR paths having line feed characters

2015-09-15 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-3395: - Attachment: OAK-3395-1.patch [initial patch|^OAK-3395-1.patch] to review the approach (javadocs

[jira] [Commented] (OAK-3372) Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745460#comment-14745460 ] Vikas Saurabh commented on OAK-3372: Wow... {{SegmentNodeStore#refreshHead}} seems like a very

[jira] [Commented] (OAK-3156) Lucene suggestions index definition can't be restricted to a specific type of node

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745445#comment-14745445 ] Vikas Saurabh commented on OAK-3156: {quote} > SELECT [rep:suggest()] FROM [app:Asset] AS s WHERE

[jira] [Updated] (OAK-3406) Configuration to rank exact match suggestions over partial match suggestions

2015-09-15 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated OAK-3406: - Fix Version/s: 1.3.7 > Configuration to rank exact match suggestions over partial match suggestions

[jira] [Created] (OAK-3406) Configuration to rank exact match suggestions over partial match suggestions

2015-09-15 Thread Vikas Saurabh (JIRA)
Vikas Saurabh created OAK-3406: -- Summary: Configuration to rank exact match suggestions over partial match suggestions Key: OAK-3406 URL: https://issues.apache.org/jira/browse/OAK-3406 Project:

[jira] [Commented] (OAK-3406) Configuration to rank exact match suggestions over partial match suggestions

2015-09-15 Thread Vikas Saurabh (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745392#comment-14745392 ] Vikas Saurabh commented on OAK-3406: [~teofili], can you please assign, fixVersion, attach labels and

[jira] [Commented] (OAK-3372) Collapsing external events in BackgroundObserver even before queue is full leads to JournalEntry not getting used

2015-09-15 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745425#comment-14745425 ] Michael Dürig commented on OAK-3372: There is not clustering option for the segment node store (yet).

[jira] [Created] (OAK-3407) Configuration to have more coarse suggested phrases

2015-09-15 Thread Vikas Saurabh (JIRA)
Vikas Saurabh created OAK-3407: -- Summary: Configuration to have more coarse suggested phrases Key: OAK-3407 URL: https://issues.apache.org/jira/browse/OAK-3407 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-3156) Lucene suggestions index definition can't be restricted to a specific type of node

2015-09-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745426#comment-14745426 ] Thomas Mueller commented on OAK-3156: - > Make suggest queries to return paths OK, what path would we

[jira] [Commented] (OAK-3395) RevisionGC fails for JCR paths having line feed characters

2015-09-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745542#comment-14745542 ] Thomas Mueller commented on OAK-3395: - I would add randomized tests, for example: {noformat}

[jira] [Updated] (OAK-3408) RDBDocumentStore: improve MySQL diagnostics

2015-09-15 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3408: Fix Version/s: 1.3.7 > RDBDocumentStore: improve MySQL diagnostics >

[jira] [Updated] (OAK-3408) RDBDocumentStore: improve MySQL diagnostics

2015-09-15 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-3408: Fix Version/s: 1.0.21 1.2.6 > RDBDocumentStore: improve MySQL diagnostics >

[jira] [Resolved] (OAK-3408) RDBDocumentStore: improve MySQL diagnostics

2015-09-15 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-3408. - Resolution: Fixed > RDBDocumentStore: improve MySQL diagnostics >