[jira] [Resolved] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-19 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-7354. --- Resolution: Fixed Assignee: Alex Deparvu Fix Version/s: 1.10 1.9.0

[jira] [Commented] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402155#comment-16402155 ] Alex Deparvu commented on OAK-7354: --- I agree it looks like a cleanup issue, but it started failing only

[jira] [Commented] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401980#comment-16401980 ] Alex Deparvu commented on OAK-7354: --- I can't reproduce this locally. [~anchela] do you have any ideas, it

[jira] [Updated] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7354: -- Component/s: auth-external > Test failure

[jira] [Updated] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7354: -- Description: The build Jackrabbit Oak #1318 has failed. First failed run: [Jackrabbit Oak

[jira] [Updated] (OAK-7354) Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7354: -- Summary: Test failure ExternalIdentityImporterTest.importExternalUserWithPrincipalNames (was: Build

[jira] [Resolved] (OAK-7340) Remove SecurityProviderImpl usage from tests

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-7340. --- Resolution: Fixed http://svn.apache.org/viewvc?rev=1826984=rev > Remove SecurityProviderImpl usage

[jira] [Updated] (OAK-7340) Remove SecurityProviderImpl usage from tests

2018-03-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7340: -- Fix Version/s: 1.10 > Remove SecurityProviderImpl usage from tests >

[jira] [Commented] (OAK-7341) PermissionStoreEditor fails to reconnect collision entries if main entry is removed

2018-03-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400480#comment-16400480 ] Alex Deparvu commented on OAK-7341: --- looks good! +1 > PermissionStoreEditor fails to reconnect collision

[jira] [Commented] (OAK-7340) Remove SecurityProviderImpl usage from tests

2018-03-14 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398773#comment-16398773 ] Alex Deparvu commented on OAK-7340: --- Wip branch

[jira] [Created] (OAK-7340) Remove SecurityProviderImpl usage from tests

2018-03-14 Thread Alex Deparvu (JIRA)
Alex Deparvu created OAK-7340: - Summary: Remove SecurityProviderImpl usage from tests Key: OAK-7340 URL: https://issues.apache.org/jira/browse/OAK-7340 Project: Jackrabbit Oak Issue Type:

[jira] [Updated] (OAK-7340) Remove SecurityProviderImpl usage from tests

2018-03-14 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7340: -- Fix Version/s: 1.9.0 > Remove SecurityProviderImpl usage from tests >

[jira] [Resolved] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-02-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-7203. --- Resolution: Won't Fix Fix Version/s: (was: 1.9.0) > Make MountInfoProvider service in

[jira] [Updated] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-02-13 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7203: -- Fix Version/s: 1.9.0 > Make MountInfoProvider service in AuthorizationConfigurationImpl optional >

[jira] [Assigned] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-02-13 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu reassigned OAK-7203: - Assignee: Alex Deparvu > Make MountInfoProvider service in AuthorizationConfigurationImpl optional

[jira] [Commented] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-02-13 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362358#comment-16362358 ] Alex Deparvu commented on OAK-7203: --- I took another look at the patch and I'm ok with applying it (didn't

[jira] [Commented] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-02-13 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362337#comment-16362337 ] Alex Deparvu commented on OAK-7203: --- bq. any chance to get this fixed for 1.8 this might seem a bit harsh,

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-02-05 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352181#comment-16352181 ] Alex Deparvu commented on OAK-7024: --- I have updated my WIP oak branch to the latest jackrabbit release

[jira] [Commented] (OAK-7232) MountPermissionProvider.load can return null

2018-02-01 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348655#comment-16348655 ] Alex Deparvu commented on OAK-7232: --- patch looks good. I don't like returning nulls, but I don't have a

[jira] [Commented] (OAK-7231) Remove PermissionEntryCache.getNumEntries

2018-02-01 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348649#comment-16348649 ] Alex Deparvu commented on OAK-7231: --- looks good! > Remove PermissionEntryCache.getNumEntries >

[jira] [Resolved] (OAK-7227) MountPermissionProvider getNumEntries prone to overflow

2018-01-31 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-7227. --- Resolution: Fixed Fix Version/s: 1.8.2 applied patch provided on OAK-7228 with

[jira] [Updated] (OAK-7227) MountPermissionProvider getNumEntries prone to overflow

2018-01-31 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7227: -- Issue Type: Bug (was: Improvement) > MountPermissionProvider getNumEntries prone to overflow >

[jira] [Created] (OAK-7227) MountPermissionProvider getNumEntries prone to overflow

2018-01-31 Thread Alex Deparvu (JIRA)
Alex Deparvu created OAK-7227: - Summary: MountPermissionProvider getNumEntries prone to overflow Key: OAK-7227 URL: https://issues.apache.org/jira/browse/OAK-7227 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-01-31 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346629#comment-16346629 ] Alex Deparvu commented on OAK-7203: --- bq. bind/unbind removed additionally could you explain why this is

[jira] [Commented] (OAK-7203) Make MountInfoProvider service in AuthorizationConfigurationImpl optional

2018-01-29 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343506#comment-16343506 ] Alex Deparvu commented on OAK-7203: --- I agree with making it optional, but I'm not convinced we need to

[jira] [Commented] (OAK-7195) Node.getMixinNodeTypes() may check for child node named jcr:mixinTypes

2018-01-24 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337730#comment-16337730 ] Alex Deparvu commented on OAK-7195: --- patch looks good to me, and thanks for adding the benchmark results!

[jira] [Commented] (OAK-7183) Update Oak trunk to Jackrabbit 2.17.1

2018-01-23 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336027#comment-16336027 ] Alex Deparvu commented on OAK-7183: --- I would need JCR-4249, to unblock some of the work needed on the Oak

[jira] [Commented] (OAK-7186) avoid use of guava Iterators.emptyIterator()

2018-01-22 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334860#comment-16334860 ] Alex Deparvu commented on OAK-7186: --- +1 > avoid use of guava Iterators.emptyIterator() >

[jira] [Resolved] (OAK-6015) ACL of versioned node can be modified without checking out the node

2018-01-19 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6015. --- Resolution: Not A Problem thanks for the clarifications [~anchela], [~mreutegg]!. it seems this works

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-17 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328905#comment-16328905 ] Alex Deparvu commented on OAK-7024: --- I have updated the wip branch with a cleaner solution: provide

[jira] [Comment Edited] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326247#comment-16326247 ] Alex Deparvu edited comment on OAK-7024 at 1/15/18 3:06 PM: Just realised the

[jira] [Comment Edited] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326247#comment-16326247 ] Alex Deparvu edited comment on OAK-7024 at 1/15/18 3:05 PM: Just realised the

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326247#comment-16326247 ] Alex Deparvu commented on OAK-7024: --- Just realised the proposed approach for the consumers would not work,

[jira] [Comment Edited] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-12 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324093#comment-16324093 ] Alex Deparvu edited comment on OAK-7024 at 1/12/18 3:09 PM: Bonus question, as

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-12 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324093#comment-16324093 ] Alex Deparvu commented on OAK-7024: --- Bonus question, as raised by [~reschke], is Jackrabbit has the same

[jira] [Comment Edited] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-12 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324091#comment-16324091 ] Alex Deparvu edited comment on OAK-7024 at 1/12/18 3:07 PM: bq. choose an

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-12 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324091#comment-16324091 ] Alex Deparvu commented on OAK-7024: --- bq. choose an intermediate step still supporting it but marking it

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-11 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322404#comment-16322404 ] Alex Deparvu commented on OAK-7024: --- WIP branch at [0]: * patch makes no effort for maintaining backwards

[jira] [Commented] (OAK-7141) Remove unused metatype.properties

2018-01-11 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322281#comment-16322281 ] Alex Deparvu commented on OAK-7141: --- [~mreutegg] Correct me if I'm wrong but the current

[jira] [Commented] (OAK-7138) Move metatype files in source control to correct location

2018-01-11 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321931#comment-16321931 ] Alex Deparvu commented on OAK-7138: --- I think the same question applies to {{oak-core}} as well. looking at

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-09 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318659#comment-16318659 ] Alex Deparvu commented on OAK-7024: --- sure, didn't mean to say I'm against the idea, only that it might not

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-09 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318630#comment-16318630 ] Alex Deparvu commented on OAK-7024: --- bq. ...and keep the package name? I wonder whether the java 11 class

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-09 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318578#comment-16318578 ] Alex Deparvu commented on OAK-7024: --- The impact is mainly related to the _java.security.acl.Group_ class,

[jira] [Commented] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316500#comment-16316500 ] Alex Deparvu commented on OAK-7024: --- I'll take a look > java.security.acl deprecated in Java 10, marked

[jira] [Assigned] (OAK-7024) java.security.acl deprecated in Java 10, marked for removal in Java 11

2018-01-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu reassigned OAK-7024: - Assignee: Alex Deparvu > java.security.acl deprecated in Java 10, marked for removal in Java 11 >

[jira] [Resolved] (OAK-6139) Test failure: SecurityProviderRegistrationTest.testRequiredAuthorizationConfigurationNotAvailable()

2018-01-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6139. --- Resolution: Incomplete Fix Version/s: (was: 1.10) (was: 1.9.0) > Test

[jira] [Updated] (OAK-7022) Prepare for usage of Root/TreeProvider in security tests

2017-12-11 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7022: -- Attachment: oak-7022.patch [~anchela] proposed patch. I also changed a bit of existing oak-core tests

[jira] [Resolved] (OAK-6982) Test failure: TokenCleanupTest.testAllExpiredReachingThreshold

2017-12-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6982. --- Resolution: Fixed fixed with http://svn.apache.org/viewvc?rev=1817475=rev the issue was in the test

[jira] [Resolved] (OAK-7040) Fix unbindTreeProvider method on SecurityProviderRegistration

2017-12-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-7040. --- Resolution: Fixed Fix Version/s: 1.7.13 http://svn.apache.org/viewvc?rev=1817470=rev > Fix

[jira] [Updated] (OAK-6982) Test failure: TokenCleanupTest.testAllExpiredReachingThreshold

2017-12-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6982: -- Fix Version/s: 1.7.13 > Test failure: TokenCleanupTest.testAllExpiredReachingThreshold >

[jira] [Assigned] (OAK-6982) Test failure: TokenCleanupTest.testAllExpiredReachingThreshold

2017-12-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu reassigned OAK-6982: - Assignee: Alex Deparvu > Test failure: TokenCleanupTest.testAllExpiredReachingThreshold >

[jira] [Created] (OAK-7040) Fix unbindTreeProvider method on SecurityProviderRegistration

2017-12-08 Thread Alex Deparvu (JIRA)
Alex Deparvu created OAK-7040: - Summary: Fix unbindTreeProvider method on SecurityProviderRegistration Key: OAK-7040 URL: https://issues.apache.org/jira/browse/OAK-7040 Project: Jackrabbit Oak

[jira] [Commented] (OAK-6867) Enable index hints on UUID lookup query

2017-12-07 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281685#comment-16281685 ] Alex Deparvu commented on OAK-6867: --- thanks a lot [~tmueller]! > Enable index hints on UUID lookup query

[jira] [Updated] (OAK-7013) Replace usage in oak-auth-external

2017-12-07 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-7013: -- Attachment: oak-auth-external.patch [~anchela] I tried a different approach for this module, to remove

[jira] [Commented] (OAK-7018) Move setup of composite security configurations to SecurityProviderBuilder

2017-12-01 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274246#comment-16274246 ] Alex Deparvu commented on OAK-7018: --- looks good! > Move setup of composite security configurations to

[jira] [Commented] (OAK-6980) Replacement for RootFactory and TreeFactory

2017-11-30 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272758#comment-16272758 ] Alex Deparvu commented on OAK-6980: --- The direction seems good to me. I'm wondering if it would be worth it

[jira] [Resolved] (OAK-6221) Deprecate SecurityProviderImpl

2017-11-29 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6221. --- Resolution: Fixed Fix Version/s: 1.7.12 1.8 fixed with

[jira] [Commented] (OAK-6867) Enable index hints on UUID lookup query

2017-11-28 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268509#comment-16268509 ] Alex Deparvu commented on OAK-6867: --- bq. So with 10 property indexes, the differences seems to be still

[jira] [Commented] (OAK-6979) CugConfiguration.unbindMountInfoProvider doesn't restore the default

2017-11-28 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268490#comment-16268490 ] Alex Deparvu commented on OAK-6979: --- sure, I added a comment to that line

[jira] [Commented] (OAK-6221) Deprecate SecurityProviderImpl

2017-11-27 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266946#comment-16266946 ] Alex Deparvu commented on OAK-6221: --- I adjusted the patch to match your feedback (moved the builder to

[jira] [Commented] (OAK-6980) Replacement for RootFactory and TreeFactory

2017-11-27 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266628#comment-16266628 ] Alex Deparvu commented on OAK-6980: --- looks good [~anchela], I agree with removing the usage of the static

[jira] [Updated] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-27 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6818: -- Fix Version/s: 1.7.12 > TokenAuthentication/TokenProviderImpl: cleanup expired tokens >

[jira] [Commented] (OAK-6979) CugConfiguration.unbindMountInfoProvider doesn't restore the default

2017-11-27 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266593#comment-16266593 ] Alex Deparvu commented on OAK-6979: --- Angela, I don't think I agree with this reasoning. The way I see it

[jira] [Resolved] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-22 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6818. --- Resolution: Fixed fixed with r1816064 also updated the docs. Angela please check if it looks good! >

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-22 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262320#comment-16262320 ] Alex Deparvu commented on OAK-6818: --- you can find here the updated version with the bench & new skip [0].

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-22 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262294#comment-16262294 ] Alex Deparvu commented on OAK-6818: --- here's a way to reduce the conflicts based on the previous idea of

[jira] [Commented] (OAK-6221) Deprecate SecurityProviderImpl

2017-11-21 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261083#comment-16261083 ] Alex Deparvu commented on OAK-6221: --- [~anchela] could you take a look at the branch [0]? I kept the

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-21 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260566#comment-16260566 ] Alex Deparvu commented on OAK-6818: --- Benchmark runs for 1 minute (default), tokens expire after {{15

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-21 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260404#comment-16260404 ] Alex Deparvu commented on OAK-6818: --- I see some merge conflicts with while running the benchmark with

[jira] [Resolved] (OAK-6940) Login token name generation is prone to race conditions

2017-11-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6940. --- Resolution: Fixed Fix Version/s: 1.7.12 replaced the calendar with the existing uuid. also

[jira] [Updated] (OAK-6940) Login token name generation is prone to race conditions

2017-11-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6940: -- Priority: Trivial (was: Major) > Login token name generation is prone to race conditions >

[jira] [Updated] (OAK-6402) SessionStats log access warning

2017-11-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6402: -- Fix Version/s: (was: 1.8) 1.10 > SessionStats log access warning >

[jira] [Updated] (OAK-6225) Analyse changing the persistence format of GroupImpl

2017-11-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6225: -- Fix Version/s: (was: 1.8) 1.10 > Analyse changing the persistence format of

[jira] [Commented] (OAK-1588) Create more tests/validation to LDAP integration

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256611#comment-16256611 ] Alex Deparvu commented on OAK-1588: --- I reduced the min coverage to 0.85 to get the builds running again

[jira] [Closed] (OAK-6962) Build Jackrabbit Oak #986 failed

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu closed OAK-6962. - > Build Jackrabbit Oak #986 failed > > > Key: OAK-6962 >

[jira] [Resolved] (OAK-6962) Build Jackrabbit Oak #986 failed

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6962. --- Resolution: Duplicate > Build Jackrabbit Oak #986 failed > > >

[jira] [Commented] (OAK-1588) Create more tests/validation to LDAP integration

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255789#comment-16255789 ] Alex Deparvu commented on OAK-1588: --- there was one failure of the CI machine related to the coverage

[jira] [Commented] (OAK-6957) Remove export for org.apache.jackrabbit.oak.security

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255669#comment-16255669 ] Alex Deparvu commented on OAK-6957: --- Isn't this (almost) the same as removing the SecurityProviderImpl

[jira] [Commented] (OAK-6221) Deprecate SecurityProviderImpl

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255664#comment-16255664 ] Alex Deparvu commented on OAK-6221: --- yeah, I wanted to get this in before 1.8. I'll pick up the patch

[jira] [Resolved] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved OAK-6826. --- Resolution: Fixed Fix Version/s: 1.7.12 fixed with http://svn.apache.org/viewvc?rev=1815457=rev

[jira] [Commented] (OAK-6826) Refactor Jcr class to remove dependency on o.a.j.oak.plugins.index

2017-11-16 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255227#comment-16255227 ] Alex Deparvu commented on OAK-6826: --- ack. [~anchela] let me test this out against latest trunk and will

[jira] [Commented] (OAK-6946) org.apache.jackrabbit.oak.security.authentication.ldap must not be exported

2017-11-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253973#comment-16253973 ] Alex Deparvu commented on OAK-6946: --- bq. the exclusion-entry in the parent-pom was just redundant, wasn't

[jira] [Commented] (OAK-6946) org.apache.jackrabbit.oak.security.authentication.ldap must not be exported

2017-11-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253649#comment-16253649 ] Alex Deparvu commented on OAK-6946: --- hmm, are you sure that's the case? I looked at the exports and see

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-15 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253473#comment-16253473 ] Alex Deparvu commented on OAK-6818: --- [~anchela] I added a benchmark to the existing patch. see WIP branch

[jira] [Commented] (OAK-6938) Add package export version for spi.xml

2017-11-14 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251335#comment-16251335 ] Alex Deparvu commented on OAK-6938: --- no objections here > Add package export version for spi.xml >

[jira] [Created] (OAK-6940) Login token name generation is prone to race conditions

2017-11-14 Thread Alex Deparvu (JIRA)
Alex Deparvu created OAK-6940: - Summary: Login token name generation is prone to race conditions Key: OAK-6940 URL: https://issues.apache.org/jira/browse/OAK-6940 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-6928) RootFactory: deprecated method createSystemRoot lost during to m12n effort

2017-11-13 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249306#comment-16249306 ] Alex Deparvu commented on OAK-6928: --- good catch Angela! > RootFactory: deprecated method createSystemRoot

[jira] [Updated] (OAK-6867) Enable index hints on UUID lookup query

2017-11-09 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6867: -- Fix Version/s: 1.8 > Enable index hints on UUID lookup query > --- >

[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens

2017-11-08 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244179#comment-16244179 ] Alex Deparvu commented on OAK-6818: --- I think the patch looks good. To reduce excessive traversals we

[jira] [Updated] (OAK-6711) Refactor IndexConstants so it can be referenced from outside oak-core

2017-11-06 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6711: -- Fix Version/s: (was: 1.8) > Refactor IndexConstants so it can be referenced from outside oak-core >

[jira] [Assigned] (OAK-5499) IndexUpdate can do mulitple traversal of a content tree during initial index when there are sub-root indices

2017-11-06 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu reassigned OAK-5499: - Assignee: (was: Alex Deparvu) > IndexUpdate can do mulitple traversal of a content tree during

[jira] [Updated] (OAK-5499) IndexUpdate can do mulitple traversal of a content tree during initial index when there are sub-root indices

2017-11-06 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-5499: -- Fix Version/s: (was: 1.8) > IndexUpdate can do mulitple traversal of a content tree during initial

[jira] [Updated] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-11-06 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-5229: -- Fix Version/s: (was: 1.8) > Using Node.setPrimaryType() should fail if non-matching childnodes >

[jira] [Commented] (OAK-6873) UserInitializer should not use hard coded QueryIndexProvider

2017-10-27 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222008#comment-16222008 ] Alex Deparvu commented on OAK-6873: --- Patch looks good to me. > UserInitializer should not use hard coded

[jira] [Commented] (OAK-6867) Enable index hints on UUID lookup query

2017-10-26 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220263#comment-16220263 ] Alex Deparvu commented on OAK-6867: --- bq. does "lookup by getNode" run a query? It sounds not it seems

[jira] [Updated] (OAK-6867) Enable index hints on UUID lookup query

2017-10-25 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6867: -- Description: For the UUID lookup query I enabled the (recently added) query hints support where you can

[jira] [Updated] (OAK-6867) Enable index hints on UUID lookup query

2017-10-25 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6867: -- Description: For the UUID lookup query I enabled the (recently added) query hints support where you can

[jira] [Updated] (OAK-6867) Enable index hints on UUID lookup query

2017-10-25 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated OAK-6867: -- Description: For the UUID lookup query I enabled the (recently added) query hints support where you can

[jira] [Created] (OAK-6867) Enable index hints on UUID lookup query

2017-10-25 Thread Alex Deparvu (JIRA)
Alex Deparvu created OAK-6867: - Summary: Enable index hints on UUID lookup query Key: OAK-6867 URL: https://issues.apache.org/jira/browse/OAK-6867 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Commented] (OAK-6834) Make TypeEditor publically accessible and allow pluggable constraint violation handling

2017-10-19 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211027#comment-16211027 ] Alex Deparvu commented on OAK-6834: --- fixed some javadocs in http://svn.apache.org/viewvc?rev=1812639=rev

<    2   3   4   5   6   7   8   9   10   >