[jira] [Commented] (OAK-5636) potential NPE in ReplicaSetInfo

2017-02-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863754#comment-15863754 ] Stefan Egli commented on OAK-5636: -- +1, patch looks good to me > potential NPE in ReplicaSetInfo >

[jira] [Commented] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863858#comment-15863858 ] Stefan Egli commented on OAK-5619: -- Thx [~mduerig], I'll adjust the javadoc accordingly as well. >

[jira] [Updated] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5619: - Fix Version/s: (was: 1.6.1) 1.8 1.7.0 * fixed in trunk:

[jira] [Resolved] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-5619. -- Resolution: Fixed > withIncludeAncestorsRemove reports unrelated top-level node deletion >

[jira] [Updated] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-13 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5619: - Fix Version/s: 1.6.1 * merged to 1.6 branch: http://svn.apache.org/viewvc?rev=1782801=rev >

[jira] [Updated] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5619: - Summary: withIncludeAncestorsRemove reports unrelated top-level node deletion (was:

[jira] [Commented] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859414#comment-15859414 ] Stefan Egli commented on OAK-5619: -- note that this doesn't affect any unrelated node but only sharing one

[jira] [Commented] (OAK-5626) ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null

2017-02-10 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861275#comment-15861275 ] Stefan Egli commented on OAK-5626: -- I'd argue we should go for the simpler time check just around that

[jira] [Commented] (OAK-5626) ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null

2017-02-10 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861226#comment-15861226 ] Stefan Egli commented on OAK-5626: -- bq. My concern is that this would lead to almost every commit leading

[jira] [Updated] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-10 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5619: - Attachment: OAK-5619.patch2 Attached [^OAK-5619.patch2] which is the same as the previous patch but adds

[jira] [Updated] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5619: - Attachment: OAK-5619.patch Attached [^OAK-5619.patch] which contains a suggested patch. >

[jira] [Comment Edited] (OAK-5619) withIncludeAncestorsRemove reports unrelated top-level node deletion

2017-02-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859302#comment-15859302 ] Stefan Egli edited comment on OAK-5619 at 2/9/17 4:28 PM: -- Added a test case to

[jira] [Commented] (OAK-3707) Register composite commit hook with whiteboard

2016-08-16 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422659#comment-15422659 ] Stefan Egli commented on OAK-3707: -- [~edivad], what's your opinion on backporting this to 1.0.x/1.2.x

[jira] [Resolved] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

2016-08-22 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4153. -- Resolution: Fixed > segment's compareAgainstBaseState wont call childNodeDeleted when deleting > last

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

2016-08-22 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430543#comment-15430543 ] Stefan Egli commented on OAK-4153: -- [~edivad], I see what you mean, however is that really necessary as it

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-02 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458826#comment-15458826 ] Stefan Egli commented on OAK-4581: -- One more comment re bq. I expect unbounded queues to have adverse

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464458#comment-15464458 ] Stefan Egli commented on OAK-4581: -- I wouldn't rule out that there are better fits, for sure. The advantage

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464465#comment-15464465 ] Stefan Egli commented on OAK-4581: -- Waiting with further implementations until we agree on how to proceed

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1546#comment-1546 ] Stefan Egli commented on OAK-4581: -- So could we adjust the retention time dynamically (is there an API)

[jira] [Commented] (OAK-4739) lease: immediate renew after long renew call

2016-09-02 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457947#comment-15457947 ] Stefan Egli commented on OAK-4739: -- Using the _recovery lock_ we should be able to distinguish the case

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-02 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457991#comment-15457991 ] Stefan Egli commented on OAK-4581: -- [~mduerig], thanks for the comments! bq. Do we know that we need to go

[jira] [Resolved] (OAK-4728) tarmk's FileStoreBuilder.build should use mkdirs instead of mkdir

2016-08-31 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4728. -- Resolution: Fixed changed to {{mkdirs}} in http://svn.apache.org/viewvc?rev=1758610=rev > tarmk's

[jira] [Created] (OAK-4728) tarmk's FileStoreBuilder.build should use mkdirs instead of mkdir

2016-08-31 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4728: Summary: tarmk's FileStoreBuilder.build should use mkdirs instead of mkdir Key: OAK-4728 URL: https://issues.apache.org/jira/browse/OAK-4728 Project: Jackrabbit Oak

[jira] [Assigned] (OAK-4655) Enable configuring multiple segment nodestore instances in same setup

2016-08-31 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned OAK-4655: Assignee: Stefan Egli > Enable configuring multiple segment nodestore instances in same setup >

[jira] [Updated] (OAK-4655) Enable configuring multiple segment nodestore instances in same setup

2016-08-31 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4655: - Attachment: OAK-4655.v1.patch Attaching [^OAK-4655.v1.patch] which is a suggestion for a

[jira] [Updated] (OAK-4581) Persistent local journal for more reliable event generation

2016-08-31 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4581: - Attachment: OAK-4581.v0.patch Attached [^OAK-4581.v0.patch] (which bases on

[jira] [Assigned] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-12 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned OAK-4796: Assignee: Stefan Egli > filter events before adding to ChangeProcessor's queue >

[jira] [Updated] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-12 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4796: - Fix Version/s: 1.6 > filter events before adding to ChangeProcessor's queue >

[jira] [Updated] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-12 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4796: - Affects Version/s: 1.5.9 > filter events before adding to ChangeProcessor's queue >

[jira] [Created] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-12 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4796: Summary: filter events before adding to ChangeProcessor's queue Key: OAK-4796 URL: https://issues.apache.org/jira/browse/OAK-4796 Project: Jackrabbit Oak Issue

[jira] [Comment Edited] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-29 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532623#comment-15532623 ] Stefan Egli edited comment on OAK-4796 at 9/29/16 3:24 PM: --- As discussed offline

[jira] [Commented] (OAK-4898) Allow for external changes to have a CommitInfo attached

2016-10-06 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551192#comment-15551192 ] Stefan Egli commented on OAK-4898: -- +1 besides allowing the additional infos mentioned, I think we should

[jira] [Comment Edited] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-10-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548765#comment-15548765 ] Stefan Egli edited comment on OAK-4796 at 10/5/16 2:11 PM: --- bq. This is wrong. We

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-10-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548765#comment-15548765 ] Stefan Egli commented on OAK-4796: -- bq. This is wrong. We need to either do prefiltering or postfiltering

[jira] [Comment Edited] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-10-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548765#comment-15548765 ] Stefan Egli edited comment on OAK-4796 at 10/5/16 2:14 PM: --- bq. This is wrong. We

[jira] [Updated] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-10-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4796: - Attachment: OAK-4796.changeSet.patch Attaching a second variant of the patch ([^OAK-4796.changeSet.patch])

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-10-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549104#comment-15549104 ] Stefan Egli commented on OAK-4581: -- Summarizing those numerous, recent threaded comments I believe we have

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-10-06 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551799#comment-15551799 ] Stefan Egli commented on OAK-4796: -- Many thanks for this thorough review, [~chetanm]! I'll dig through them

[jira] [Updated] (OAK-4907) Collect changes (paths, nts, props..) of a commit in a validator

2016-10-10 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4907: - Attachment: OAK-4907.patch Attaching [^OAK-4907.patch] which contains mainly: * ChangeSet : the data object

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-21 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509287#comment-15509287 ] Stefan Egli commented on OAK-4581: -- /cc [~mreutegg] > Persistent local journal for more reliable event

[jira] [Assigned] (OAK-4655) Enable configuring multiple segment nodestore instances in same setup

2016-09-21 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned OAK-4655: Assignee: Tomek Rękawek (was: Stefan Egli) [~tomek.rekawek], looks good, more generic than my

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-21 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509914#comment-15509914 ] Stefan Egli commented on OAK-4581: -- One additional note: should we choose to go the I-B route (queue in

[jira] [Updated] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-19 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4796: - Attachment: OAK-4796.patch Attaching patch ([^OAK-4796.patch]) which contains the functionality as

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-21 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509153#comment-15509153 ] Stefan Egli commented on OAK-4796: -- thx for the reviews! I'd look at fixing those points. Before that would

[jira] [Commented] (OAK-4759) Queueless change processor

2016-09-20 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506601#comment-15506601 ] Stefan Egli commented on OAK-4759: -- Regarding {{ConsolidatedChanges}}: I was wondering if we could not

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-20 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506514#comment-15506514 ] Stefan Egli commented on OAK-4581: -- I'd like to move this ticket forward and believe we need a few

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-20 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506572#comment-15506572 ] Stefan Egli commented on OAK-4796: -- [~chetanm], I see, your approach is completely different. Main

[jira] [Created] (OAK-4677) stop oak-core bundle only transiently on lease failure

2016-08-17 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4677: Summary: stop oak-core bundle only transiently on lease failure Key: OAK-4677 URL: https://issues.apache.org/jira/browse/OAK-4677 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-1312) Bundle nodes into a document

2016-08-17 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424175#comment-15424175 ] Stefan Egli commented on OAK-1312: -- Suggestions for an alternative name for _bundling nodes_: * _collapse_

[jira] [Resolved] (OAK-4677) stop oak-core bundle only transiently on lease failure

2016-08-17 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4677. -- Resolution: Fixed * [fixed in trunk|http://svn.apache.org/viewvc?rev=1756584=rev] * [fixed in

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-08-29 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445633#comment-15445633 ] Stefan Egli commented on OAK-4581: -- Re {{A.1 - Serialized Root States}} I see the following options: #

[jira] [Assigned] (OAK-4581) Persistent local journal for more reliable event generation

2016-08-23 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned OAK-4581: Assignee: Stefan Egli I'll be looking at this one and will try to come up with a patch > Persistent

[jira] [Created] (OAK-4717) TarNodeStore.checkpoint methods represent endless loop

2016-08-29 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4717: Summary: TarNodeStore.checkpoint methods represent endless loop Key: OAK-4717 URL: https://issues.apache.org/jira/browse/OAK-4717 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525978#comment-15525978 ] Stefan Egli commented on OAK-4581: -- Created SLING-6070 for invoking reportChanges after child traversal

[jira] [Commented] (OAK-4855) Expose actual listener.toString in consolidated listener mbean

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525741#comment-15525741 ] Stefan Egli commented on OAK-4855: -- [~chetanm], could you pls have a look at OAK-4855 and JCR-4032? I think

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525942#comment-15525942 ] Stefan Egli commented on OAK-4581: -- * re 'maps of added/removed/changed items' : I think we might be able

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-29 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532190#comment-15532190 ] Stefan Egli commented on OAK-4581: -- [~cziegeler], so IIUC then support for these changed/added/removed

[jira] [Commented] (OAK-4859) Warn if lease update is invoked with large delay

2016-09-28 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529441#comment-15529441 ] Stefan Egli commented on OAK-4859: -- I wasn't too much aware of OAK-4770 details, good to know! So OAK-4770

[jira] [Created] (OAK-4859) Warn if lease update is invoked with large delay

2016-09-28 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4859: Summary: Warn if lease update is invoked with large delay Key: OAK-4859 URL: https://issues.apache.org/jira/browse/OAK-4859 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526714#comment-15526714 ] Stefan Egli commented on OAK-4581: -- [~cziegeler], re bq. Now, an additional reason at least for Sling was

[jira] [Comment Edited] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526714#comment-15526714 ] Stefan Egli edited comment on OAK-4581 at 9/27/16 5:02 PM: --- [~cziegeler], re bq.

[jira] [Commented] (OAK-4855) Expose actual listener.toString in consolidated listener mbean

2016-10-03 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541827#comment-15541827 ] Stefan Egli commented on OAK-4855: -- right, there's one "toString" too many. I'll wait for the next

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-26 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522996#comment-15522996 ] Stefan Egli commented on OAK-4581: -- that sounds like a new class of listener that would want

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-26 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522461#comment-15522461 ] Stefan Egli commented on OAK-4581: -- [~catholicon], thx for your feedback! Re bq. I thought this issue was

[jira] [Commented] (OAK-4581) Persistent local journal for more reliable event generation

2016-09-26 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523087#comment-15523087 ] Stefan Egli commented on OAK-4581: -- bq. 3. those observers get events post reboot Not sure that's really

[jira] [Updated] (OAK-4855) Expose actual listener.toString in consolidated listener mbean

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4855: - Attachment: OAK-4855.patch Attaching patch [^OAK-4855.patch] > Expose actual listener.toString in

[jira] [Created] (OAK-4855) Expose actual listener.toString in consolidated listener mbean

2016-09-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-4855: Summary: Expose actual listener.toString in consolidated listener mbean Key: OAK-4855 URL: https://issues.apache.org/jira/browse/OAK-4855 Project: Jackrabbit Oak

[jira] [Commented] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-09-29 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532623#comment-15532623 ] Stefan Egli commented on OAK-4796: -- As discussed offline with Marcel, I'll work on a patch for the 2nd

[jira] [Updated] (OAK-4916) Add support for excluding commits to BackgroundObserver

2016-10-10 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4916: - Attachment: OAK-4916.patch Attaching [^OAK-4916.patch] which implements the {{isExcluded}} subclass hook

[jira] [Created] (OAK-5023) add applyOnOwnNode property to OakEventFilter

2016-10-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5023: Summary: add applyOnOwnNode property to OakEventFilter Key: OAK-5023 URL: https://issues.apache.org/jira/browse/OAK-5023 Project: Jackrabbit Oak Issue Type:

[jira] [Updated] (OAK-5019) Support glob patterns through OakEventFilter

2016-10-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5019: - Description: (Originally reported as JCR-4044, but moved to Oak as a result of introducing the

[jira] [Updated] (OAK-5023) add applyOnOwnNode property to OakEventFilter

2016-10-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5023: - Description: (Originally reported as JCR-4048, but moved to Oak as a result of introducing the

[jira] [Created] (OAK-5019) Support glob patterns through OakEventFilter

2016-10-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5019: Summary: Support glob patterns through OakEventFilter Key: OAK-5019 URL: https://issues.apache.org/jira/browse/OAK-5019 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-5013) Introduce observation filter extension mechanism to Oak

2016-10-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611199#comment-15611199 ] Stefan Egli commented on OAK-5013: -- agreed, I'll adjust the wording accordingly. "write-through" was meant

[jira] [Created] (OAK-5021) Improve observation of files

2016-10-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5021: Summary: Improve observation of files Key: OAK-5021 URL: https://issues.apache.org/jira/browse/OAK-5021 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Created] (OAK-5022) add includeSubtreeOnDelete flag to OakEventFilter

2016-10-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5022: Summary: add includeSubtreeOnDelete flag to OakEventFilter Key: OAK-5022 URL: https://issues.apache.org/jira/browse/OAK-5022 Project: Jackrabbit Oak Issue Type:

[jira] [Created] (OAK-5020) Improved support for node removals

2016-10-27 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5020: Summary: Improved support for node removals Key: OAK-5020 URL: https://issues.apache.org/jira/browse/OAK-5020 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Updated] (OAK-5013) Introduce observation filter extension mechanism to Oak

2016-10-26 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5013: - Fix Version/s: 1.5.13 > Introduce observation filter extension mechanism to Oak >

[jira] [Updated] (OAK-5013) Introduce observation filter extension mechanism to Oak

2016-10-26 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-5013: - Attachment: OAK-5013.patch Attached [^OAK-5013.patch] shows a static factory and an abstract base class

[jira] [Created] (OAK-5013) Introduce observation filter extension mechanism to Oak

2016-10-26 Thread Stefan Egli (JIRA)
Stefan Egli created OAK-5013: Summary: Introduce observation filter extension mechanism to Oak Key: OAK-5013 URL: https://issues.apache.org/jira/browse/OAK-5013 Project: Jackrabbit Oak Issue

[jira] [Updated] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4908: - Fix Version/s: 1.6 > Best-effort prefiltering in ChangeProcessor based on ChangeSet >

[jira] [Updated] (OAK-4916) Add support for excluding commits to BackgroundObserver

2016-11-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4916: - Fix Version/s: 1.6 > Add support for excluding commits to BackgroundObserver >

[jira] [Updated] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-11-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4796: - Fix Version/s: 1.6 > filter events before adding to ChangeProcessor's queue >

[jira] [Updated] (OAK-4907) Collect changes (paths, nts, props..) of a commit in a validator

2016-11-09 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4907: - Fix Version/s: 1.6 > Collect changes (paths, nts, props..) of a commit in a validator >

[jira] [Commented] (OAK-5072) ChangeCollectorProvider should enable metatype support

2016-11-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639557#comment-15639557 ] Stefan Egli commented on OAK-5072: -- +1, thx, looks good (just a very minor typo fixed in 1768208) >

[jira] [Commented] (OAK-5066) Provide a config option to disable lease check at DocumentNodeStoreService level

2016-11-05 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639611#comment-15639611 ] Stefan Egli commented on OAK-5066: -- [~chetanm], shouldn't {{setLeaseCheck}} be set to true by default? I

[jira] [Commented] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-07 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646805#comment-15646805 ] Stefan Egli commented on OAK-4908: -- [~mreutegg], why are you reverting? Was just going to fix OAK-5082 >

[jira] [Commented] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646862#comment-15646862 ] Stefan Egli commented on OAK-4908: -- you mean the failing test of OAK-5082 or something else? One failing

[jira] [Commented] (OAK-5082) Test failure: testDerivedMixin(org.apache.jackrabbit.core.observation.MixinTest)

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646954#comment-15646954 ] Stefan Egli commented on OAK-5082: -- OAK-4908 is currently reverted, however a fix for OAK-5082 would have

[jira] [Updated] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4908: - Attachment: OAK-4908.v5.patch Attaching [^OAK-4908.v5.patch] which includes v4 changes by [~mreutegg], and

[jira] [Commented] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646903#comment-15646903 ] Stefan Egli commented on OAK-4908: -- unscheduling from 1.5.13 then > Best-effort prefiltering in

[jira] [Commented] (OAK-5082) Test failure: testDerivedMixin(org.apache.jackrabbit.core.observation.MixinTest)

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647174#comment-15647174 ] Stefan Egli commented on OAK-5082: -- bq. Does the ChangeSet also include mixin types? yes:

[jira] [Updated] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4908: - Priority: Major (was: Blocker) > Best-effort prefiltering in ChangeProcessor based on ChangeSet >

[jira] [Updated] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4908: - Fix Version/s: (was: 1.5.13) 1.6 > Best-effort prefiltering in ChangeProcessor based

[jira] [Commented] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647227#comment-15647227 ] Stefan Egli commented on OAK-4908: -- if integration test runs fine locally (just started now) I'd suggest to

[jira] [Resolved] (OAK-4796) filter events before adding to ChangeProcessor's queue

2016-11-07 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4796. -- Resolution: Fixed Fix Version/s: (was: 1.6) 1.5.13 sub-tasks have been

[jira] [Resolved] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-07 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4908. -- Resolution: Fixed Committed to trunk in http://svn.apache.org/viewvc?rev=1768558=rev > Best-effort

[jira] [Commented] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647389#comment-15647389 ] Stefan Egli commented on OAK-4908: -- integration tests run fine and I hope it's fine to still commit this,

[jira] [Resolved] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-4908. -- Resolution: Fixed > Best-effort prefiltering in ChangeProcessor based on ChangeSet >

[jira] [Updated] (OAK-4908) Best-effort prefiltering in ChangeProcessor based on ChangeSet

2016-11-08 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-4908: - Fix Version/s: (was: 1.6) 1.5.13 > Best-effort prefiltering in ChangeProcessor based

<    2   3   4   5   6   7   8   9   10   11   >