[jira] [Resolved] (OAK-8270) Add variant of PermissionUtil.getReadOnlyTree that never returns null

2019-04-24 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8270. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1858042. > Add variant of PermissionUtil.getRea

[jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions

2019-04-24 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825176#comment-16825176 ] angela commented on OAK-8234: - [~stillalex], looks good. regarding the test: it's now present f

[jira] [Commented] (OAK-8234) Reduce object allocation in PermissionProviderImpl for admin sessions

2019-04-24 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825325#comment-16825325 ] angela commented on OAK-8234: - [~stillalex], only saw after updating my instance that {{AllPer

[jira] [Created] (OAK-8276) OR-CompositeTreePermission.grantsPermission should loop over aggregates of supported permissions

2019-04-25 Thread angela (JIRA)
angela created OAK-8276: --- Summary: OR-CompositeTreePermission.grantsPermission should loop over aggregates of supported permissions Key: OAK-8276 URL: https://issues.apache.org/jira/browse/OAK-8276 Project: Jac

[jira] [Resolved] (OAK-8276) OR-CompositeTreePermission.grantsPermission should loop over aggregates of supported permissions

2019-04-25 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8276. - Resolution: Fixed Assignee: angela Fix Version/s: 1.14.0 Committed revision 1858099. > OR-Composi

[jira] [Created] (OAK-8281) Improve coverage for org.apache.jackrabbit.oak.security.authorization.composite

2019-04-26 Thread angela (JIRA)
angela created OAK-8281: --- Summary: Improve coverage for org.apache.jackrabbit.oak.security.authorization.composite Key: OAK-8281 URL: https://issues.apache.org/jira/browse/OAK-8281 Project: Jackrabbit Oak

[jira] [Resolved] (OAK-8281) Improve coverage for org.apache.jackrabbit.oak.security.authorization.composite

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8281. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1858190. > Improve coverage for > org.apache.j

[jira] [Updated] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8269: Attachment: OAK-8269-2.patch > Improve readability of CompositePermissionProvider and CompositeTreePermission > -

[jira] [Commented] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826929#comment-16826929 ] angela commented on OAK-8269: - [~stillalex] rebased patch with the latest fixes included; addit

[jira] [Resolved] (OAK-8263) Simplify PermissionEntry.compareTo

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8263. - Resolution: Fixed Committed revision 1858196. > Simplify PermissionEntry.compareTo >

[jira] [Resolved] (OAK-8266) Redundant check for existing tree in CompiledPermissionImpl.buildVersionDelegatee

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8266. - Resolution: Fixed Committed revision 1858199. moved the while loop to {{buildVersionDelegatee}}, which makes it obv

[jira] [Updated] (OAK-8266) Redundant check for existing tree in CompiledPermissionImpl.buildVersionDelegatee

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8266: Fix Version/s: 1.14.0 > Redundant check for existing tree in > CompiledPermissionImpl.buildVersionDelegatee > --

[jira] [Created] (OAK-8284) Improvements to EntryPredicate

2019-04-26 Thread angela (JIRA)
angela created OAK-8284: --- Summary: Improvements to EntryPredicate Key: OAK-8284 URL: https://issues.apache.org/jira/browse/OAK-8284 Project: Jackrabbit Oak Issue Type: Improvement Components:

[jira] [Updated] (OAK-8284) Improvements to EntryPredicate

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8284: Attachment: EntryPredicate.patch > Improvements to EntryPredicate > -- > >

[jira] [Commented] (OAK-8283) Make LazyValue implement Supplier

2019-04-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826975#comment-16826975 ] angela commented on OAK-8283: - [~stillalex], sounds good to me. > Make LazyValue implement Sup

[jira] [Commented] (OAK-8190) Dedicated authorization for system users

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830015#comment-16830015 ] angela commented on OAK-8190: - [~reschke], thanks a lot! > Dedicated authorization for system

[jira] [Updated] (OAK-8285) statistics the total number of documents return -1

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8285: Component/s: query > statistics the total number of documents return -1 > --

[jira] [Resolved] (OAK-8285) statistics the total number of documents return -1

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8285. - Resolution: Not A Bug works as designed and documented at http://jackrabbit.apache.org/oak/docs/query/query-engine

[jira] [Resolved] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8269. - Resolution: Fixed Fix Version/s: 1.14.0 [~stillalex], as discussed i committed the proposed changes (revisio

[jira] [Resolved] (OAK-8284) Improvements to EntryPredicate

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8284. - Resolution: Fixed Fix Version/s: 1.14.0 [~stillalex], as discussed proposed changes committed at revision 18

[jira] [Updated] (OAK-8262) CompiledPermissionImpl returns wrong type of TreePermission for child of permission store

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8262: Attachment: OAK-8262.patch > CompiledPermissionImpl returns wrong type of TreePermission for child of > permission s

[jira] [Assigned] (OAK-8262) CompiledPermissionImpl returns wrong type of TreePermission for child of permission store

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-8262: --- Assignee: angela > CompiledPermissionImpl returns wrong type of TreePermission for child of > permission stor

[jira] [Commented] (OAK-8262) CompiledPermissionImpl returns wrong type of TreePermission for child of permission store

2019-04-30 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830260#comment-16830260 ] angela commented on OAK-8262: - [~stillalex], proposed patch attached to fix this. the key probl

[jira] [Created] (OAK-8293) PrincipalProviderImpl.findPrincipals my return null values in result iterator

2019-05-02 Thread angela (JIRA)
angela created OAK-8293: --- Summary: PrincipalProviderImpl.findPrincipals my return null values in result iterator Key: OAK-8293 URL: https://issues.apache.org/jira/browse/OAK-8293 Project: Jackrabbit Oak

[jira] [Resolved] (OAK-8293) PrincipalProviderImpl.findPrincipals my return null values in result iterator

2019-05-02 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8293. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1858534. > PrincipalProviderImpl.findPrincipals

[jira] [Resolved] (OAK-8262) CompiledPermissionImpl returns wrong type of TreePermission for child of permission store

2019-05-02 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8262. - Resolution: Fixed Committed revision 1858538. > CompiledPermissionImpl returns wrong type of TreePermission for c

[jira] [Assigned] (OAK-8187) Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider and RestrictionProvider

2019-05-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-8187: --- Assignee: angela > Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider > and Restri

[jira] [Moved] (OAK-8295) Update version of jackrabbit dependency

2019-05-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela moved JCR-4432 to OAK-8295: -- Component/s: (was: parent) parent Workflow: no-reopen-closed (was: n

[jira] [Updated] (OAK-8295) Update version of jackrabbit dependency

2019-05-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8295: Fix Version/s: 1.14.0 > Update version of jackrabbit dependency > --- > >

[jira] [Updated] (OAK-8187) Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider and RestrictionProvider

2019-05-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8187: Attachment: OAK-8187.patch > Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider > and Res

[jira] [Commented] (OAK-8187) Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider and RestrictionProvider

2019-05-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832393#comment-16832393 ] angela commented on OAK-8187: - [~stillalex], proposed patch including some addition test cases.

[jira] [Resolved] (OAK-8187) Respect service ranking with AuthorizableNodeName, AuthorizableActionProvider and RestrictionProvider

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8187. - Resolution: Fixed Committed revision 1858830. > Respect service ranking with AuthorizableNodeName, AuthorizableAc

[jira] [Reopened] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reopened OAK-8269: - just noticed that {{CompositePermissionProviderOr.getPrivileges}} still contains code that is only relevant in the AND

[jira] [Resolved] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8269. - Resolution: Fixed > Improve readability of CompositePermissionProvider and CompositeTreePermission > --

[jira] [Commented] (OAK-8269) Improve readability of CompositePermissionProvider and CompositeTreePermission

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834663#comment-16834663 ] angela commented on OAK-8269: - Committed revision 1858846. > Improve readability of Composite

[jira] [Updated] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8155: Attachment: OAK-8155-test.patch OAK-8155.patch > CompositePermissionProvider: add possibility to abor

[jira] [Commented] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-07 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834745#comment-16834745 ] angela commented on OAK-8155: - [~stillalex], initial patch illustrating how this could be addre

[jira] [Created] (OAK-8304) VersionablePathHook: Diff.setVersionablePath never results in CommitFailedException

2019-05-08 Thread angela (JIRA)
angela created OAK-8304: --- Summary: VersionablePathHook: Diff.setVersionablePath never results in CommitFailedException Key: OAK-8304 URL: https://issues.apache.org/jira/browse/OAK-8304 Project: Jackrabbit Oak

[jira] [Updated] (OAK-8304) VersionablePathHook: Diff.setVersionablePath never results in CommitFailedException

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8304: Attachment: OAK-8304.patch > VersionablePathHook: Diff.setVersionablePath never results in > CommitFailedException >

[jira] [Updated] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8155: Attachment: OAK-8155-2.patch OAK-8155-2-test.patch > CompositePermissionProvider: add possibility to

[jira] [Commented] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835541#comment-16835541 ] angela commented on OAK-8155: - [~stillalex], improved patch that would only allow for abortion

[jira] [Comment Edited] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835541#comment-16835541 ] angela edited comment on OAK-8155 at 5/8/19 12:18 PM: -- [~stillalex], i

[jira] [Commented] (OAK-8306) Empty PrincipalProvider cache breaks membership collection

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835652#comment-16835652 ] angela commented on OAK-8306: - [~stillalex], patch for the fix looks good to me. with the test-

[jira] [Comment Edited] (OAK-8306) Empty PrincipalProvider cache breaks membership collection

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835652#comment-16835652 ] angela edited comment on OAK-8306 at 5/8/19 2:44 PM: - [~stillalex], pat

[jira] [Commented] (OAK-8306) Empty PrincipalProvider cache breaks membership collection

2019-05-08 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835668#comment-16835668 ] angela commented on OAK-8306: - [~stillalex] ah... i see... seems i don't recall the details

[jira] [Created] (OAK-8308) Unused Object methods in PermissionStoreEditor.AcEntry

2019-05-08 Thread angela (JIRA)
angela created OAK-8308: --- Summary: Unused Object methods in PermissionStoreEditor.AcEntry Key: OAK-8308 URL: https://issues.apache.org/jira/browse/OAK-8308 Project: Jackrabbit Oak Issue Type: Improveme

[jira] [Resolved] (OAK-8304) VersionablePathHook: Diff.setVersionablePath never results in CommitFailedException

2019-05-09 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8304. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1858994. > VersionablePathHook: Diff.setVersion

[jira] [Commented] (OAK-8240) Improve test coverage for org.apache.jackrabbit.oak.security.authorization.permission

2019-05-10 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836975#comment-16836975 ] angela commented on OAK-8240: - added a few more tests mainly for validators, commithooks at rev

[jira] [Resolved] (OAK-8308) Unused Object methods in PermissionStoreEditor.AcEntry

2019-05-10 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8308. - Resolution: Fixed Committed revision 1859063. > Unused Object methods in PermissionStoreEditor.AcEntry >

[jira] [Updated] (OAK-8308) Unused Object methods in PermissionStoreEditor.AcEntry

2019-05-10 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8308: Fix Version/s: 1.14.0 > Unused Object methods in PermissionStoreEditor.AcEntry >

[jira] [Commented] (OAK-8295) Update version of jackrabbit dependency

2019-05-10 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837009#comment-16837009 ] angela commented on OAK-8295: - done at revision 1859065. > Update version of jackrabbit depen

[jira] [Commented] (OAK-8190) Dedicated authorization for system users

2019-05-10 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837026#comment-16837026 ] angela commented on OAK-8190: - replacing {{PrincipalPolicy}} interface by Jackrabbit API at rev

[jira] [Updated] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-14 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8155: Attachment: OAK-8155-3.patch > CompositePermissionProvider: add possibility to abort evaluation > ---

[jira] [Commented] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-14 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840075#comment-16840075 ] angela commented on OAK-8155: - [~stillalex], based on our discussion last week, i created anoth

[jira] [Created] (OAK-8315) Missing nullability annotations in package o.a.j.oak.security.authentication.token

2019-05-15 Thread angela (JIRA)
angela created OAK-8315: --- Summary: Missing nullability annotations in package o.a.j.oak.security.authentication.token Key: OAK-8315 URL: https://issues.apache.org/jira/browse/OAK-8315 Project: Jackrabbit Oak

[jira] [Created] (OAK-8316) Drop userId field in TokenLoginModule

2019-05-15 Thread angela (JIRA)
angela created OAK-8316: --- Summary: Drop userId field in TokenLoginModule Key: OAK-8316 URL: https://issues.apache.org/jira/browse/OAK-8316 Project: Jackrabbit Oak Issue Type: Improvement Comp

[jira] [Updated] (OAK-8315) Missing nullability annotations in package o.a.j.oak.security.authentication.token and o.a.j.oak.spi.security.authentication.token

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8315: Summary: Missing nullability annotations in package o.a.j.oak.security.authentication.token and o.a.j.oak.spi.securi

[jira] [Updated] (OAK-8315) Missing nullability annotations in package o.a.j.oak.security.authentication.token and o.a.j.oak.spi.security.authentication.token

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8315: Component/s: security-spi > Missing nullability annotations in package > o.a.j.oak.security.authentication.token and

[jira] [Resolved] (OAK-8315) Missing nullability annotations in package o.a.j.oak.security.authentication.token and o.a.j.oak.spi.security.authentication.token

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8315. - Resolution: Fixed Assignee: angela Fix Version/s: 1.14.0 Committed revision 1859279. > Missing nu

[jira] [Updated] (OAK-8316) Drop userId field in TokenLoginModule

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8316: Attachment: OAK-8316.patch > Drop userId field in TokenLoginModule > - > >

[jira] [Assigned] (OAK-8316) Drop userId field in TokenLoginModule

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-8316: --- Assignee: angela > Drop userId field in TokenLoginModule > - > >

[jira] [Commented] (OAK-8316) Drop userId field in TokenLoginModule

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840307#comment-16840307 ] angela commented on OAK-8316: - [~stillalex], let me know in case you have any concern regarding

[jira] [Commented] (OAK-7217) check public Oak APIs for references to Guava

2019-05-15 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840310#comment-16840310 ] angela commented on OAK-7217: - [~stillalex], i am all for having an automated approach if it's

[jira] [Moved] (OAK-8320) Improve tests for o.a.j.oak.security.authentication.token package

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela moved JCR-4436 to OAK-8320: -- Component/s: (was: security) (was: core) security

[jira] [Commented] (OAK-8320) Improve tests for o.a.j.oak.security.authentication.token package

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841045#comment-16841045 ] angela commented on OAK-8320: - Committed revision 1859352. > Improve tests for o.a.j.oak.secu

[jira] [Created] (OAK-8321) Use format specifier for log output

2019-05-16 Thread angela (JIRA)
angela created OAK-8321: --- Summary: Use format specifier for log output Key: OAK-8321 URL: https://issues.apache.org/jira/browse/OAK-8321 Project: Jackrabbit Oak Issue Type: Improvement Compon

[jira] [Commented] (OAK-8321) Use format specifier for log output

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841049#comment-16841049 ] angela commented on OAK-8321: - - revision 1859353: {{TokenProviderImpl}} > Use format specifi

[jira] [Assigned] (OAK-8321) Use format specifier for log output

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-8321: --- Assignee: angela > Use format specifier for log output > --- > >

[jira] [Created] (OAK-8323) Refactor redundant checks for null in TokenValidator

2019-05-16 Thread angela (JIRA)
angela created OAK-8323: --- Summary: Refactor redundant checks for null in TokenValidator Key: OAK-8323 URL: https://issues.apache.org/jira/browse/OAK-8323 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Updated] (OAK-8323) Refactor redundant checks for null in TokenValidator

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8323: Attachment: OAK-8323.patch > Refactor redundant checks for null in TokenValidator > -

[jira] [Commented] (OAK-8323) Refactor redundant checks for null in TokenValidator

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841141#comment-16841141 ] angela commented on OAK-8323: - [~stillalex], unless you have concerns with the proposed changes

[jira] [Resolved] (OAK-8316) Drop userId field in TokenLoginModule

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8316. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1859360. > Drop userId field in TokenLoginModul

[jira] [Created] (OAK-8324) Missing NotNull annotation with AuthenticationConfiguration and LoginModuleStatsCollector

2019-05-16 Thread angela (JIRA)
angela created OAK-8324: --- Summary: Missing NotNull annotation with AuthenticationConfiguration and LoginModuleStatsCollector Key: OAK-8324 URL: https://issues.apache.org/jira/browse/OAK-8324 Project: Jackrabbi

[jira] [Resolved] (OAK-8324) Missing NotNull annotation with AuthenticationConfiguration and LoginModuleStatsCollector

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8324. - Resolution: Fixed Committed revision 1859377. > Missing NotNull annotation with AuthenticationConfiguration and

[jira] [Commented] (OAK-8326) prototype for async commits

2019-05-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841477#comment-16841477 ] angela commented on OAK-8326: - [~egli], does that mean that anybody that is able to add arbitra

[jira] [Assigned] (OAK-8227) Performance benchmarks

2019-05-17 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-8227: --- Assignee: angela > Performance benchmarks > -- > > Key: OAK-8227 >

[jira] [Resolved] (OAK-8323) Refactor redundant checks for null in TokenValidator

2019-05-17 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8323. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1859429. > Refactor redundant checks for null i

[jira] [Resolved] (OAK-8320) Improve tests for o.a.j.oak.security.authentication.token package

2019-05-17 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8320. - Resolution: Fixed Fix Version/s: 1.14.0 > Improve tests for o.a.j.oak.security.authentication.token package

[jira] [Commented] (OAK-8190) Dedicated authorization for system users

2019-05-21 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844694#comment-16844694 ] angela commented on OAK-8190: - [~reschke], if it was done, i would have resolved it. regarding

[jira] [Updated] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-24 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8155: Attachment: OAK-8155-4.patch OAK-8155-4-test.patch > CompositePermissionProvider: add possibility to

[jira] [Commented] (OAK-8155) CompositePermissionProvider: add possibility to abort evaluation

2019-05-24 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847385#comment-16847385 ] angela commented on OAK-8155: - [~stillalex], while waiting i noticed that the patch could easil

[jira] [Commented] (OAK-8227) Performance benchmarks

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475 ] angela commented on OAK-8227: - initial commit revision 1860199. > Performance benchmarks > --

[jira] [Comment Edited] (OAK-8227) Performance benchmarks

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475 ] angela edited comment on OAK-8227 at 5/28/19 8:36 AM: -- initial commit

[jira] [Comment Edited] (OAK-8227) Performance benchmarks

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475 ] angela edited comment on OAK-8227 at 5/28/19 9:30 AM: -- initial commit

[jira] [Comment Edited] (OAK-8321) Use format specifier for log output

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841049#comment-16841049 ] angela edited comment on OAK-8321 at 5/28/19 9:31 AM: -- - revision 1859

[jira] [Created] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package

2019-05-28 Thread angela (JIRA)
angela created OAK-8354: --- Summary: Fix/Add nullability annotations with o.a.j.oak.security.user package Key: OAK-8354 URL: https://issues.apache.org/jira/browse/OAK-8354 Project: Jackrabbit Oak Issue

[jira] [Resolved] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8354. - Resolution: Fixed revision 1860234 > Fix/Add nullability annotations with o.a.j.oak.security.user package > --

[jira] [Created] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException

2019-05-28 Thread angela (JIRA)
angela created OAK-8355: --- Summary: AuthorizableImpl.isEveryone should not throw RepositoryException Key: OAK-8355 URL: https://issues.apache.org/jira/browse/OAK-8355 Project: Jackrabbit Oak Issue Type

[jira] [Commented] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849634#comment-16849634 ] angela commented on OAK-8354: - [~mreutegg], yep... there are tests passing {{null}}, where the

[jira] [Updated] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-8355: Description: {{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't throw {{RepositoryException}}

[jira] [Resolved] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8354. - Resolution: Fixed revision 1860253. > Fix/Add nullability annotations with o.a.j.oak.security.user package >

[jira] [Resolved] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8355. - Resolution: Fixed Fix Version/s: 1.14.0 Committed revision 1860254. > AuthorizableImpl.isEveryone should n

[jira] [Created] (OAK-8360) UserAuthentication.authenticate: improve readability

2019-05-28 Thread angela (JIRA)
angela created OAK-8360: --- Summary: UserAuthentication.authenticate: improve readability Key: OAK-8360 URL: https://issues.apache.org/jira/browse/OAK-8360 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Resolved] (OAK-8077) how to support node type template modification and removal

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8077. - Resolution: Invalid hi [~zhouxu245], please send your questions to the mailing lists. for this particular question

[jira] [Created] (OAK-8361) Improve tests for o.a.j.oak.security.user package

2019-05-28 Thread angela (JIRA)
angela created OAK-8361: --- Summary: Improve tests for o.a.j.oak.security.user package Key: OAK-8361 URL: https://issues.apache.org/jira/browse/OAK-8361 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Resolved] (OAK-8360) UserAuthentication.authenticate: improve readability

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8360. - Resolution: Fixed Committed revision 1860270. > UserAuthentication.authenticate: improve readability > --

[jira] [Created] (OAK-8362) UserImporter: redundant check for null principals

2019-05-28 Thread angela (JIRA)
angela created OAK-8362: --- Summary: UserImporter: redundant check for null principals Key: OAK-8362 URL: https://issues.apache.org/jira/browse/OAK-8362 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Resolved] (OAK-8362) UserImporter: redundant check for null principals

2019-05-28 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8362. - Resolution: Fixed Committed revision 1860280. > UserImporter: redundant check for null principals > -

[jira] [Resolved] (OAK-8365) UserManagerImpl: unreacheable code when retrieving user/group from ID and tree

2019-05-29 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8365. - Resolution: Fixed Committed revision 1860319. > UserManagerImpl: unreacheable code when retrieving user/group fro

[jira] [Created] (OAK-8365) UserManagerImpl: unreacheable code when retrieving user/group from ID and tree

2019-05-29 Thread angela (JIRA)
angela created OAK-8365: --- Summary: UserManagerImpl: unreacheable code when retrieving user/group from ID and tree Key: OAK-8365 URL: https://issues.apache.org/jira/browse/OAK-8365 Project: Jackrabbit Oak

<    5   6   7   8   9   10   11   12   13   14   >