[jira] [Commented] (OAK-6539) Decrease version export for org.apache.jackrabbit.oak.spi.security.authentication
[
https://issues.apache.org/jira/browse/OAK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121434#comment-16121434
]
Robert Munteanu commented on OAK-6539:
--
This behaviour stems from the fact that the comparison baseline is 1.6.2, not
the highest released version.
The exported version was increased in
[r1800179|https://svn.apache.org/r1800179], so if the baseline goal would take
into account 1.7.5, there would be an error, requiring increasing the version
to 1.3.1, due to the annotation type changes. So it's probably OK to decrease
the version to 1.2.0, as we (AFAIU) have the policy of managing package version
changes only based on stable releases.
> Decrease version export for
> org.apache.jackrabbit.oak.spi.security.authentication
> -
>
> Key: OAK-6539
> URL: https://issues.apache.org/jira/browse/OAK-6539
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Trivial
>
> There's a warning when building oak-core related to the export version for
> the org.apache.jackrabbit.oak.spi.security.authentication package:
> {noformat}
> [WARNING] org.apache.jackrabbit.oak.spi.security.authentication: Excessive
> version increase; detected 1.3.0, suggested 1.2.0
> {noformat}
> I see no reason to not decrease the version. [~anchela], thoughts?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6539) Decrease version export for org.apache.jackrabbit.oak.spi.security.authentication
[
https://issues.apache.org/jira/browse/OAK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121281#comment-16121281
]
Alex Deparvu commented on OAK-6539:
---
bq. Are there @ProviderType interfaces exposed by this package? If so, I think
it's unsafe to change the version back.
yes I see a few of those in the package, but the tooling seems to disagree with
you, if we trust it to enforce version bumps up why not trust it to decrease
versions?
I guess just waiting for the code to change is also one option, but then the
same clients you mentioned that import the bigger version will again break as
they will not see the changes (new code but no new version export).
I'm open to alternatives, what needs to be done to get rid of the warning?
> Decrease version export for
> org.apache.jackrabbit.oak.spi.security.authentication
> -
>
> Key: OAK-6539
> URL: https://issues.apache.org/jira/browse/OAK-6539
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Trivial
>
> There's a warning when building oak-core related to the export version for
> the org.apache.jackrabbit.oak.spi.security.authentication package:
> {noformat}
> [WARNING] org.apache.jackrabbit.oak.spi.security.authentication: Excessive
> version increase; detected 1.3.0, suggested 1.2.0
> {noformat}
> I see no reason to not decrease the version. [~anchela], thoughts?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6539) Decrease version export for org.apache.jackrabbit.oak.spi.security.authentication
[
https://issues.apache.org/jira/browse/OAK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120101#comment-16120101
]
Robert Munteanu commented on OAK-6539:
--
Are there {{@ProviderType}} interfaces exposed by this package? If so, I think
it's unsafe to change the version back.
The reason is that if a package implements a {{@ProviderType}} interface from
this package it would import {{[1.3.0,1.4.0)}} . If we move the version back to
{{1.2.0}} then the imports would no longer resolve.
On the other hand if this version was not included in a release we can revert
it.
> Decrease version export for
> org.apache.jackrabbit.oak.spi.security.authentication
> -
>
> Key: OAK-6539
> URL: https://issues.apache.org/jira/browse/OAK-6539
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Trivial
>
> There's a warning when building oak-core related to the export version for
> the org.apache.jackrabbit.oak.spi.security.authentication package:
> {noformat}
> [WARNING] org.apache.jackrabbit.oak.spi.security.authentication: Excessive
> version increase; detected 1.3.0, suggested 1.2.0
> {noformat}
> I see no reason to not decrease the version. [~anchela], thoughts?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6539) Decrease version export for org.apache.jackrabbit.oak.spi.security.authentication
[
https://issues.apache.org/jira/browse/OAK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120087#comment-16120087
]
angela commented on OAK-6539:
-
[~stillalex], no that I was aware of... i remember that i once had a major
version bump and [~rombert] fixed that by adding provider type annotation...
but i wasn't aware of that warning. feel free to fix it, removing a warning is
always good! thanks for spotting.
> Decrease version export for
> org.apache.jackrabbit.oak.spi.security.authentication
> -
>
> Key: OAK-6539
> URL: https://issues.apache.org/jira/browse/OAK-6539
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Trivial
>
> There's a warning when building oak-core related to the export version for
> the org.apache.jackrabbit.oak.spi.security.authentication package:
> {noformat}
> [WARNING] org.apache.jackrabbit.oak.spi.security.authentication: Excessive
> version increase; detected 1.3.0, suggested 1.2.0
> {noformat}
> I see no reason to not decrease the version. [~anchela], thoughts?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
