[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784918#comment-17784918 ] Julian Reschke commented on OAK-6741: - Ah, please ignore my comment then :-). > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784916#comment-17784916 ] Manfred Baedke commented on OAK-6741: - [~reschke] , all the changes already done work with R7 as well. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784912#comment-17784912 ] Manfred Baedke commented on OAK-6741: - [~rombert] Fine, then I'll change the titles. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784914#comment-17784914 ] Julian Reschke commented on OAK-6741: - Please let's not make this more complicated than it already is :-) Can we please finish the update to R6 first? > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784910#comment-17784910 ] Robert Munteanu commented on OAK-6741: -- [~baedke] - when I created this issue OSGi R6 was the current release. I don't think we should target an old version of the annotations by default. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784909#comment-17784909 ] Manfred Baedke commented on OAK-6741: - All the sub tasks titles suggest we are switching to R6 annotations. I guess that is not deliberate, is it? R7 annotations would make it possible to use hyphens in the names of attribute definitions and e.g. oak-jcr actually uses hyphens there. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774877#comment-17774877 ] Julian Reschke commented on OAK-6741: - Potentially helpful comparison tool. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773666#comment-17773666 ] Julian Reschke commented on OAK-6741: - As far as I can tell, we can verify changes by comparing the OSGi XML config files being generated. The old felix plugin produces output in an older format though; I'll try to come up with a normalizer script that reduces the amount of diffs (cc [~cziegeler]). (and thanks to [~mreutegg] for making me aware of this) > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255303#comment-16255303 ] Marcel Reutegger commented on OAK-6741: --- I will reschedule this issue and all sub-tasks to 1.10. If anyone has time to work on these tasks feel free to assign it to you and resolve even in the 1.8 time frame. However, please be careful not to introduce regressions as there may be subtle differences. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.12 > > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226904#comment-16226904
]
Julian Sedding commented on OAK-6741:
-
I created OAK-6889 for following up on the changes done for {{oak-core}}.
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.11
>
> Attachments: OAK-6741-proposed-changes-chetans-feedback.patch,
> osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198327#comment-16198327 ] Chetan Mehrotra commented on OAK-6741: -- bq. Last week I proposed a patch to address the issues you mentioned. It would be great if you could review the changes. I'd like to commit them soon. Patch looks ok. However note that my conclusion may not be exhaustive as I did not had time to go through all difference reported in tooling. If you can run tooling at you end and validate the diff report then that would be more confirmative validation > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.10 > > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198310#comment-16198310 ] Julian Sedding commented on OAK-6741: - [~anchela] I agree with you that we need to write tests and increase coverage. Also I am very glad that you _are_ improving coverage in the areas you work. Unfortunately, just like with the first Oak release you mention, reality sometimes gets in the way. As this is a cross-cutting concern (because it's essentially tooling), it literally touches all areas of the code base. I simply cannot make enough time available to read and understand the code in all these places and improve test coverage sufficiently for this task. In an ideal world, I would have that time and then I would be happy to write the tests. In reality it was a trade off between staying with the old annotations (and thus locking us into older tooling) or updating with some risks. I made a choice, based on experiences with projects that were literally stuck on 5 year old tooling. But I can understand if you disagree with the choice I made. [~chetanm] Last week I proposed a patch to address the issues you mentioned. It would be great if you could review the changes. I'd like to commit them soon. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.10 > > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198262#comment-16198262 ] angela commented on OAK-6741: - [~jsedding], regarding writing tests: yes I expect you to do that just as you go ahead and make changes... I agree that this will take some time but nevertheless I would see this as a prerequisite. When taking over _oak-auth-external_ I would spent weeks writing proper test coverage before starting to make any kind of changes. Regarding not having tests already: yes... that's unfortunate... and due to the fact that we didn't have enough time before releasing the very first Oak version. But you probably have noticed that I heavily increased unit test-coverage for the security code base in the mean time. So... please write tests. Thanks. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.10 > > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194320#comment-16194320
]
Julian Sedding commented on OAK-6741:
-
[~stillalex] I agree that the OSGi testing situation is currently still lacking
good support.
PaxExam seems too heavy, slow and is poorly documented IMHO. Felix Connect,
which is used in {{oak-pojosr}} seems like a promising building block, but
lacks a simple testing facade. At last week's Sling Hackathon, I suggested to
use Felix Connect under the hood for Sling's {{osgi-mock}}. If that can be done
in a backwards compatible way, that might help. However, I have a feeling that
it would still not be quite enough.
Without an investment in tooling, I unfortunately don't see how we can clean up
the OSGi test situation any time soon.
Point taken and agreed about the risks. Just for the record, I didn't take them
lightly. I tried to reduce them as much as I could and I am sorry that a few
issues seem to have slipped through.
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
> Attachments: OAK-6741-proposed-changes-chetans-feedback.patch,
> osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194307#comment-16194307 ] Alex Deparvu commented on OAK-6741: --- fair enough, I got a little excited as well. My main issue is generic lack of proper support for testing in an OSGi env. I don't trust the mocks to do the right thing, and can't really keep up with what the latest is in terms of supported features. It's simply too convoluted to write tests for these bits. For me cleaning up the OSGi test situation would have been a prerequisite for this work, together with increasing code coverage. No test coverage means you are taking some interesting risks while refactoring, and I'm not convinced that's a good idea. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194303#comment-16194303
]
Julian Sedding commented on OAK-6741:
-
Thank you [~chetanm] for the list of differences. I'll try to address them
below.
bq. No 'Designate' found in
OSGI-INF/metatype/org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl$Configuration.xml
- Looks like AuthorizationConfigurationImpl does not have designate specified
Agreed, I think the {{@Designate}} annotation is required.
bq. COWNodeStoreService is having the "role" property missing. Which is required
You may be right. This component is confusing, however. Before my changes, it
did not have {{metatype = true}} set, yet it declares a property with (metatype
specific) {{label}} and {{description}}. Furthermore, it requires a
configuration before it becomes active.
This leads to a behaviour, where no configuration form is displayed in the web
console. But if you supply a configuration (e.g. via Slings' OSGi installer)
you _should_ specify the {{role}} property. If this is done, the service is
registered with such a property and it can be used for filtering.
So I believe that the component after my changes behaves as before. However, we
should clarify the intent, and possibly add a configuration annotation object
that is referenced in the {{@Designate}} annotation.
WDYT?
{quote}
DocumentNodeStoreService - Missing props
updateLimit
repository.home
role
{quote}
I think that's just a difference in processing. Possibly semantically
equivalent. The properties are all defined in the configuration annotation
object, but have no default values (as before).
bq. SecondaryStoreCacheService - immediate missing
This is just a component (does not expose a service). In that case {{immediate
= true}} is the default. Thereofore, I think it's fine.
bq. MountInfoProviderService - supportFragment missing (may be it was changed
so valid)
I didn't touch the {{oak-store-composite}} bundle with these changes.
{quote}
AuthenticationConfigurationImpl
org.apache.jackrabbit.oak.authentication.appName missing
org.apache.jackrabbit.oak.authentication.configSpiName missing
{quote}
We _may_ have lost {{appName}} if no configuration is present.
{{configSpiName}} has no default, so it should be fine if it's missing (it
should be present in the metatype).
bq. DefaultAuthorizableActionProvider - label and value swapped
Yes, this is wrong. It seems that the old annotations expected it the wrong way
around.
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
> Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194264#comment-16194264 ] Julian Sedding commented on OAK-6741: - bq. Julian Sedding you might want to check your facts before pointing the finger. we already have a test for this [0]. why this test is not failing with the changed annotation, is a different question (it's probably the test framework that does not respect the wiring, but I'm no OSGi expert). With all due respect [~stillalex], I think your quoting me out of context. As for the facts, you say yourself that the test does not fail. So we don't have a test that covers the scenario imlemented in OAK-6753. This is evident by the fact that the test was not adjusted when OAK-6753 was implemented. Anyway, we're splitting hairs. If you would like me to revert the patch, please tell me so. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194212#comment-16194212 ] Alex Deparvu commented on OAK-6741: --- bq. However, I have to wonder, why is there no test coverage for OAK-6753?! [~jsedding] you might want to check your facts before pointing the finger. we already have a test for this [0]. why this test is not failing with the changed annotation, is a different question (it's probably the test framework that does not respect the wiring, but I'm no OSGi expert). [0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/security/authentication/token/TokenConfigurationImplOSGiTest.java#L74 > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192825#comment-16192825
]
Julian Sedding commented on OAK-6741:
-
I agree that such tooling would be desirable. I created a (non-semantic) way to
compare two bundles, by diffing the generated XML. However, as Chetan also
realized, the diff would need to happen on a semantic level, because the
descriptors can look different despite identical semantics. This "noise" makes
manual diffing very error prone.
Talking with Robert, I mentioned, that I believe the semantic model may be
possible to generate using the Felix SCR and MetaType implementations. Maybe
this could be implemented in {{bnd}}'s
[{{DiffPluginImpl}}|https://github.com/bndtools/bnd/blob/master/biz.aQute.bndlib/src/aQute/bnd/differ/DiffPluginImpl.java].
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192765#comment-16192765 ] Chetan Mehrotra commented on OAK-6741: -- May be we can implement some tooling to semantically compare the generated metatype.xml before and after the change. That can pickup such issues I understand this job is touch and very manual and taxing. However risk of regression due to a mistype of config name can be high where newer code may not get right config value for existing setup leading to slight change in behaviour. And we would not be having a good suite which can check config name compatability. So having a tooling which can compare the metatype can provide a better confidence. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192752#comment-16192752 ] Robert Munteanu commented on OAK-6741: -- Well, ideally we'd have a full test suite, I agree to that. Julian and myself did run the full Oak integration test suite and smoke-tested the components in AEM and Sling. Other than that, sorry, but I can't commit to building new tests. This is the kind of soul-draining exercise of wading through unfamiliar code and trying to understand it and then map the annotations that I only do since I'd like everyone to be able to use the improved annotations :-) At any rate, now that the process is open everyone can make these changes on a per-module basis and validate that everything works as expected. Which BTW, is yet another nice thing coming out of modularizing Oak. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192671#comment-16192671
]
Julian Sedding commented on OAK-6741:
-
[~anchela] I'm sorry that I made a mistake. However, I have to wonder, why is
there no test coverage for OAK-6753?! Seriously, by your logic, I would need to
have written a complete OSGi test suite for pretty much all of {{oak-core}}.
Not quite realistic IMHO.
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192572#comment-16192572 ] angela commented on OAK-6741: - [~rombert], [~jsedding], please make sure you don't introduce regressions like OAK-6753. Maybe creating specific tests before making any modifications? Thanks. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188097#comment-16188097
]
Robert Munteanu commented on OAK-6741:
--
Well, there you have it - 19 more jira issues :-) Note that I created the tasks
based on binding a {{felix.scr.annotations}} string in the module's pom, so
there might be false positives. Now everyone is invited to join :-)
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188057#comment-16188057 ] Robert Munteanu commented on OAK-6741: -- [~stillalex] - that's a good point, I'll try and create some sub-tasks > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188055#comment-16188055 ] Robert Munteanu commented on OAK-6741: -- [~mreutegg] - I asked the same thing, and the answer is that it's not a dynamic reference, so it does not need it. See https://github.com/jsedding/jackrabbit-oak/commit/9e1dfda3dede9f7f88522ff5fe68bd71a34334f5#commitcomment-24574266 > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187790#comment-16187790
]
Marcel Reutegger commented on OAK-6741:
---
bq. Fixed for oak-core and oak-store-document in r1810002.
[~jsedding], this commit also removed the volatile modifier of the
{{nodeStore}} field in {{DocumentDiscoveryLiteService}}. If this was done on
purpose, can you please explain why this was done?
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187788#comment-16187788 ] Alex Deparvu commented on OAK-6741: --- I guess it would be clearer if you'd create subtasks for each module you want to refactor. this would also allow others to help in they were inclined to do so :) > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187776#comment-16187776 ] Robert Munteanu commented on OAK-6741: -- There are still other modules, I'm looking at oak-auth-external but looks like I picked up the most interesting one :-) We will likely pick up other modules one by one as we find the time > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187773#comment-16187773 ] Alex Deparvu commented on OAK-6741: --- I see the patch went through. is this still being worked on or could you close the issue? > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.9 > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184224#comment-16184224
]
Julian Sedding commented on OAK-6741:
-
Fixed for {{oak-core}} and {{oak-store-document}} in
[rr1810002|https://svn.apache.org/r1810002].
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
