Re: [Ocfs2-devel] [patch -next] ocfs2: scheduling in atomic in ocfs2_filecheck_store()

2015-07-27 Thread Andrew Morton
On Mon, 27 Jul 2015 11:27:23 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: We're hold spin_lock(ent-fs_fcheck-fc_lock) so the allocation has to be GFP_ATOMIC. I changed the sizeof() because otherwise the line goes over the 80 character limit and also the new way is prefered kernel

Re: [Ocfs2-devel] [patch -next] ocfs2: scheduling in atomic in ocfs2_filecheck_store()

2015-07-27 Thread Dan Carpenter
Thanks, Andrew. Looks good. regards, dan carpenter ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch -next] ocfs2: scheduling in atomic in ocfs2_filecheck_store()

2015-07-27 Thread Gang He
Hi Andrew and Dan, Thank for your efforts. It is better than before. Thanks a lot. Gang On Mon, 27 Jul 2015 11:27:23 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: We're hold spin_lock(ent-fs_fcheck-fc_lock) so the allocation has to be GFP_ATOMIC. I changed the sizeof()

[Ocfs2-devel] [patch -next] ocfs2: scheduling in atomic in ocfs2_filecheck_store()

2015-07-27 Thread Dan Carpenter
We're hold spin_lock(ent-fs_fcheck-fc_lock) so the allocation has to be GFP_ATOMIC. I changed the sizeof() because otherwise the line goes over the 80 character limit and also the new way is prefered kernel style. Fixes: e467fe5da718 ('ocfs2: sysfile interfaces for online file check')