Re: [PATCH] Add support of Huawei EM770 modem

Hi Yang, Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am|3 + plugins/huawei-em770.c | 226 plugins/ofono.rules

RE: [PATCH] Add support of Huawei EM770 modem

-Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Tuesday, March 16, 2010 2:45 PM To: ofono@ofono.org Subject: Re: [PATCH] Add support of Huawei EM770 modem Hi Yang, Comparing with general Huawei modem, EM770 is a full

[PATCH] Add support of Huawei EM770 modem

Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am |3 + plugins/em770.c | 226 +++ plugins/ofono.rules |1 + plugins/udev.c

Re: [PATCH] Add support of Huawei EM770 modem

Hi Yang, Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am |3 + plugins/em770.c | 226 +++ plugins/ofono.rules |1

[PATCH 1/4] Fix the structure of stk_subaddress

--- src/stkutil.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index b59c9f0..b408f38 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -286,7 +286,7 @@ struct stk_address { */ struct stk_subaddress { unsigned char len; -

[PATCH 2/4] Handle the conversion failure when parsing item

--- src/stkutil.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 787f7eb..ceba2d5 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -190,6 +190,7 @@ static gboolean parse_dataobj_item(struct comprehension_tlv_iter *iter,

[PATCH 2/8][RFC] Set polling interval depending on whether calls are active.

--- include/voicecall.h |2 ++ src/sim.c | 37 +++-- src/voicecall.c |5 + 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 6ceb3d8..dcce91a 100644 --- a/include/voicecall.h

[PATCH 4/8][RFC] Remove post-sim atoms after SIM is extracted.

--- src/modem.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index b935328..6dfa73a 100644 --- a/src/modem.c +++ b/src/modem.c @@ -52,6 +52,7 @@ enum ofono_property_type { struct ofono_modem {

[PATCH 5/8][RFC] STATUS, FETCH and TERMINAL RESPONSE for AT driver.

Fix ENVELOPE implementation. --- drivers/atmodem/sim.c | 286 ++--- 1 files changed, 273 insertions(+), 13 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 89ddcc6..d6f08b4 100644 --- a/drivers/atmodem/sim.c +++

[PATCH 8/8][RFC] Enable SIM polling in atgen and phonesim drivers.

--- plugins/atgen.c|6 +- plugins/phonesim.c |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/plugins/atgen.c b/plugins/atgen.c index 7e760bc..ea322fb 100644 --- a/plugins/atgen.c +++ b/plugins/atgen.c @@ -156,12 +156,16 @@ static int atgen_disable(struct

Barring API

Hi all, I had a quick peek on barring API which is currently undocumented. It seems to me that there is a good reason for it being documented as the properties by GetProperties() returned are different from the properties emitted. I kinda like the the emitted properties (VoiceIncoming and

Re: Barring API

Hi Pekka, Hi all, I had a quick peek on barring API which is currently undocumented. It seems to me that there is a good reason for it being documented as the properties by GetProperties() returned are different from the properties emitted. I kinda like the the emitted properties

Re: [PATCH 3/4] Add parser for file list objects

Hi Yang, --- src/stkutil.c | 42 ++ src/stkutil.h |6 ++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ceba2d5..9f3bc0b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -406,6

Re: [PATCH 4/4] Add parser for location information objects

Hi Yang, src/simutil.c |2 +- src/simutil.h |1 + src/stkutil.c | 40 +--- src/stkutil.h |9 + 4 files changed, 48 insertions(+), 4 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index d9383b7..65ffa36 100644 ---

Re: [PATCH 3/4] Add parser for file list objects

Hi Yang, --- src/stkutil.c | 42 ++ src/stkutil.h |6 ++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ceba2d5..9f3bc0b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -406,6

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Marcel, + if (utf8 == NULL) + return FALSE; + + item-text = utf8; Why bother with utf8 variable? Just do if (item-text == NULL) return FALSE; I actually find this acceptable because 'item' is a return structure, so we should avoid modifying

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Yang, - item-text = sim_string_to_utf8(data+1, len-1); + utf8 = sim_string_to_utf8(data+1, len-1); I applied the patch and fixed up the arithmetic operator style issue. Please make sure you follow this convention from now on. Regards, -Denis

[patch 2/6] Generic PPP control protocol

Signed-off-by: Kristen Carlson Accardi kris...@linux.intel.com Implement a generic control protocol that can be shared by both LCP and NCP implementations. --- Makefile.am |3 gatchat/gatppp_internal.h |2 gatchat/gatpppcp.c| 1509

[patch 4/6] CHAP with MD5 authentication

Signed-off-by: Kristen Carlson Accardi kris...@linux.intel.com Implement authentication support with CHAP and MD5 digest --- Makefile.am |3 gatchat/gatppp.c | 12 ++ gatchat/gatppp.h |2 gatchat/gatppp_internal.h | 15 +++ gatchat/gatpppauth.c

Re: [patch 5/6] IP support for PPP

Hi Kristen, +/** IPCP support / +enum { + /* supported codes */ + IPCP_SUPPORTED_CODES= (1 CONFIGURE_REQUEST) | + (1 CONFIGURE_ACK) | + (1 CONFIGURE_NAK) | + (1

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Denis, + if (utf8 == NULL) + return FALSE; + + item-text = utf8; Why bother with utf8 variable? Just do if (item-text == NULL) return FALSE; I actually find this acceptable because 'item' is a return structure, so we should avoid