Re: E63 as generic At Modem?

Hi, On Mon, May 31, 2010 at 4:54 PM, Aki Niemi wrote: > Hi Arun, > > 2010/5/31 Arun Ravindran : > > Hello All, > > > > I am running the latest ofono in my ubuntu 9.10, under virtual box. > > > > I have connected my E63 through USB and I can see that the isimodem up > and > > working. > > > Good

[PATCH 11/11] test-stkutil: Tests for Call Control envelope builder

--- unit/test-stkutil.c | 137 +++ 1 files changed, 137 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 4a822ef..e2157b5 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -18211,6 +18211,143 @@

[PATCH 10/11] stkutil: Add the Call Control envelope builder

--- src/stkutil.c | 175 - src/stkutil.h | 31 ++ 2 files changed, 204 insertions(+), 2 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index e5ea65a..b4466c7 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -321,8 +321,6

[PATCH 09/11] Add a "sim string" encoding utility.

Use it in sim_adn_build to support UCS2 encoded strings if GSM7 is not possible, and to avoid storing half of a double byte character at the end of the alpha identifier field. --- src/simutil.c | 25 ++--- src/util.c| 43 +++ src/

[PATCH 07/11] test-stkutil: Tests for the Menu Selection envelope builder

--- unit/test-stkutil.c | 162 +++ 1 files changed, 162 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 5410334..4a822ef 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -18066,6 +18066,151 @@

[PATCH 08/11] Add a buffer size parameter to convert_utf8_to_gsm

This is needed when encoding a string into gsm that needs to fit a in a given number of bytes. Just taking the first N bytes of the resulting string may leave you with byte 1 of a two-byte character at the end of the buffer. As far as I can tell there's no easier way to avoid that. --- src/util.

[PATCH 06/11] stkutil: Add the Menu Selection envelope builder

--- src/stkutil.c | 22 ++ src/stkutil.h |6 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 755fefd..e5ea65a 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3528,6 +3528,20 @@ static gboolean build_dataobj_ime

[PATCH 05/11] test-stkutil: Tests for CBS-PP Data Download envelope builder

--- unit/test-stkutil.c | 85 +++ 1 files changed, 85 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 681043a..5410334 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -17986,6 +17986,86 @@ s

[PATCH 04/11] stk: Use envelope encoding utility from stkutil.c

--- src/stk.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/src/stk.c b/src/stk.c index 8573d2c..143d9f3 100644 --- a/src/stk.c +++ b/src/stk.c @@ -49,6 +49,8 @@ static void stk_cbs_download_cb(const struct ofono_error *error, { if

[PATCH 03/11] stkutil: Add CBS-PP Data Download envelope builder

--- src/stkutil.c | 18 ++ src/stkutil.h |5 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index a29abfe..755fefd 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3339,6 +3339,17 @@ static gboolean build_dataobj_address(

[PATCH 02/11] test-stkutil: Tests for SMS-PP Data Download envelope builder

--- unit/test-stkutil.c | 158 +++ 1 files changed, 158 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 06d40a3..681043a 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -17838,6 +17838,154 @@

[PATCH 01/11] stkutil: Add SMS-PP Data Download envelope builder

Note that the sms_tpdu member could be of type struct sms_deliver, but the users may more often have access to the raw tpdu so there's no point decoding and reencoding it. --- src/stkutil.c | 93 + src/stkutil.h | 21 + 2 file

[PATCH, RFC] Interpret "" Alpha Id as empty data object.

There needs to be a way to distinguish between no alphaid and "empty data object" because on some occasions they have different meanings. In the Call Control envelope, no Alpha Identifier means the terminal can inform the user about the call being modified by SIM while empty data object means no h

Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

I was testing this driver with Huawei E220 modem. Here it appears in port 1 too. I just patched ofono with the following patch and it works. But I don't have a modem that appears in port 2 to test. In ModemManager [1] seems that they try to detect the second device in functions supports_device a

Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

Marcel Holtmann writes: > Hi Kalle, Hallo Marcel, >> I personally would prefer a solution which would dynamically probe the >> ports and choose them based on results. I believe modemmanager does >> something like this, but I haven't looked in detail. > > we should do something like auto-detect

Re: VS: [PATCH 09/11] Support for concatenated SMS status report. And ofono_history_sms is now updated according to received status reports.

Hi Pasi, > > I'd like to see a status_report assembly similar to how the sms_assembly > > is done. This should exist in smsutil.c/.h so that we can easily unit > > test this functionality (which I would also like to see.) > > > > Another desirable feature for the status report assembly is to save

Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

Hi Kalle, > I personally would prefer a solution which would dynamically probe the > ports and choose them based on results. I believe modemmanager does > something like this, but I haven't looked in detail. we should do something like auto-detect at some point, but there are limits in it. Regar

Re: [PATCH 1/6] Add bluetooth plugin skeleton.

Hi Kalle, > >> +#ifndef __BLUETOOTH_H > >> +#define __BLUETOOTH_H > > > > No ifdef guards please. > > I'm curious, why not? the ifdef guards are only needed for public exposed include files to protect against circular inclusion. For local headers I do want it fail if anybody attempts a circular

Re: E63 as generic At Modem?

Hi Arun, 2010/5/31 Arun Ravindran : > Hello All, > > I am running the latest ofono in my ubuntu 9.10, under virtual box. > > I have connected my E63 through USB and I can see that the isimodem up and > working. Good, are you able to make calls with it? > I tried to use E63 as a generic modem by

E63 as generic At Modem?

Hello All, I am running the latest ofono in my ubuntu 9.10, under virtual box. I have connected my E63 through USB and I can see that the isimodem up and working. --

VS: [PATCH 09/11] Support for concatenated SMS status report. And ofono_history_sms is now updated according to received status reports.

> Hi Pasi, > > > From: Pasi Miettinen > > > > --- > > include/history.h |2 + > > src/sms.c | 157 > > - src/smsutil.h > | > >6 ++ > > 3 files changed, 163 insertions(+), 2 deletions(-) > > > > Some general comments: > > I'd li

Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

Hi Florian, thank you for the patch. I'm curious, did you test ofono with Huawei E176? Did it work? Did you have any problems? Florian Steinel writes: > diff --git a/plugins/ofono.rules b/plugins/ofono.rules > index 0575362..abae06a 100644 > --- a/plugins/ofono.rules > +++ b/plugins/ofono.rule

Re: [PATCH 1/6] Add bluetooth plugin skeleton.

Denis Kenzior writes: > Hi Gustavo, Hi Denis, >> +#ifndef __BLUETOOTH_H >> +#define __BLUETOOTH_H > > No ifdef guards please. I'm curious, why not? -- Kalle Valo ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 2/2] stktest: Add negative cases for setup menu

--- unit/test-stkutil.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 7793f3a..b4a5618 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -4893,6 +4893,31 @@ sta

[PATCH 1/2] stk: Constraint the appearance of empty item

If empty item turns out, it must be the only item in the list. So the following situations are deemed as invalid: 1. Two empty items 2. Valid item + empty item 3. empty + valid item --- src/stkutil.c | 40 1 files changed, 28 insertions(+), 12 deletions(-

RE: RTNL sync or async when creating GPRS Context for STE modem.

Rémi Denis-Courmont wrote: > > I have started out by doing the RTNL handling async, > > i.e. registering the RTNL socket with g_io_add_watch etc. > > But I'm not really happy with the code as it feels > > unnecessary complex, introduces new states in gprs-context.c. etc. > > Using an event loop ma