[PATCH 4/4] Add STK Menu D-bus interface.

2010-06-16 Thread Andrzej Zaborowski
This is tested on the F3607gw only, here's a proposed api (comments welcome). The patch implements two STK commands: Menu Selection and Set Up Menu. Set Up Menu just sets up a menu from which the user can choose an option at any time, request help on an item etc, the menu can change when a new Se

[PATCH 1/4][RFC] stkutil: Refactor command parser error handling

2010-06-16 Thread Andrzej Zaborowski
When parsing the full command fails but Command Details has been parsed, return a struct stk_command containing this information and the type of parsing problem found. We need the command details to be able to even respond to the command. This patch also makes the parser skip over unknown data ob

[PATCH 3/4] stk: Handle the More Time command as a nop.

2010-06-16 Thread Andrzej Zaborowski
--- src/stk.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 1dd5b77..6138c8e 100644 --- a/src/stk.c +++ b/src/stk.c @@ -225,6 +225,15 @@ static void stk_command_handler_register(struct ofono_stk *stk, stk->handlers[type] =

[PATCH 2/4] stk: Allow registering proactive command handlers.

2010-06-16 Thread Andrzej Zaborowski
--- src/stk.c | 144 +++-- 1 files changed, 131 insertions(+), 13 deletions(-) diff --git a/src/stk.c b/src/stk.c index f472a63..1dd5b77 100644 --- a/src/stk.c +++ b/src/stk.c @@ -40,14 +40,85 @@ static GSList *g_drivers = NULL; +typed

RE: [PATCH 10/12] stk: Add parser for timing advance objects

2010-06-16 Thread Gu, Yang
Hi Andrew, >-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >andrzej zaborowski >Sent: Thursday, June 17, 2010 7:19 AM >To: ofono@ofono.org >Subject: Re: [PATCH 10/12] stk: Add parser for timing advance objects > >Hi, > >On 13 June 2010 11:43

Re: [PATCH 10/12] stk: Add parser for timing advance objects

2010-06-16 Thread andrzej zaborowski
Hi, On 13 June 2010 11:43, Yang Gu wrote: > +enum stk_me_status { > +       STK_ME_STATUS_IDLE =            0x00, > +       STK_ME_STATUS_NOT_IDLE =        0x01 > +}; > + >  /* For data object that only has a byte array with undetermined length */ >  struct stk_common_byte_array { >        unsign

Re: [PATCH 10/12] stk: Add parser for timing advance objects

2010-06-16 Thread Denis Kenzior
Hi Yang, > --- > src/stkutil.c | 22 ++ > src/stkutil.h | 28 ++-- > unit/test-stkutil.c |2 +- > 3 files changed, 41 insertions(+), 11 deletions(-) I think the patch is fine, but no longer applies. Please rebase and resubmit this

Re: [PATCH 06/12] Refactor ussd parser

2010-06-16 Thread Denis Kenzior
Aki, > --- > drivers/isimodem/ussd.c | 36 +++- > 1 files changed, 7 insertions(+), 29 deletions(-) > Please review this patch and comment on whether ISI modems can indeed support UCS2 / 8Bit data along with 7 bit packed GSM. Regards, -Denis _

Re: [PATCH 05/12] Modify ussd parser

2010-06-16 Thread Denis Kenzior
Hi Yang, > * Original code doesn't call unpack_7bit(), which seems not correct. > * An utility function is used to handle it, which supports 8-bit > and ucs2 besides 7-bit character. > * Status is assigned with correct value when error occurs Please drop this patch for now, the problem is that al

Re: [PATCH 03/12] stk: Add parser for send ussd commands

2010-06-16 Thread Denis Kenzior
Hi Yang, > +char *ussd_decode(int dcs, int len, const unsigned char *data); > Please put this function in smsutil.c/h, no need to start a brand new file for this. It is highly related to sms / cbs anyway. Regards, -Denis ___ ofono mailing list ofono

Re: [PATCH 01/12] stk: Add parser for send ss commands

2010-06-16 Thread Denis Kenzior
Hi Yang, > --- > src/stkutil.c | 70 > + src/stkutil.h | > 15 > 2 files changed, 85 insertions(+), 0 deletions(-) Patches 1-2, 7-9 and 11-12 in this series have been applied. For others, please see individual comments

Re: ATModem-PPP Doubts

2010-06-16 Thread Arun Ravindran
Hi, I could make the ppp also work, all i was giving a wrong APN name and the IPCP was failing. I have not tried the ubuntu connman, that could be my next task. Regards Arun On Wed, Jun 16, 2010 at 7:59 AM, Kalle Valo wrote: > Arun Ravindran writes: > > > 3) Currently i am stuck at the PPP

RE: The error when run the /test/list-modems script

2010-06-16 Thread Zhang, Zhenhua
Hi, Ye, First, please send plain text mail to oFono mailing list next time. Please see my reply below. Regards, Zhenhua From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Huang, Ye Sent: Monday, June 14, 2010 10:24 AM