RE: [PATCH] test: add a script for STK conformance tests

Hi Denis, -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, December 17, 2010 4:32 PM To: ofono@ofono.org Cc: Lucas, GuillaumeX Subject: Re: [PATCH] test: add a script for STK conformance tests Hi Guillaume, On 12/16/2010 10:04 AM, Lucas,

[PATCH 0/4] Emergency Calls

Steps in handling emergency calls: - subscribe to modem online notifications - emergency call detected (phone number is an emergency number) - increment emergency mode - advertise Emergency property change on D-Bus (first call) - set modem online (minimal setup) if mode was offline -

[RFC PATCH 1/3] modem: add Emergency property

--- src/dbus.c |7 ++ src/modem.c | 207 ++- src/ofono.h |5 ++ 3 files changed, 216 insertions(+), 3 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index c24615f..3be8d22 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -345,6

[RFC PATCH 3/3] voicecall: add emergency call handling

--- src/voicecall.c | 122 ++- 1 files changed, 121 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 0120cd0..370f760 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6 +52,7 @@ struct ofono_voicecall

RE: Voice call audio routing

Hi, On 16 Dec 2010, Nicola Mfb wrote: While testing an e169 huawei card I was able to make voice calls and hear something with aplay and /dev/ttyUSB1. On the openmoko/freerunner is a matter of HW switches, on the n900 IIRC is done with pulseaudio. I guess that voice call audio routing is not

Re: [PATCH] stemodem: Fix for MT call not working when caller id is hidden.

Hi Marit, I will look into that, but I would like to keep it out of this fix, and rather do it as an improvement, OK? That's fine. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] TODO: CDMA SMS and CDMA CMAS

Hi Denis, On 12/17/2010 03:29 PM, ext Denis Kenzior wrote: Hi Lei, On 12/08/2010 06:34 PM, Lei Yu wrote: --- TODO | 122 ++--- 1 files changed, 94 insertions(+), 28 deletions(-) I get the following when trying to apply this

Re: [PATCH v2 8/9] udev: Add cdmagen

Hi Marcel Thank you for reviewing these patches On 12/18/2010 10:29 AM, ext Marcel Holtmann wrote: Hi Dara, struct ofono_modem *modem; @@ -533,6 +552,8 @@ done: add_isi(modem, udev_device); else if (g_strcmp0(driver, n900) == 0) add_isi(modem,

Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device

Hi Marcel On 12/18/2010 10:31 AM, ext Marcel Holtmann wrote: Hi Dara, plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index da8a8ef..34698f0 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules

[PATCH] phonesim: Add cfis and cphs file

--- src/default.xml |8 src/simfilesystem.cpp |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/default.xml b/src/default.xml index 54c7191..4491705 100644 --- a/src/default.xml +++ b/src/default.xml @@ -3352,6 +3352,10 @@ OK/response 00 32 00 32

Re: [PATCH 1/5] cdma-sms: Add CDMA SMS Support

Hi Lei, On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am|2 +- include/cdma-sms.h | 69 include/dbus.h |4 +++ src/ofono.h|2 + Can you do me a favor and split this up into two patches? One for

Re: [PATCH 2/5] cdma-sms: Add CDMA SMS Support

On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am|3 +- src/cdma-sms.c | 342 ++ src/cdma-smsutil.c | 467 src/cdma-smsutil.h | 264 + Please break

Re: [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support

On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am|7 ++ configure.ac |5 ++ drivers/cdma-atmodem/atmodem.c | 47 drivers/cdma-atmodem/atmodem.h | 23 ++ You need to synchronize with Dara on this one. Both of you are

Re: [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

Hi Lei, On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am |9 ++ configure.ac |6 + plugins/cdmaphonesim.c| 344 + plugins/cdmaphonesim.conf | 14 ++ 4 files changed, 373 insertions(+), 0

Re: [PATCH v2 1/9] dbus: Add CDMA Voicecall Interface

Hi Dara, On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote: --- include/dbus.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH v2 2/9] types: Add CDMA Phone Number

Hi Dara, On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote: --- include/types.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index de15437..a394775 100644 --- a/include/types.h +++ b/include/types.h @@ -84,6 +84,14 @@

Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote: --- Makefile.am |2 +- include/cdma-voicecall.h | 89 ++ 2 files changed, 90 insertions(+), 1 deletions(-) create mode 100644 include/cdma-voicecall.h diff --git

Re: [PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote: --- Makefile.am |3 +- src/cdma-voicecall.c | 444 ++ src/common.c | 41 + src/common.h |6 + src/ofono.h |3 + 5 files

Re: [PATCH v2 5/9] cdmamodem: Add CDMA MO Call Support

Hi Dara, On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote: --- Makefile.am |7 ++ configure.ac |5 + drivers/cdmamodem/cdmamodem.c | 48 ++ drivers/cdmamodem/cdmamodem.h | 25 ++ Please separate this out into two patches, one for

Re: [PATCH 2/5] cdma-sms: Add CDMA SMS Support

Hi Denis, On 12/20/2010 12:36 PM, ext Denis Kenzior wrote: On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am|3 +- src/cdma-sms.c | 342 ++ src/cdma-smsutil.c | 467

Re: [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support

Hi Denis, On 12/20/2010 12:39 PM, ext Denis Kenzior wrote: On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am|7 ++ configure.ac |5 ++ drivers/cdma-atmodem/atmodem.c | 47 drivers/cdma-atmodem/atmodem.h | 23 ++ You

Re: [PATCH 1/2] set huawei em770 modem device to 01 to free up 00

Hi, On 12/10/2010 12:25 PM, F. Gau wrote: From: M. Dietrich m...@emdete.de device 00 is ppp capable while 01 is not. 01 does everything else fine so ofono works with it flawlessly. --- plugins/ofono.rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch

Re: [PATCH 2/2] fake a sim-inserted status

Hi, On 12/10/2010 12:28 PM, F. Gau wrote: From: M. Dietrich m...@emdete.de while the sim detection does not work this patch at least allows to use those modems. until someone has the time to work out a correct solution this is a usefull workaround. --- plugins/huawei.c

Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support

Hi Denis Thank you for reviewing these patches. I will submit new versions for your comments, please see any open points inline. On 12/20/2010 12:50 PM, ext Denis Kenzior wrote: + */ + +#ifndef __OFONO_CDMA_VOICECALL_H +#define __OFONO_CDMA_VOICECALL_H + +#ifdef __cplusplus +extern C {

Re: [PATCH v2 4/9] cdma-voicecall: Add CDMA MO Call Support

Hi Denis On 12/20/2010 01:01 PM, ext Denis Kenzior wrote: + +static const char *voicecall_build_path(struct ofono_cdma_voicecall_manager *vc) +{ + static char path[256]; + + snprintf(path, sizeof(path), %s/voicecall, + __ofono_atom_get_path(vc-atom)); I'm still

Re: [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

Hi Denis, On 12/20/2010 12:42 PM, ext Denis Kenzior wrote: Hi Lei, On 12/08/2010 06:35 PM, Lei Yu wrote: --- Makefile.am |9 ++ configure.ac |6 + plugins/cdmaphonesim.c| 344 + plugins/cdmaphonesim.conf

Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, + +struct ofono_cdma_voicecall_manager; Please call this ofono_cdma_voicecall. This is actually our preference as well as there is no multicall in CDMA, just the single voicecall. To that end, does it not make sense to also rename the interface Voicecall rather than

[PATCH 2/2] huawei: fix SIM state notification when locked

When SIM is locked, huawei modem does not send any notification about SIM state change because it does not differentiate 'invalid' from 'locked'. In order to be able to unlock the sim, this patch forces a notification of a valid state after a timeout. --- plugins/huawei.c | 40

Re: oFono release plan?

Hi Sjur, On 12/17/2010 10:21 AM, Sjur BRENDELAND wrote: Hi Denis and Marcel. Do you have a release plan defined for oFono? When will you release oFono 1.0? We do not have a concrete plan as of yet. For the most part we were quite happy with the current set of oFono APIs, however with

[PATCH 1/4] sim: add method to query SIM Retry Counter

--- include/sim.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..50529bb 100644 --- a/include/sim.h +++ b/include/sim.h @@ -108,6 +108,9 @@ typedef void (*ofono_sim_passwd_cb_t)(const struct ofono_error *error,

[PATCH 2/4] sim: add PinRetries property

--- src/sim.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 6217a25..8c05900 100644 --- a/src/sim.c +++ b/src/sim.c @@ -62,6 +62,8 @@ struct ofono_sim { enum ofono_sim_password_type pin_type;

[PATCH 3/4] doc: detail PinRetries property

--- doc/sim-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index d4d2b1b..c7d1faa 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -145,3 +145,13 @@ Properties boolean Present [readonly]

[PATCH 4/4] atmodem: implement method to query PIN Retry Counter

PIN retry counter is implemented for huaweimodem and it'd be very similar for other vendors. --- drivers/atmodem/sim.c | 70 + 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index

[PATCH 0/4] Add SIM Retry Counter

These patches add SIM Retry counter feature to ofono and implement it for huawei modem. I verified later the the latest version of 27.007 does has a command for querying the retry counter. This would need to be implemented as well and it's not done yet. The implementation reads only one Retry

[PATCH v2] TODO: CDMA SMS and CDMA CMAS

--- TODO | 116 ++--- 1 files changed, 89 insertions(+), 27 deletions(-) diff --git a/TODO b/TODO index d40c0ff..ee32e34 100644 --- a/TODO +++ b/TODO @@ -49,33 +49,6 @@ SMS Complexity: C1 Owner: Kristen Carlson Accardi

Re: [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

Hi Lei, Have you considered adding a CDMA/GSM selector to phonesim.conf instead? So e.g. a new configuration key called 'Type' where type can be 'gsm' or 'cdma'. That way you can share much of the phonesim plugin plumbing and only populate the atoms differently... We thought about

Re: [PATCH v2] TODO: CDMA SMS and CDMA CMAS

Hi Lei, On 12/20/2010 04:18 PM, Lei Yu wrote: --- TODO | 116 ++--- 1 files changed, 89 insertions(+), 27 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 4/5] cdmaphonesim: Add CDMA SMS Support

On 12/20/2010 02:32 PM, ext Denis Kenzior wrote: Hi Lei, Have you considered adding a CDMA/GSM selector to phonesim.conf instead? So e.g. a new configuration key called 'Type' where type can be 'gsm' or 'cdma'. That way you can share much of the phonesim plugin plumbing and only populate

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

Hi Neil, On 12/15/2010 04:12 PM, Neil Jerram wrote: Hi all, With the patch below, ofono-0.36 (the current Debian unstable version) detects the calypso modem on my freerunner. (Whereas without it, it doesn't.) We prefer if you use git send-email to format the patch for submission. For now

Re: [PATCH] Add initial support for Cinterion TC65 modem

Hi Oskari, On 12/10/2010 01:08 AM, Oskari Timperi wrote: --- Makefile.am|3 + plugins/tc65.c | 279 2 files changed, 282 insertions(+), 0 deletions(-) create mode 100644 plugins/tc65.c diff --git a/Makefile.am

[PATCH 2/2] doc: Describe DisplayAlphaId().

--- doc/stk-api.txt | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 79daee6..80d3ed6 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -249,12 +249,20 @@ Methods byte RequestSelection(string title, byte

[PATCH] sim: Set valid number length in empty EFmsisdn records.

Valid number length range is 1 - 10 bytes, other values, such as 0xff, could potentially crash external parsers. --- src/sim.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 9263e75..b98c4b2 100644 --- a/src/sim.c +++ b/src/sim.c @@ -437,6

[PATCH v3, Part1, 0/5] Add CDMA MO Call Support

This series of patches is the first part of the split of the version 2 series, concerning the changes needed to provide foundation support for cdmamodem driver and the introducing the cdma-voicecall atom. Not included in this part of the series is the cdmagen plugin for testing these changes with

[PATCH v3, Part1, 1/5] cdma-voicecall: Add CDMA MO Call Support

--- Makefile.am |2 +- include/cdma-voicecall.h | 89 ++ 2 files changed, 90 insertions(+), 1 deletions(-) create mode 100644 include/cdma-voicecall.h diff --git a/Makefile.am b/Makefile.am index 12b3c33..1270be5 100644 ---

[PATCH v3, Part1, 2/5] cdma-voicecall: Add CDMA MO Call Support

--- Makefile.am |3 +- src/cdma-voicecall.c | 430 ++ src/common.c | 41 + src/common.h |6 + src/ofono.h |3 + 5 files changed, 482 insertions(+), 1 deletions(-) create mode 100644

[PATCH v3, Part1, 3/5] cdmamodem: Add cdmamodem stubs

--- Makefile.am |6 + configure.ac |5 drivers/cdmamodem/cdmamodem.c | 45 + drivers/cdmamodem/cdmamodem.h | 22 4 files changed, 78 insertions(+), 0 deletions(-) create mode

[PATCH v3, Part1, 5/5] test: Add CDMA MO Call Support

--- Makefile.am |5 - test/cdma-dial-number | 24 test/cdma-hangup | 20 test/cdma-list-call | 30 ++ 4 files changed, 78 insertions(+), 1 deletions(-) create mode 100755

Failed to create CAIF socket for AT

Hello Sjur, Thanks for your reply. I am trying to understand CAIF protocol implementation in OFono. I am getting Failed to create CAIF socket for AT when i am trying to enable my modem. I appended below rule to 97-ofono-rules in /etc/udev. ATTRS{idVendor}==major-number,

Re: [PATCH 0/4 v2] Network Time plugin

Hi, Could someone review this patch. It has been waiting for review a while now. Thanks. -Antti On Fri, 2010-12-10 at 09:53 +0200, Antti Paila wrote: This series of patches introduces the network time part of the NITZ feature as outlined in 3GPP spec 22.042. The Network Time plugin has

Re: [PATCH 3/4] doc: detail PinRetries property

Hi Lucas, On Tue, Dec 21, 2010 at 3:26 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: --- doc/sim-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index d4d2b1b..c7d1faa 100644 --- a/doc/sim-api.txt