Re: [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type

2018-10-22 Thread Giacinto Cifelli
Hi Denis, On Mon, Oct 22, 2018 at 10:04 PM Denis Kenzior wrote: > > Hi Giacinto, > > On 10/22/2018 01:56 PM, Giacinto Cifelli wrote: > > This function converts the ofono enum ofono_gprs_auth_method > > into the value of the 3GPP 27.007 to pass to the AT command > > --- > >

[PATCH] atmodem/lte: proto and authentication handling

2018-10-22 Thread Giacinto Cifelli
The ofono_lte_default_attach_info now handles also the protocol and the authentication method, username and password. Co-authored-by: Martin Baschin --- drivers/atmodem/lte.c | 118 -- 1 file changed, 101 insertions(+), 17 deletions(-) diff --git

Re: [PATCH 2/2] atmodem/atutil: at_util_get_cgdcont_command

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/22/2018 01:56 PM, Giacinto Cifelli wrote: The function at_util_get_cgdcont_command computes the AT+CGDCONT string, as per 3GPP 27.007. It uses a second function, at_util_gprs_proto_to_pdp_type, that returns the pdp_type string for the command --- drivers/atmodem/atutil.c |

Re: [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/22/2018 01:56 PM, Giacinto Cifelli wrote: This function converts the ofono enum ofono_gprs_auth_method into the value of the 3GPP 27.007 to pass to the AT command --- drivers/atmodem/atutil.c | 16 drivers/atmodem/atutil.h | 3 +++ 2 files changed, 19

[PATCH 2/2] atmodem/atutil: at_util_get_cgdcont_command

2018-10-22 Thread Giacinto Cifelli
The function at_util_get_cgdcont_command computes the AT+CGDCONT string, as per 3GPP 27.007. It uses a second function, at_util_gprs_proto_to_pdp_type, that returns the pdp_type string for the command --- drivers/atmodem/atutil.c | 27 +++ drivers/atmodem/atutil.h | 13

[PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type

2018-10-22 Thread Giacinto Cifelli
This function converts the ofono enum ofono_gprs_auth_method into the value of the 3GPP 27.007 to pass to the AT command --- drivers/atmodem/atutil.c | 16 drivers/atmodem/atutil.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/atmodem/atutil.c

Re: airplane mode

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/22/2018 12:17 PM, Giacinto Cifelli wrote: Hi Denis, On Mon, Oct 22, 2018 at 7:02 PM Denis Kenzior wrote: Hi Giacinto, And it is fully possible to make emergency calls. Just set Online=True first. ahh, like that yes but then, wouldn't be better to create the

Re: airplane mode

2018-10-22 Thread Giacinto Cifelli
Hi Denis, On Mon, Oct 22, 2018 at 7:02 PM Denis Kenzior wrote: > > Hi Giacinto, > > >> And it is fully possible to make emergency calls. Just set Online=True > >> first. > > > > ahh, like that yes but then, wouldn't be better to create the > > voicecall atom where it belongs, in post_online

Re: [PATCH v8 4/5] atmodem/atutil: shared functions for cgdcont

2018-10-22 Thread Giacinto Cifelli
Hi Denis, ok for your comments, except ... On Mon, Oct 22, 2018 at 6:56 PM Denis Kenzior wrote: > > Hi Giacinto, > > On 10/19/2018 06:31 AM, Giacinto Cifelli wrote: > > included two new functions: > > > > at_auth_type_from_method: converts the ofono enum ofono_gprs_auth_method > > into

Re: airplane mode

2018-10-22 Thread Denis Kenzior
Hi Giacinto, And it is fully possible to make emergency calls. Just set Online=True first. ahh, like that yes but then, wouldn't be better to create the voicecall atom where it belongs, in post_online ? Or this stage is never reached without a SIM? If not, what handle we have that is

Re: huawei: network attachment unstability

2018-10-22 Thread Giacinto Cifelli
Hi Christophe, On Mon, Oct 22, 2018 at 5:33 PM Christophe Ronco wrote: > > Hi, > > I (sometimes) use a huawei USB key named MS2372h-153. > With this key, I am sometimes unable to connect. When this happens, here > is what I have in traces: > > t0) Attached to WCDMA network > t1) Switch to LTE

Re: [PATCH v8 4/5] atmodem/atutil: shared functions for cgdcont

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/19/2018 06:31 AM, Giacinto Cifelli wrote: included two new functions: at_auth_type_from_method: converts the ofono enum ofono_gprs_auth_method into the value of the 3GPP 27.007 to pass to the AT command at_get_cgdcont_command: computes the AT+CGDCONT string,

Re: airplane mode

2018-10-22 Thread Giacinto Cifelli
Hi Denis, On Mon, Oct 22, 2018 at 5:54 PM Denis Kenzior wrote: > > Hi Giacinto, > > On 10/22/2018 12:19 AM, Giacinto Cifelli wrote: > > Dear all, > > > > I have a series of problems with the ofono structure. > > When setting Powered=TRUE, it sets the module in airplane mode (AT+CFUN=4). > > > >

Re: [PATCH v8 0/5] lte atom auth and IP protocol

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/19/2018 06:31 AM, Giacinto Cifelli wrote: I would like to submit this patch for the lte atom This patch adds in core atom: - the protocol for the default LTE APN, ip, ipv6 and both - the authentication handling, with 3 properties: method, username, password then

Re: airplane mode

2018-10-22 Thread Denis Kenzior
Hi Giacinto, On 10/22/2018 12:19 AM, Giacinto Cifelli wrote: Dear all, I have a series of problems with the ofono structure. When setting Powered=TRUE, it sets the module in airplane mode (AT+CFUN=4). This prevents the use of calls, even emergency, so there would be no point in creating the

huawei: network attachment unstability

2018-10-22 Thread Christophe Ronco
Hi, I (sometimes) use a huawei USB key named MS2372h-153. With this key, I am sometimes unable to connect. When this happens, here is what I have in traces: t0) Attached to WCDMA network t1) Switch to LTE network t1+xs) Attachment loss reported t1+(x+2)s) Attached to WCDMA network t2) Switch to