Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, Thank you for the explanation. Is the glib going to be removed completely then, or both will coexist? oFono is a large project, so eradicating use of glib cannot happen overnight. For the foreseeable future we will have both coexist. I will start 'encouraging' people to

Re: [RFC PATCH] new gemalto plugin

Hi Marcel, Denis, On Wed, Oct 31, 2018 at 9:19 PM Marcel Holtmann wrote: > > Hi Giacinto, > > So you might need to expand on this some more. What is QMI+AT or > MBIM+AT actually doing? Is there a single AT port? Multiple? What is > the AT port being used for, just vendor

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, So you might need to expand on this some more. What is QMI+AT or MBIM+AT actually doing? Is there a single AT port? Multiple? What is the AT port being used for, just vendor specific APIs or something more? >>> >>> MBIM and QMI are actually used only for the

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, MBIM is not even supported through the glib, but through the ell library that is itself quite fresh (and for which there is little advantage instead of the glib. Maybe because using glib you have to listen to someone else's opinion for pushing changes). Look, I understand you're

Re: [PATCH] udev: enhance udev detection for intel 7xxx modems

Hi Nandini, On 10/31/2018 05:43 AM, Nandini Rebello wrote: Handle newer 7xxx modem enumeration based on ProductId. Preserving the previous gen support too. --- plugins/udevng.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) I fixed up some style issues and

Re: [RFC PATCH] new gemalto plugin

H Pavel, On Wed, Oct 31, 2018 at 7:03 PM Pavel Machek wrote: > > Hi! > > > > Also, there are security and interference aspects to consider. One can > > > send some AT command that interferes with the functioning of an atom > > > driver for example and then your entire system breaks. Trust me,

Re: [RFC PATCH] new gemalto plugin

Hi, On Wed, Oct 31, 2018 at 8:23 PM Denis Kenzior wrote: > > Hi Marcel, > > > > > I think that MBIM (and even QMI) have AT passthrough options. So by all > > means, the main transport suppose to be MBIM here. I always prefer if only > > one hardware port is opened and there is no need to open

Re: [RFC PATCH] new gemalto plugin

Hi Marcel, I think that MBIM (and even QMI) have AT passthrough options. So by all means, the main transport suppose to be MBIM here. I always prefer if only one hardware port is opened and there is no need to open more. I've seen QMI over MBIM some vendor extended service UIDs. Not sure

Re: [RFC PATCH] new gemalto plugin

Hi Denis, >>> So you might need to expand on this some more. What is QMI+AT or >>> MBIM+AT actually doing? Is there a single AT port? Multiple? What is >>> the AT port being used for, just vendor specific APIs or something more? >> MBIM and QMI are actually used only for the gprs-context atom.

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, So you might need to expand on this some more. What is QMI+AT or MBIM+AT actually doing? Is there a single AT port? Multiple? What is the AT port being used for, just vendor specific APIs or something more? MBIM and QMI are actually used only for the gprs-context atom. The

Re: [RFC PATCH] new gemalto plugin

Hi! > > Also, there are security and interference aspects to consider. One can > > send some AT command that interferes with the functioning of an atom > > driver for example and then your entire system breaks. Trust me, it is > > just not a good idea. If you want to shoot yourself in the

Re: [PATCH 1/3] sim800: add support for sim800 modem.

Hi all, I sent these patches 2 weeks ago and did not receive any feedback. It's not urgent at all, I was just wandering whether they'll be reviewed so I can move on :-) Regards Le lun. 15 oct. 2018 à 19:27, Clement Viel a écrit : > > --- > plugins/sim900.c | 89 >

[PATCH] udev: enhance udev detection for intel 7xxx modems

Handle newer 7xxx modem enumeration based on ProductId. Preserving the previous gen support too. --- plugins/udevng.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index 11338f7..e9f16e8 100644 ---

RE: [PATCH] udev: udpate udev to detect new 7xxx modems

Hi, Happen to spend time with old modems and validated code. Found a more cleaner approach. Please consider the next path. Regards, Nandini -Original Message- From: Giacinto Cifelli [mailto:gciof...@gmail.com] Sent: Wednesday, October 31, 2018 12:29 PM To: Rebello, Nandini Cc:

RE: [PATCH] udev: udpate udev to detect new 7xxx modems

Hi Nandini, > -Original Message- > From: ofono [mailto:ofono-boun...@ofono.org] On Behalf Of Nandini Rebello > Sent: Wednesday, October 31, 2018 12:26 PM > To: ofono@ofono.org > Cc: Borwankar, Antara ; Gargi, Anirudh > ; Rebello, Nandini > Subject: [PATCH] udev: udpate udev to detect

Re: [PATCH] udev: udpate udev to detect new 7xxx modems

Hi, On Wed, Oct 31, 2018 at 7:54 AM Nandini Rebello wrote: > > Newer intel modems enumerate with different subsystem numbers, > adding code to detect newer 7xxx modules. > > Plan to add patch for backward compatibility of intels modems soon, > to based on interface number instead of subsystem

Re: [RFC PATCH] new gemalto plugin

Hi Denis, On Tue, Oct 30, 2018 at 4:23 PM Denis Kenzior wrote: > > Hi Giacinto, > > >> So just a cursory look through this, but overall my impression is that > >> this code would be utterly unmaintainable. You need to split this up > >> into something without a bazillion if conditions and

[PATCH] udev: udpate udev to detect new 7xxx modems

Newer intel modems enumerate with different subsystem numbers, adding code to detect newer 7xxx modules. Plan to add patch for backward compatibility of intels modems soon, to based on interface number instead of subsystem name string. --- plugins/udevng.c | 4 ++-- 1 file changed, 2