Hi,
Second go on the patches for wgmodem2.5, please review.
Note that we are still working on the changes for pipe/pep and CBS, having some
problems with testing them so those patches are not updated in this set just
included to ensure no conflicts.
Cheers
Andreas
Jessica Nilsson (18):
gisi:
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
gisi/message.c |8 ++
gisi/message.h |1 +
gisi/modem.c | 20
gisi/modem.h |1 +
gisi/pep.c | 330
gisi/pep.h |6 +
gisi/pipe.c| 180
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
Makefile.am |3 +
plugins/u8500.c | 708 +++
2 files changed, 711 insertions(+), 0 deletions(-)
create mode 100644 plugins/u8500.c
diff --git a/Makefile.am b/Makefile.am
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c |1 +
drivers/isimodem/info.h |3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug.c
index c14acc2..10d0201 100644
---
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
gisi/modem.c | 22 ++
gisi/modem.h |3 +++
2 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/gisi/modem.c b/gisi/modem.c
index 7657bd1..2f5e2ae 100644
--- a/gisi/modem.c
+++ b/gisi/modem.c
@@ -70,6
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
plugins/ofono.rules |3 +++
plugins/udev.c |2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/plugins/ofono.rules b/plugins/ofono.rules
index 121825e..2e315a3 100644
--- a/plugins/ofono.rules
+++
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
src/simutil.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/simutil.h b/src/simutil.h
index a5a683b..16b210b 100644
--- a/src/simutil.h
+++ b/src/simutil.h
@@ -34,6 +34,7 @@ enum sim_fileid {
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
Makefile.am |4 +-
drivers/isimodem/debug.c | 84 +++
drivers/isimodem/debug.h |1 +
drivers/isimodem/uicc.h | 265 ++
4 files changed, 353 insertions(+), 1
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-settings.c | 711 +-
drivers/isimodem/call.h |9 +
drivers/isimodem/debug.c |4 +
drivers/isimodem/ss.h| 22 ++
4 files changed, 728
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/ussd.c | 36 ++--
1 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c
index d649484..ce402f1 100644
---
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call.h | 82 -
drivers/isimodem/voicecall.c | 218 +-
2 files changed, 253 insertions(+), 47 deletions(-)
diff --git a/drivers/isimodem/call.h
From: Jessica Nilsson jessica.j.nils...@stericsson.com
SS_GSM_BSC_INFO added.
---
drivers/isimodem/call-barring.c | 99 ++
1 files changed, 88 insertions(+), 11 deletions(-)
diff --git a/drivers/isimodem/call-barring.c b/drivers/isimodem/call-barring.c
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-forwarding.c |1 -
drivers/isimodem/ssn.c | 406 +++-
2 files changed, 401 insertions(+), 6 deletions(-)
diff --git a/drivers/isimodem/call-forwarding.c
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-forwarding.c | 29 +
1 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/drivers/isimodem/call-forwarding.c
b/drivers/isimodem/call-forwarding.c
index 89a03dc..687f975
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/sms.c | 958 +---
1 files changed, 822 insertions(+), 136 deletions(-)
diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c
index 957b342..f721684 100644
---
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c | 56 ++
drivers/isimodem/debug.h |1 +
drivers/isimodem/sms.h | 34
3 files changed, 91 insertions(+), 0 deletions(-)
diff
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/cbs.c | 414 +-
drivers/isimodem/debug.c |4 +
drivers/isimodem/sms.h |7 +-
3 files changed, 383 insertions(+), 42 deletions(-)
diff --git
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/phonebook.c | 1273 +-
1 files changed, 1243 insertions(+), 30 deletions(-)
diff --git a/drivers/isimodem/phonebook.c b/drivers/isimodem/phonebook.c
index 1f92d37..6b136b0 100644
Hi Denis,
On 2011-02-16 17:10, Denis Kenzior wrote:
Hi Andreas,
Have you thought of adapting cbs_extract_topic_ranges function for all
of this somehow?
Yes we are looking at it now.
Cheers
Andreas
___
ofono mailing list
ofono@ofono.org
Hi Aki,
On 2011-02-16 12:16, Aki Niemi wrote:
Curly brackets are either in both if and else, or in neither. I
actually prefer not to have them here, since the first line is just a
comment in the else statement. ;)
Yes you're right :)
This is not necessary, as a modem plugin is supposed to
Hi,
On 2011-02-16 15:22, Aki Niemi wrote:
Hi,
2011/2/15 Andreas Westinandreas.wes...@stericsson.com:
From: Jessica Nilssonjessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c | 56 +++
drivers/isimodem/debug.h |1 +
drivers/isimodem/sms.c | 972
On 2011-02-16 15:26, Aki Niemi wrote:
Hi,
2011/2/15 Andreas Westinandreas.wes...@stericsson.com:
+static int u8500_probe(struct ofono_modem *modem)
+{
+ const char *ifname = ofono_modem_get_string(modem, Interface);
+ unsigned address = ofono_modem_get_integer(modem, Address);
+
On 2011-02-16 16:25, Denis Kenzior wrote:
Hi Jessica,
On 02/16/2011 06:04 AM, Jessica Nilsson wrote:
---
This one was exposed when wgmodem2.5 CBS was run with valgrind.
Best Regards,
Jessica Nilsson
Can you post the actual error and the data this happened on?
src/smsutil.c |2 +-
Hi,
Valgrind complains that we step outside the allocated memory by 1 byte
since we loop the string with:
while (*topics != '\0')
the allocated memory is the size of the string and any \0 ends up
outside. At least that's my interpretation.
It might be your loop is actually going past the
Hi,
This series of patches adds wgmodem2.5 support to isimodem and provides a plugin
for the ST-Ericsson u8500 platform. I'm sending these on Jessica's behalf.
After discussions with Aki about how to handle the 2 versions of ISI we have
implemented 2 methods to handle this, first in case the
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
gisi/message.c |8 ++
gisi/message.h |1 +
gisi/modem.c | 20
gisi/modem.h |1 +
gisi/pep.c | 330
gisi/pep.h |6 +
gisi/pipe.c| 180
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
gisi/modem.c | 27 +++
gisi/modem.h |6 ++
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/gisi/modem.c b/gisi/modem.c
index 7657bd1..734c4f1 100644
--- a/gisi/modem.c
+++ b/gisi/modem.c
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c | 48 ++
drivers/isimodem/debug.h |8 +++
drivers/isimodem/mtc.h | 38
3 files changed, 94 insertions(+), 0
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
Makefile.am |3 +
plugins/u8500.c | 506 +++
2 files changed, 509 insertions(+), 0 deletions(-)
create mode 100644 plugins/u8500.c
diff --git a/Makefile.am b/Makefile.am
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c |1 +
drivers/isimodem/devinfo.c | 161
drivers/isimodem/info.h|3 +
3 files changed, 136 insertions(+), 29 deletions(-)
diff --git
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
plugins/ofono.rules |3 +++
plugins/udev.c |2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/plugins/ofono.rules b/plugins/ofono.rules
index f01b739..1090cf7 100644
--- a/plugins/ofono.rules
+++
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-settings.c | 697 +-
drivers/isimodem/call.h |9 +
drivers/isimodem/debug.c |4 +
drivers/isimodem/ss.h| 22 ++
4 files changed, 714
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/gprs-context.c | 95 +-
1 files changed, 62 insertions(+), 33 deletions(-)
diff --git a/drivers/isimodem/gprs-context.c b/drivers/isimodem/gprs-context.c
index 6d579d8..f458fcc
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call.h | 82 -
drivers/isimodem/voicecall.c | 218 +-
2 files changed, 253 insertions(+), 47 deletions(-)
diff --git a/drivers/isimodem/call.h
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/ussd.c | 36 ++--
1 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c
index d649484..abc6e09 100644
---
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-forwarding.c |1 -
drivers/isimodem/ssn.c | 382 +++-
2 files changed, 377 insertions(+), 6 deletions(-)
diff --git a/drivers/isimodem/call-forwarding.c
From: Jessica Nilsson jessica.j.nils...@stericsson.com
SS_GSM_BSC_INFO added.
---
drivers/isimodem/call-barring.c | 99 ++
1 files changed, 88 insertions(+), 11 deletions(-)
diff --git a/drivers/isimodem/call-barring.c b/drivers/isimodem/call-barring.c
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/debug.c | 56 +++
drivers/isimodem/debug.h |1 +
drivers/isimodem/sms.c | 972 +++---
drivers/isimodem/sms.h | 34 ++
4 files changed, 927 insertions(+), 136
From: Jessica Nilsson jessica.j.nils...@stericsson.com
set and clear topics support added
---
drivers/isimodem/cbs.c | 425 +-
drivers/isimodem/debug.c |4 +
drivers/isimodem/sms.h |7 +-
3 files changed, 394 insertions(+), 42 deletions(-)
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/phonebook.c | 1241 -
1 files changed, 1210 insertions(+), 31 deletions(-)
diff --git a/drivers/isimodem/phonebook.c b/drivers/isimodem/phonebook.c
index 1f92d37..dfb76ed 100644
From: Jessica Nilsson jessica.j.nils...@stericsson.com
---
drivers/isimodem/call-forwarding.c | 31 +++
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/drivers/isimodem/call-forwarding.c
b/drivers/isimodem/call-forwarding.c
index 89a03dc..74645c3
Hi Marcel,
Jessica is out of office.
On 2011-02-01 16:39, Marcel Holtmann wrote:
Hi Jessica,
plugins/udev.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
so you wanna combine the udev rule change and the udev change together
actually. They both belong together. The
42 matches
Mail list logo
