Re: [PATCH] unit: Add unit test for stemodem driver

Hi Marcel, On Mon, 2011-03-14 at 18:35 +0200, Marcel Holtmann wrote: Hi Lass,e Here is an updated version of STE unit test, originally done by Marit (sent on 15th of Feb). This one should apply smoothly one question ahead of time. Are you guys up to the task to maintain this unit

[PATCH] unit: Add unit test for stemodem driver

From: Marit Henriksen marit.henrik...@stericsson.com --- Hi, Here is an updated version of STE unit test, originally done by Marit (sent on 15th of Feb). This one should apply smoothly BR, Lasse Makefile.am | 17 +- unit/test-ste.c | 1165

[PATCH v2] ste: Add support for multiple AT channels

--- Hi, Updated according to valuable comments from Denis. BR, Lasse plugins/ste.c | 145 - 1 files changed, 92 insertions(+), 53 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index b786571..488a3e2 100644 --- a/plugins/ste.c

[PATCH] ste: Add support for multiple AT channels

--- plugins/ste.c | 138 - 1 files changed, 87 insertions(+), 51 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index b786571..9a1d3d3 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -65,13 +65,19 @@ #include

Re: [PATCH] stk: Add null pointer check

Hi, On Fri, 2011-02-25 at 19:58 +0200, Denis Kenzior wrote: Hi Andrew / Lasse, diff --git a/src/stk.c b/src/stk.c index bc46b2f..c4e988b 100644 --- a/src/stk.c +++ b/src/stk.c @@ -2514,6 +2514,7 @@ static void stk_proactive_command_cancel(struct ofono_stk *stk)

[PATCH] stk: Add null pointer check

Fixes a crash when SIM Session End is received while waiting for user response to SELECT ITEM command. --- src/stk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index bc46b2f..cda378f 100644 --- a/src/stk.c +++ b/src/stk.c @@ -115,6 +115,9 @@

Re: [PATCH] stk: Add null pointer check

Hi Andrzej, On Fri, 2011-02-25 at 14:39 +0200, Andrzej Zaborowski wrote: Hi Lasse, On 25 February 2011 11:39, Lasse Kunnasluoto lasse.kunnaslu...@tieto.com wrote: Fixes a crash when SIM Session End is received while waiting for user response to SELECT ITEM command. Can you post

Re: gatchat looses UR code if received while waiting a response

Hi Denis, On Mon, 2011-02-21 at 17:14 +0200, Denis Kenzior wrote: Hi Lasse, On 02/21/2011 05:01 AM, Lasse Kunnasluoto wrote: Hi Marcel, On Mon, 2011-02-21 at 12:04 +0200, Marcel Holtmann wrote: Hi Lasse, I've seen an issue in Unsolicited Result code handling in gatchat

gatchat looses UR code if received while waiting a response

Hi, I've seen an issue in Unsolicited Result code handling in gatchat. If ofono has sent an AT command and is waiting for a response, but modem has sent an UR code just before the AT command reached the modem, gatchat does not handle that UR code correctly (it drops it). 27.007 does not

Re: gatchat looses UR code if received while waiting a response

Hi Marcel, On Mon, 2011-02-21 at 12:04 +0200, Marcel Holtmann wrote: Hi Lasse, I've seen an issue in Unsolicited Result code handling in gatchat. If ofono has sent an AT command and is waiting for a response, but modem has sent an UR code just before the AT command reached the modem,

[PATCH] ste: Add support for CBS interface

STE modems support standard AT commands in CBS --- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 0b02a0d..cf8aed8 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -48,6 +48,7 @@ #include ofono/netreg.h #include

Re: SAT support in oFono

Hi Marcel, On Mon, 2011-01-24 at 12:49 +0200, Marcel Holtmann wrote: Hi Lasse, I am checking what is the level of SAT/STK support in ofono and have a couple of questions. The current implementation contains support for basic STK commands, like menus, inputs, calls, sms and so on.

Re: SAT support in oFono

Hi all, On Fri, 2011-01-21 at 18:13 +0200, Denis Kenzior wrote: Hi Lasse, On 01/21/2011 02:44 AM, lasse.kunnaslu...@tieto.com wrote: Hi I am checking what is the level of SAT/STK support in ofono and have a couple of questions. The current implementation contains support for basic

Re: [PATCH 1/2] atmodem: move USSD quirk to probe and use it also for STE modems

Hi Denis, On Mon, 2011-01-17 at 17:58 +0200, Denis Kenzior wrote: Hi Lasse, On 01/17/2011 02:42 AM, Lasse Kunnasluoto wrote: Hi Marcel, Supporting IRA character set is not really an option since IRA and GSM 7bit have disjoint sets of characters. The best you can really do

[PATCH] ste: Use UTF-8 as a default character set

--- plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..cc01f7b 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem) return -EIO;

Re: [PATCH] ste: Use UTF-8 as a default character set

Hi Marcel, On Tue, 2011-01-18 at 16:32 +0200, Marcel Holtmann wrote: Hi Lasse, plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..cc01f7b 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -247,7

[PATCH v2] ste: Use UTF-8 as a default character set

--- plugins/ste.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..44cfc14 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -250,6 +250,10 @@ static int ste_enable(struct ofono_modem *modem) g_at_chat_send(data-chat,

Re: [PATCH 1/2] atmodem: move USSD quirk to probe and use it also for STE modems

Hi Marcel, On Fri, 2011-01-14 at 16:20 +0200, Marcel Holtmann wrote: Hi Lasse, @@ -314,6 +305,18 @@ static int at_ussd_probe(struct ofono_ussd *ussd, unsigned int vendor, ofono_ussd_set_data(ussd, data); + switch (data-vendor) { + case OFONO_VENDOR_QUALCOMM_MSM: +

[PATCH 1/2] atmodem: move USSD quirk to probe and use it also for STE modems

Fixing issues in USSD quirk: 1) MT USSD are not handled correctly if modem uses IRA character set (change character set to GSM already in probe) 2) Responses from NW to MO USSD are not hadled as internal variable is not updated after cscs= command (Query right after setting) 3) Use the same

[PATCH 2/2] ste: Enable vendor quirk for USSD

This USSD quirk won't work for MT USSD --- plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..3ede210 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -363,7 +363,7 @@ static void ste_post_online(struct