src/stk.c: In function ‘__ofono_cbs_sim_download’:
src/stk.c:283:45: error: argument to ‘sizeof’ in ‘memcpy’ call is the
same expression as the source; did you mean to dereference it?
[-Werror=sizeof-pointer-memaccess]
memcpy(&e.cbs_pp_download.page, msg, sizeof(msg));
Automake >= 1.13 enables parallel-tests option by default which uses a
test-driver script (copied by automake). Ignore this file and the files
generated by this script.
---
.gitignore | 4
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index 91668c7..b9c23a0 100644
---
On Wed, May 22, 2013 at 6:28 PM, Lucas De Marchi
wrote:
> It's not possible to be both greater than '9' and less than '0'. This
> would lead to accepting things like "#$33#" as activation and "*$33#" as
> deactivation, even though the string
It's not possible to be both greater than '9' and less than '0'. This
would lead to accepting things like "#$33#" as activation and "*$33#" as
deactivation, even though the string makes no sense.
---
src/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common.c b/sr
Makefile.am:49: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index f802388..ee2c715 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -46,7 +46,7 @@ AM_CFLAGS = @GL
The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13.
Use AC_CONFIG_HEADERS instead.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6b5e1b1..dd8e93a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @
---
README | 6 ++
1 file changed, 6 insertions(+)
diff --git a/README b/README
index e33be69..fdfeafb 100644
--- a/README
+++ b/README
@@ -19,3 +19,9 @@ Configure automatically searches for all required components
and packages.
To compile and install run:
make && make install
+
+
src/storage.h:32:1: error: unknown type name 'ssize_t'
src/storage.h:36:1: error: unknown type name 'ssize_t'
---
src/storage.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/storage.h b/src/storage.h
index c455bae..70446ad 100644
--- a/src/storage.h
+++ b/src/storage.h
@@ -26,6 +26,7 @@
Makefile.am:518: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index ad12c0f..f24cac7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -528,7 +528,7 @@ AM_CFLAGS =
The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13.
Use AC_CONFIG_HEADERS instead.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 7db4198..a4a350f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @
src/storage.h:32:1: error: unknown type name 'ssize_t'
src/storage.h:36:1: error: unknown type name 'ssize_t'
---
src/storage.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/storage.h b/src/storage.h
index c455bae..70446ad 100644
--- a/src/storage.h
+++ b/src/storage.h
@@ -26,6 +26,7 @@
Makefile.am:518: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 40a83dc..86a1f30 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -515,7 +515,7 @@ AM_CFLAGS =
configure.ac:25: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and will
soon be removed.
configure.ac:25: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro
instead,
configure.ac:25: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your
Makefile.am files.
We were already using MKD
The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13.
Use AC_CONFIG_HEADERS instead.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 2d6247d..badbf9b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @
Makefile.am:49: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index f802388..ee2c715 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -46,7 +46,7 @@ AM_CFLAGS = @GL
The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13.
Use AC_CONFIG_HEADERS instead.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6b5e1b1..dd8e93a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @
---
README | 6 ++
1 file changed, 6 insertions(+)
diff --git a/README b/README
index e33be69..fdfeafb 100644
--- a/README
+++ b/README
@@ -19,3 +19,9 @@ Configure automatically searches for all required components
and packages.
To compile and install run:
make && make install
+
+
Now this function is only used for searching the listeners of a
connection and the other parameters are not needed anymore.
---
gdbus/watch.c | 43 +--
1 file changed, 5 insertions(+), 38 deletions(-)
diff --git a/gdbus/watch.c b/gdbus/watch.c
index 2661928
When we add a signal handler with g_dbus_add_signal_watch(), this
function tries to multiplex the matches added in libdbus by checking
if there's a previous filter_data with the same fields. However, if the
field is NULL it accepts as being the same. The result is that the
following watches will us
From: Johan Hedberg
When getting disconnected from the bus sometimes (maybe always?)
dbus_watch_handle() can cause the "info" context to be free'd meaning
that we should not try to access it after the call. The only member we
need access to is the connection pointer and as the code already has a
These patches were applied to BlueZ repository. Please, have a look and apply
them on other projects.
Johan Hedberg (1):
gdbus: Fix crash when getting disconnected from the bus
Lucas De Marchi (2):
gdbus: Fix wrong signal handler match
gdbus: Refactor filter_data_find()
gdbus/mainloop.c
t of all, please don't top-post to this list.
Applications developers don't have to parse the AT commands by
themselves but rather use a telephony stack that implements the DBus
APIs.
This is kind of an agent (as in the pairing process) that anyone
could implement. oF
---
plugins/bluetooth.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c
index cb5fe24..91c8d18 100644
--- a/plugins/bluetooth.c
+++ b/plugins/bluetooth.c
@@ -840,22 +840,25 @@ static void bluetooth_ref(void)
---
README | 9 +
1 file changed, 9 insertions(+)
diff --git a/README b/README
index 413d789..e424157 100644
--- a/README
+++ b/README
@@ -27,3 +27,12 @@ Kernel Dependencies
In order to have the PPP stack working in oFono you need to enable CONFIG_TUN
(Universal TUN/TAP device driver
---
tools/auto-enable.c | 20 ++--
tools/huawei-audio.c | 17 +
2 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/tools/auto-enable.c b/tools/auto-enable.c
index 1d5b53b..87fb0a8 100644
--- a/tools/auto-enable.c
+++ b/tools/auto-enable.c
@@ -246,7 +2
First patch is just one that was still pending locally. The other ones fix the
calls to g_dbus_add_signal_watch() to actually watch only the desired bus. It
depends on previous patch for gdbus to be applied first, otherwise libdbus may
call abort() when we exit.
Lucas De Marchi (4):
README: add
---
plugins/stemgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/stemgr.c b/plugins/stemgr.c
index 126ec4e..7e434d3 100644
--- a/plugins/stemgr.c
+++ b/plugins/stemgr.c
@@ -337,8 +337,8 @@ static gboolean property_changed(DBusConnection *connection,
static vo
;m attaching to
this email the fixed c.vim file. Replace
/usr/share/vim/vim73/syntax/c.vim with this one and highlight will be
fixed.
Regards,
Lucas De Marchi
c.vim
Description: Binary data
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
void DeleteConversation(string number)
Could we mark these as [TODO], so we don't get confused while reading
the doc + code and realizing they don't match?
Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Message signature is already checked in generic_message(), so there's no
need to check again in the callback.
---
gdbus/object.c |5 -
1 file changed, 5 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index dacbe58..2dd7c0e 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -17
---
gdbus/object.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 95947f3..dacbe58 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct
interface_data *iface
---
gdbus/object.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index fcdd6ec..95947f3 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -82,7 +82,11 @@ static void generate_interface_xml(GString *gstr, struct
interfa
---
gdbus/gdbus.h | 60
gdbus/object.c |2 +-
2 files changed, 1 insertion(+), 61 deletions(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 868c8d5..0a8a27c 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -89,8 +89,6 @@ typedef
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
---
plugins/hfp_hf.c|4 +--
plugins/push-notification.c |6 ++--
plugins/smart-messaging.c | 23 +++-
src/audio-settings.c|8 +++---
src/call-barring.c |
---
gdbus/object.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 3ac6a0b..b187bb5 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -374,6 +374,27 @@ static struct interface_data *find_interface(GSL
By using GDBusArgInfo in methods and signals, the introspection
generation is much simpler and we can add each argument name.
---
gdbus/object.c | 75 +++-
1 file changed, 14 insertions(+), 61 deletions(-)
diff --git a/gdbus/object.c b/gdbus/o
With these macro helpers we can separate in/out arguments and use their
own vector.
---
plugins/hfp_hf.c|9 +++--
plugins/push-notification.c |8 +++-
plugins/smart-messaging.c | 21 +++---
src/audio-settings.c|8 ++--
src/call-barring.c | 34
---
gdbus/gdbus.h | 102
gdbus/object.c |3 +-
2 files changed, 104 insertions(+), 1 deletion(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index e5e7938..868c8d5 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -118,6 +118,108 @@ ty
---
gdbus/gdbus.h |8
1 file changed, 8 insertions(+)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index a0583e6..e5e7938 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -85,16 +85,24 @@ typedef enum {
typedef struct {
const char *name;
const char *signature;
+} GDBu
From: Henrique Dante de Almeida
Constify signal tables with the following command:
find . -name '*.[ch]' -exec \
sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \;
---
src/audio-settings.c |2 +-
src/call-barring.c |2 +-
src/call-forwarding.c|2 +-
From: Henrique Dante de Almeida
Constify method tables with the following command:
find . -name '*.[ch]' -exec \
sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \;
---
plugins/hfp_hf.c|2 +-
plugins/push-notification.c |2 +-
plugins/smart-messaging.c |
Message signature is already checked in generic_message(), so there's no
need to check again in the callback.
---
gdbus/object.c |5 -
1 file changed, 5 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index dacbe58..2dd7c0e 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -17
---
gdbus/object.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 95947f3..dacbe58 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct
interface_data *iface
---
gdbus/object.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index fcdd6ec..95947f3 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -82,7 +82,11 @@ static void generate_interface_xml(GString *gstr, struct
interfa
---
gdbus/gdbus.h | 60
gdbus/object.c |2 +-
2 files changed, 1 insertion(+), 61 deletions(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 868c8d5..0a8a27c 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -89,8 +89,6 @@ typedef
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
---
plugins/ofono.c |4 ++--
src/service.c | 25 +++--
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/plugins/ofono.c b/plugins/ofono.c
index fcdb228..45fac91 100644
-
---
gdbus/object.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 3ac6a0b..b187bb5 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -374,6 +374,27 @@ static struct interface_data *find_interface(GSL
By using GDBusArgInfo in methods and signals, the introspection
generation is much simpler and we can add each argument name.
---
gdbus/object.c | 75 +++-
1 file changed, 14 insertions(+), 61 deletions(-)
diff --git a/gdbus/object.c b/gdbus/o
With these macro helpers we can separate in/out arguments and use their
own vector.
---
plugins/ofono.c |8 +---
src/service.c | 40 +---
2 files changed, 34 insertions(+), 14 deletions(-)
diff --git a/plugins/ofono.c b/plugins/ofono.c
index 29e8f06
---
gdbus/gdbus.h | 16
1 file changed, 16 insertions(+)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 8354633..868c8d5 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -155,6 +155,15 @@ typedef struct {
.function = _function, \
.flags = G_DBUS_METHOD_FLAG_A
---
gdbus/gdbus.h | 86
gdbus/object.c |3 +-
2 files changed, 88 insertions(+), 1 deletion(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index e5e7938..8354633 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -118,6 +118,92 @@ type
---
gdbus/gdbus.h |8
1 file changed, 8 insertions(+)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index a0583e6..e5e7938 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -85,16 +85,24 @@ typedef enum {
typedef struct {
const char *name;
const char *signature;
+} GDBu
Constify method tables with the following commands:
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusSignalTable .* =\)/\1 const \2/g' {} \;
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusMethodTable .* =\)/\1 const \2/g' {} \;
---
plugins/ofono.c |2 +-
src
Message signature is already checked in generic_message(), so there's no
need to check again in the callback.
---
gdbus/object.c |5 -
1 file changed, 5 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index dacbe58..2dd7c0e 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -17
---
gdbus/object.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 95947f3..dacbe58 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct
interface_data *iface
---
gdbus/object.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index fcdd6ec..95947f3 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -82,7 +82,11 @@ static void generate_interface_xml(GString *gstr, struct
interfa
---
gdbus/gdbus.h | 60
gdbus/object.c |2 +-
2 files changed, 1 insertion(+), 61 deletions(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 868c8d5..0a8a27c 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -89,8 +89,6 @@ typedef
Use GDBUS_* macros, so signature and reply fields are not set in each
method/signal.
---
plugins/ofono.c |4 ++--
src/service.c | 25 +++--
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/plugins/ofono.c b/plugins/ofono.c
index fcdb228..45fac91 100644
-
---
gdbus/object.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/gdbus/object.c b/gdbus/object.c
index 3ac6a0b..b187bb5 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -374,6 +374,27 @@ static struct interface_data *find_interface(GSL
By using GDBusArgInfo in methods and signals, the introspection
generation is much simpler and we can add each argument name.
---
gdbus/object.c | 75 +++-
1 file changed, 14 insertions(+), 61 deletions(-)
diff --git a/gdbus/object.c b/gdbus/o
With these macro helpers we can separate in/out arguments and use their
own vector.
---
plugins/ofono.c |8 +---
src/service.c | 40 +---
2 files changed, 34 insertions(+), 14 deletions(-)
diff --git a/plugins/ofono.c b/plugins/ofono.c
index 29e8f06
---
gdbus/gdbus.h | 16
1 file changed, 16 insertions(+)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 8354633..868c8d5 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -155,6 +155,15 @@ typedef struct {
.function = _function, \
.flags = G_DBUS_METHOD_FLAG_A
---
gdbus/gdbus.h | 86
gdbus/object.c |3 +-
2 files changed, 88 insertions(+), 1 deletion(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index e5e7938..8354633 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -118,6 +118,92 @@ type
---
gdbus/gdbus.h |8
1 file changed, 8 insertions(+)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index a0583e6..e5e7938 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -85,16 +85,24 @@ typedef enum {
typedef struct {
const char *name;
const char *signature;
+} GDBu
Constify method tables with the following commands:
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusSignalTable .* =\)/\1 const \2/g' {} \;
find . -name '*.[ch]' -exec sed -i \
's/\(c\)\(GDBusMethodTable .* =\)/\1 const \2/g' {} \;
---
plugins/ofono.c |2 +-
src
conf?
oFono uses autotools for building. If you are using the git
repository, you need to run './bootstrap && ./configure' first. Then
you'll have a Makefile.
regards,
Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
manager_tone() converts all tone chars to uppercase. Since everywhere we
check for both 'p' and 'P' for a pause, tone_queue() should also check
both before claiming the string is invalid.
---
src/voicecall.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/voicecall
---
TODO | 11 ---
doc/features.txt |8
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/TODO b/TODO
index c432cba..9db9e0b 100644
--- a/TODO
+++ b/TODO
@@ -444,17 +444,6 @@ Miscellaneous
Complexity: C8
Owner: Jukka Saunamäki
-- Add suppor
fixed also the huawei case. bluetooth.c does not
apply here since it uses its own struct cb_data and calls
g_try_new0().
regards,
Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
cb_data_new() uses g_new0(), hence there's no need to check the return
value being NULL.
---
plugins/huawei.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 6f05677..afa804d 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
cb_data_new() uses g_new0(), hence there's no need to check the return
value being NULL.
---
drivers/mbmmodem/location-reporting.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbmmodem/location-reporting.c
index b76a5c
Instead of using a GAtChat, just use a GIOChannel and close it as soon
as its fd is sent to core.
---
drivers/mbmmodem/location-reporting.c | 32 +++-
1 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbm
uint idle_source;
>> + gsize written;
>> + ofono_location_reporting_enable_cb_t cb;
>> + void *cb_data;
>> + } stream;
>> };
>
> why do you bother with the struct in struct here?
Just to group these related fields.
regards,
Lucas De Marchi
___
referred to use async calls. Hence the use of an idle callback.
regards,
Lucas De Marchi
drivers/mbmmodem/location-reporting.c | 105 +++--
1 files changed, 60 insertions(+), 45 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbmmodem/locat
---
TODO |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/TODO b/TODO
index 1275141..3735e6d 100644
--- a/TODO
+++ b/TODO
@@ -293,6 +293,7 @@ Voicecall
Priority: Medium
Complexity: C4
+ Owner: Lucas De Marchi
- Provide feedback of sent DTMF tones. Emit
---
drivers/mbmmodem/location-reporting.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbmmodem/location-reporting.c
index b671d71..24ff4b8 100644
--- a/drivers/mbmmodem/location-reporting.c
+++ b/drivers/mbmmodem/lo
Wait until driver gives us a file descriptor to start watching for
client exit. This fixes a race when client exits before the driver
calls location_reporting_enable_cb().
---
src/location-reporting.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/location-re
---
drivers/mbmmodem/location-reporting.c | 44 ++---
1 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbmmodem/location-reporting.c
index 941fac4..b671d71 100644
--- a/drivers/mbmmodem/location-reportin
Hi Denis
On Wed, Feb 23, 2011 at 9:58 PM, Denis Kenzior wrote:
> Hi Lucas,
>
> On 02/23/2011 01:49 PM, Lucas De Marchi wrote:
>> As of now there's no support for fd-passing in D-Bus Python bindings,
>> hence a small C client is needed in order to test
is sent on the tty that will contain the nmea stream, not
the control one.
> Also, what happens if the channel is hupped by the modem? Shouldn't we
> have a watch in the core for that and set Enabled accordingly?
Humn... maybe. Though client should have called Release(). Otherwise,
isn't the Release() method superfluous?
regards,
Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
As of now there's no support for fd-passing in D-Bus Python bindings,
hence a small C client is needed in order to test location-reporting
atom.
---
Makefile.am |5 +-
tools/get-location.c | 259 ++
2 files changed, 263 insertions(+), 1
Hi all,
On Wed, Feb 23, 2011 at 3:47 PM, Lucas De Marchi
wrote:
> As of now there's no support for fd-passing in D-Bus Python bindings,
> hence a small C client is needed in order to test location-reporting
> atom.
> ---
> Makefile.am | 5 +-
> tool
As of now there's no support for fd-passing in D-Bus Python bindings,
hence a small C client is needed in order to test location-reporting
atom.
---
Makefile.am |5 +-
tools/get-location.c | 259 ++
2 files changed, 263 insertions(+), 1
From: Rafael Ignacio Zurita
---
Makefile.am |2 +-
src/location-reporting.c | 393 ++
src/ofono.h |2 +
3 files changed, 396 insertions(+), 1 deletions(-)
create mode 100644 src/location-reporting.c
diff --git a/Mak
From: Rafael Ignacio Zurita
---
Makefile.am|3 ++-
doc/location-reporting-api.txt | 39 +++
2 files changed, 41 insertions(+), 1 deletions(-)
create mode 100644 doc/location-reporting-api.txt
diff --git a/Makefile.am b/Makefile.am
i
From: Rafael Ignacio Zurita
---
plugins/udev.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/plugins/udev.c b/plugins/udev.c
index 84478d7..aa5702e 100644
--- a/plugins/udev.c
+++ b/plugins/udev.c
@@ -105,7 +105,7 @@ static void add_mbm(struct ofono_modem *modem,
From: Rafael Ignacio Zurita
---
plugins/mbm.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/plugins/mbm.c b/plugins/mbm.c
index 2ab80b4..105843f 100644
--- a/plugins/mbm.c
+++ b/plugins/mbm.c
@@ -46,6 +46,7 @@
#include
#include
#include
+#include
#incl
From: Rafael Ignacio Zurita
---
Makefile.am |3 +-
drivers/mbmmodem/location-reporting.c | 247 +
drivers/mbmmodem/mbmmodem.c |2 +
drivers/mbmmodem/mbmmodem.h |3 +
4 files changed, 254 insertions(+), 1 d
From: Rafael Ignacio Zurita
---
Makefile.am |3 +-
include/location-reporting.h | 81 ++
2 files changed, 83 insertions(+), 1 deletions(-)
create mode 100644 include/location-reporting.h
diff --git a/Makefile.am b/Makefile.am
index
From: Lucas De Marchi
This is the 4th version of the location-reporting patches (previous title was
"Add GPS atom"). I worked with Rafael Ignacio Zurita to implement this last
version, making some changes in order to fit the new design as discussed on irc.
Now when a client calls
tx_next() must never be called with entry == NULL and currently it
was already being dereferenced before making this check. Thus just
remove it.
---
src/sms.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index 212a470..be7132a5 100644
--- a/src/s
---
doc/messagemanager-api.txt | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/doc/messagemanager-api.txt b/doc/messagemanager-api.txt
index 0723e9c..29453c3 100644
--- a/doc/messagemanager-api.txt
+++ b/doc/messagemanager-api.txt
@@ -32,6 +32,18 @@ Methods
---
TODO |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/TODO b/TODO
index 13a6baa..8790209 100644
--- a/TODO
+++ b/TODO
@@ -31,15 +31,6 @@ SMS
Priority: Low
Complexity: C8
-- See / Cancel pending SMS messages over DBus. When oFono sends SMS messages
- th
Based on patch from Yang Gu
---
src/sms.c | 88 +
1 files changed, 88 insertions(+), 0 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index dfec456..212a470 100644
--- a/src/sms.c
+++ b/src/sms.c
@@ -685,6 +685,8 @@ static gboolean t
Refactor tx_finished() and create a function to remove an entry from the
tx queue. This function will be used also when a message is cancelled.
Thus, handle the case in which state is MESSAGE_STATE_CANCELLED as well.
Based on patch from Yang Gu
---
src/sms.c | 105 ++
Based on patch from Yang Gu
---
src/message.c |2 ++
src/message.h |3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/message.c b/src/message.c
index eb85adf..668a693 100644
--- a/src/message.c
+++ b/src/message.c
@@ -46,6 +46,8 @@ static const char *message_state_
---
examples/history.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/examples/history.c b/examples/history.c
index 0a1e8d7..21668ec 100644
--- a/examples/history.c
+++ b/examples/history.c
@@ -172,6 +172,11 @@ static void example_history_sms_send_status(
Based on patch from Yang Gu
---
include/history.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/history.h b/include/history.h
index c1c4aa1..756097e 100644
--- a/include/history.h
+++ b/include/history.h
@@ -35,6 +35,7 @@ enum ofono_history_sms_status {
for a certain period.
Lucas De Marchi (8):
history: add cancelled status
examples: handle cancelled history status
message: add cancelled state
sms: factor out 'remove entry' from tx_finished()
sms: allow message submission to be cancelled
doc: add CancelMessage to MessageMana
Hi Andrzej,
On Fri, Feb 4, 2011 at 1:58 PM, andrzej zaborowski wrote:
> Hi,
>
> On 4 February 2011 16:02, Lucas De Marchi
> wrote:
>> Based on patch from Yang Gu
>> ---
>> src/sms.c | 82
>>
1 - 100 of 309 matches
Mail list logo