Hi Sean,
What do you think about this: [0]
In attr_cb() the +10 to attr pointer I need to do better.
While looking at the code, in attr_cb() do we leak the attr string? I
can't find where it's free'd :)
No, the string is declared as const char in both attr_cb and
at_util_parse_attr(). So
On Tue, Dec 07, 2021 at 09:43:47AM -0600, Denis Kenzior wrote:
> Hi Sean,
>
> > Good plan :)
> > I have been looking at it. [0]
>
> Yep, that looks like a good start.
>
> >
> > Should I catch the callback directly in atmodem/devinfo.c instead?
>
> You could try to intercept this in attr_cb
Hi Sean,
Good plan :)
I have been looking at it. [0]
Yep, that looks like a good start.
Should I catch the callback directly in atmodem/devinfo.c instead?
You could try to intercept this in attr_cb itself. But you'd need access to
vendor selector somehow. Perhaps a custom data
On Mon, Dec 06, 2021 at 10:45:35AM -0600, Denis Kenzior wrote:
> Hi Sean,
>
> On 12/6/21 3:50 AM, Sean Nyekjaer wrote:
> > Quectel devices returns "Revision:" before the manufacture and revision.
> > Via dbus:
> > "Manufacturer" s "Revision: MTK 0828"
> > "Revision" s "Revision: M95FAR02A08"
> >
Hi Sean,
On 12/6/21 3:50 AM, Sean Nyekjaer wrote:
Quectel devices returns "Revision:" before the manufacture and revision.
Via dbus:
"Manufacturer" s "Revision: MTK 0828"
"Revision" s "Revision: M95FAR02A08"
---
plugins/quectel.c | 2 ++
1 file changed, 2 insertions(+)
Applied. But you
Quectel devices returns "Revision:" before the manufacture and revision.
Via dbus:
"Manufacturer" s "Revision: MTK 0828"
"Revision" s "Revision: M95FAR02A08"
---
plugins/quectel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/plugins/quectel.c b/plugins/quectel.c
index 5d3ad470..2fd820a5
