RE: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-11 Thread Marcel Holtmann
Hi Waldo, I asked this 3 times now, where is this magic value of 10 seconds coming from. What is the average expected execution time of each test? Typical response times are much less than 0.5 sec. 10 seconds is considered much longer than any normal response time. that was the answer

RE: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-06 Thread Bastian, Waldo
plugins/ifx.c | 76 +--- 1 files changed, 66 insertions(+), 10 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index c0a69c2..e0eb982 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -71,6 +71,8 @@ #define

RE: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-06 Thread Robertino Benis
Hi, The IFX modem we are targetting implements this with two AT commands. Another question that I did ask is to see some sample results from these test cases in failure and success case. Robertino? I think you meant except form the log, such as this: ofonod[1342]: Using multiplexer

Re: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-05 Thread Marcel Holtmann
Hi Robertino, This is another attempt to submit a patch that triggers Infineon modem selftest during ofono boot. Patch addresses issues raised by Marcel from the previous submissions. --- as a general comment, changelogs and notes for the reviewer have to between --- and the diffstat. They