[PATCH 2/3] Add server send result code

2010-03-29 Thread Zhenhua Zhang
--- gatchat/gatserver.c | 98 --- gatchat/gatserver.h | 17 + 2 files changed, 102 insertions(+), 13 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 07999a8..cad9d91 100644 --- a/gatchat/gatserver.c +++

[PATCH 3/3] Add flag to parse one command line at once

2010-03-29 Thread Zhenhua Zhang
--- gatchat/gatserver.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index cad9d91..251c3b8 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -116,6 +116,7 @@ struct _GAtServer { gboolean destroyed;

[PATCH 6/9] Add parser for transaction identifier objects

2010-03-29 Thread Yang Gu
--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3aae6bf..d573430 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -748,6 +748,14 @@ static gboolean parse_dataobj_location_status(

[PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread ppessi
From: Pekka Pessi pekka.pe...@nokia.com Add support for lock codes AG and AC (MMI codes 333 and 353, respectively). Use decimal MMI codes in ss.h. --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread Pekka Pessi
2010/3/23 Denis Kenzior denk...@gmail.com: Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). First of all, please keep your commit messages less than 72 characters long and headings less than 50 characters long. Is there any git setting or nice filter which could

Re: Access to SIM card when Modem is not Powered

2010-03-29 Thread Pekka Pessi
Hi denis, 2010/3/19 Denis Kenzior denk...@gmail.com: I've been talking about this exact issue with Marcel but so far we have not firmly agreed on any solution.  Our current thinking is to keep Powered semantics as they are, but to also add Flight mode property.  This would in affect allow

RE: Access to SIM card when Modem is not Powered

2010-03-29 Thread Bastian, Waldo
Pekka Pessi wrote: I've been porting the N900 modem control code to oFono. The semantics of Powered is fine with respect of the atoms, in other words, if the modem crashes and boots itself, all the atoms are flushed nicely. When powering up, the Powered can be set to true when the modem is

Re: Access to SIM card when Modem is not Powered

2010-03-29 Thread Denis Kenzior
Hi Pekka, However, then powering modem down, there are problems. The N900 modem control needs to make difference between the state where the modem is no more useful and the safe-to-exit state when the power off request has been completed, modem has flushed its state to flash and given some

Re: [PATCH 1/3] Refactor the command parsing

2010-03-29 Thread Denis Kenzior
Hi Zhenhua, --- gatchat/gatserver.c | 103 +++--- 1 files changed, 56 insertions(+), 47 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index c75fbf5..07999a8 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread Denis Kenzior
Hi Pekka, From: Pekka Pessi pekka.pe...@nokia.com Add support for lock codes AG and AC (MMI codes 333 and 353, respectively). Use decimal MMI codes in ss.h. --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142

Re: [PATCH 2/9] Add parser for items next action indicator objects

2010-03-29 Thread Denis Kenzior
Hi Yang, --- src/stkutil.c | 38 ++ src/stkutil.h |5 + 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9a02658..b997752 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -67,6 +67,34 @@

Re: [PATCH 4/9] Add parser for cause objects

2010-03-29 Thread Denis Kenzior
Hi Yang, --- src/stkutil.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ecd5639..8f4ff39 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -687,6 +687,39 @@ static gboolean

Re: [PATCH 8/9] Add the macro for icon qualifier

2010-03-29 Thread Denis Kenzior
Hi Yang, --- src/stkutil.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Please call them enums, not macros :) Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 9/9] Add parser for item icon identifier list objects

2010-03-29 Thread Denis Kenzior
Hi Yang, +/* Defined in TS 102.223 Section 8.32 */ +struct stk_item_icon_id_list { + unsigned char qualifier; + unsigned char len; + unsigned char *array; +}; + And again here, the maximum size of the array is 126, so let us avoid g_mallocs. Regards, -Denis