[PATCH 0/1] Patch Description

Sometimes we need to know the version of phonesim via a command. This patch is to add this support. By the way, oFono introduces a file named version.h.in for the macro OFONO_VERSION. Can we use VERSION directly so that this file can be removed? Yang Gu (1): Add option to support version

[PATCH 1/1] Add option to support version

--- Makefile.am |2 +- bootstrap|2 +- configure.ac |1 + src/main.cpp | 11 +-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index f124b08..dd54c42 100644 --- a/Makefile.am +++ b/Makefile.am @@ -50,7 +50,7 @@

Re: [PATCH 1/1] Add option to support version

Hi Yang, Makefile.am |2 +- bootstrap|2 +- configure.ac |1 + src/main.cpp | 11 +-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index f124b08..dd54c42 100644 --- a/Makefile.am +++ b/Makefile.am @@ -50,7 +50,7

Re: [RFC] [CHANGE 1/2] Addidng initial documentation for basic assisted gps

Hi Robertino, This is first attempt to send out RFC for a-gps dbus documentation. It fill be followed by RFC for Infineon modem API implementation. Thank you for your comments in advance. :-) as explained in the other email, some general rules on submission needs to be fulfilled. Use git

Re: [RFC] [CHANGE 2/2] ifxmodem: adding modem API to support agps

Hi Robertino, This patch is RFC for Infenion modem API to support agps implementation of ofono. same rules as in the other email apply here. drivers/ifxmodem/agps.c | 438 +++ include/agps.h | 157 + 2 files

[PATCH v2] Add option to support version

--- src/main.cpp |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d7de416..d601ac2 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -28,7 +28,7 @@ static void usage() { qWarning() Usage:

Re: [RFC] AGPS Support

Hi Marcel. On positioning framework side, XML containers encoding/decoding does not seem to be yet widely used, while the support of RRC and RRLP framing is common, thanks to the support of SUPL. Using XML and 27.007 format would be great as long as long as ofono is not obliged to

Re: [RFC] AGPS Support

Hi Sjur, On positioning framework side, XML containers encoding/decoding does not seem to be yet widely used, while the support of RRC and RRLP framing is common, thanks to the support of SUPL. Using XML and 27.007 format would be great as long as long as ofono is not obliged

RE: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Marcel. +static GSList *pending_requests; +static GIOChannel *channel; +static guint32 rtnl_seqnr; +static guint rtnl_watch; To be fair, you don't need both, the GIOChannel and the watch. You can just add the watch and then unref the GIOChannel and set it to close on unref. That

Re: [RFC] AGPS Support

Hi Denis, What are the possible reasons as to why oFono might need to peek inside the XML? I was previously under the false impression that you wanted oFono API to export AGPS functionality using dbus types only. Piping the AGPS XML (or ASN.1 coded data) through oFono certainly makes the oFono

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, When adding the use of pin event *EPEV also to at_pin_send_puk_cb, it becomes identical to at_pin_send_cb, and can be removed. --- drivers/atmodem/sim.c | 44 +--- 1 files changed, 1 insertions(+), 43 deletions(-) I am fine with this

RE: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, +static GSList *pending_requests; +static GIOChannel *channel; +static guint32 rtnl_seqnr; +static guint rtnl_watch; To be fair, you don't need both, the GIOChannel and the watch. You can just add the watch and then unref the GIOChannel and set it to close on unref.

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, On 11/03/2010 07:06 AM, Marit Henriksen wrote: From: Marit Henriksen marit.henrik...@stericsson.com When adding the use of pin event *EPEV also to at_pin_send_puk_cb, it becomes identical to at_pin_send_cb, and can be removed. --- drivers/atmodem/sim.c | 44

[PATCH] TODO: Update Read/Write EFcfis description

--- TODO |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 5968c08..ad4a19a 100644 --- a/TODO +++ b/TODO @@ -1,4 +1,4 @@ -Background +pBackground == - Priority scale: High, Medium and Low @@ -114,7 +114,7 @@ SIM / SIM File system - Read /

Re: [PATCH] TODO: Update Read/Write EFcfis description

Hi Jeevaka, TODO |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, When adding the use of pin event *EPEV also to at_pin_send_puk_cb, it becomes identical to at_pin_send_cb, and can be removed. --- New patch, this one should apply:) please also do [PATCH v2] so we know which version it is. git am will strip these nicely away from us.

Re: [RFC] AGPS Support

Hi, 2010/11/3 Sjur Brændeland sjurb...@gmail.com: I was previously under the false impression that you wanted oFono API to export AGPS functionality using dbus types only. Piping the AGPS XML (or ASN.1 coded data) through oFono certainly makes the oFono implementation much simpler. I'm all

Re: [RFC] AGPS Support

Hi Aki, On 11/03/2010 12:40 PM, Aki Niemi wrote: Hi, 2010/11/3 Sjur Brændeland sjurb...@gmail.com: I was previously under the false impression that you wanted oFono API to export AGPS functionality using dbus types only. Piping the AGPS XML (or ASN.1 coded data) through oFono certainly

[PATCH] isigen: increase offline timeout

From: Pekka Pessi pekka.pe...@nokia.com The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. --- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c

Re: [PATCH] isigen: increase offline timeout

Hi Pekka, The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. --- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 493d926..014456f

Re: [PATCH] isigen: increase offline timeout

Hi Marcel, 2010/11/3 Marcel Holtmann mar...@holtmann.org: The modem deregisters from network before response to MTC_STATE_REQ is returned. Deregistering can take at least 8 seconds. ---  plugins/isigen.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH v3 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Hi Marcel. I hope I have closed most of your review comments so far. I had a go at using g_io_chanel_write_chars, but couldn't make it work, and I (stubbornly ;-) do g_caif_devices = NULL, just in case someone choose to call caif_rtnl_init

[PATCH v3 2/2] stemodem: Update gprs-context to use rtnl to create/remove interfaces.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- drivers/stemodem/gprs-context.c | 207 +-- 1 files changed, 135 insertions(+), 72 deletions(-) diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index 9f59579..4260d31

RE: [RFC] AGPS Support

For other modems sending the raw RRC/RRLP frames I guess the transcoding to XML would need to happen in the ofono driver or in ofono core if you want to expose an oFono XML API. so here is my take on XML. If we have to parse it, then in general that is a bad idea. Creating XML is

[PATCH] Added implementation for ReportVoiceCall, ReportTextMessage, Release methods and related code.Please take a look and give me feedback on the code quality , thinks that need to be changed

--- Makefile.am |6 + plugins/history.c | 438 + plugins/history_agent.c | 453 +++ plugins/history_agent.h | 103 +++ 4 files changed, 1000 insertions(+), 0 deletions(-)