[PATCHv5] plugin: Add ste modem initd integration

2011-01-06 Thread Sjur Brændeland
From: Sjur Brændeland sjur.brandel...@stericsson.com This patch introduces auto discovery of ST-Ericsson modems. ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a Modem Init Daemon responsible for start, power cycles, flashing etc. This STE plugin monitors the modem state exposed from the

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: blutolan bluto...@blutolan-desktop.(none) --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Sjur Brændeland
Hi Martin. On Thu, Jan 6, 2011 at 10:46 AM, martin...@intel.com wrote: From: blutolan bluto...@blutolan-desktop.(none) Your git-config is wrong, you need to set name and email right in your git-config before committing. Regards, Sjur ___ ofono

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
Using the old version of gcc 4.4.2 I did not meet the issue, but using 4.5.1, we have warning. -Original Message- From: Xu, Martin Sent: Thursday, January 06, 2011 5:46 PM To: ofono@ofono.org Cc: Xu, Martin; blutolan Subject: [PATCH] Fix compile warning at MeeGo The gcc version is

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
-Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Sjur Br?ndeland Sent: Thursday, January 06, 2011 5:49 PM To: ofono@ofono.org Cc: blutolan (none) Subject: Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1 Hi

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: Martin Xu martin...@intel.com --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Sjur Brændeland
Hi Redouane, ... +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) +{ +       idmap_take(gprs-cid_map, id); +} + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and M700 uses CID=1. Perhaps we should make sure CID=0 is a legal

RE: [PATCH 3/5 v2] Cell-info: Atom for obtaining ECID info of cells

2011-01-06 Thread Wei, Jun
Hi Antti, -Original Message- Subject: [PATCH 3/5 v2] Cell-info: Atom for obtaining ECID info of cells +static int append_utra_neigh_cell_data(DBusMessageIter *iter, + struct cell_measured_results *cmr) +{ + + if (cmr-rscp != OFONO_CI_FIELD_RSCP_UNDEFINED) +

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Soum, RedouaneX
Hi Marcel, Behavior of the function : List all the context and try to find correct APN we have to be careful to only match against APN==APN and Username== + Password==. The username and password option is pretty much pointless, but it is present and we do support it. So we need to

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Lucas De Marchi
On Thu, Jan 6, 2011 at 7:54 AM, Xu, Martin martin...@intel.com wrote: Using the old version of gcc 4.4.2 I did not meet the issue, but using 4.5.1, we have warning. Humn, gcc 4.5.2 here and I don't get the warning. IMHO, this warning doesn't make sense. Lucas De Marchi

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Soum, RedouaneX
Hi Sjur, +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) +{ +       idmap_take(gprs-cid_map, id); +} + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and M700 uses CID=1. Perhaps we should make sure CID=0 is a legal

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Sjur, On 01/06/2011 06:02 AM, Sjur Brændeland wrote: Hi Redouane, ... +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) +{ + idmap_take(gprs-cid_map, id); +} + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Redouane, On 01/06/2011 08:59 AM, Soum, RedouaneX wrote: Hi Sjur, +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) +{ + idmap_take(gprs-cid_map, id); +} + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and

Re: [PATCH v3 2/7] cdma-sms: Add CDMA SMS Support

2011-01-06 Thread Lei Yu
Hi Rajesh, On 01/05/2011 11:17 AM, ext rajesh.naga...@elektrobit.com wrote: Hi Lei, +void ofono_cdma_sms_deliver_notify(struct ofono_cdma_sms *cdma_sms, + unsigned char *pdu, int tpdu_len); As there is no SC number in CDMA, the whole PDU is the actual

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Sjur Brændeland
Hi, From my understanding the ID in the core is an internal ID for oFono core, even if today we usually have a mapping 1 to 1 between oFono core ID and modems CID. Denis, Marcel could you confirm ? Negative, to my understanding the CID is allocated in src/gprs.c and used when

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Marcel Holtmann
Hi Sjur, +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) +{ + idmap_take(gprs-cid_map, id); +} + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and M700 uses CID=1. Perhaps we should make sure CID=0 is a legal

Re: [PATCH v3 7/7] cdmaphonesim: Add CDMA SMS Support

2011-01-06 Thread Lei Yu
Hi Denis, On 01/05/2011 10:05 AM, ext Denis Kenzior wrote: If we have both phonesim and cdmaphonesim plugins active, we need to make sure they don't interfere with each other. Perhaps adding a Type=cdma and having cdmaphonesim look for that Type tag and ignore the rest would be a good idea?

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Marcel Holtmann
Hi Martin, src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static gboolean

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Marcel Holtmann
Hi Sjur, I thought that we came to the conclusion that CID=0 is pretty much a really bad idea. So I would prefer that your modem is actually not using CID=0 ever. Yea, I know you or Denis said so, but I'm not sure we understood your concern... I really thought it became pretty much

[PATCH] stk: Remove unwanted error check

2011-01-06 Thread Jeevaka Badrappan
Possible return values of __ofono_voicecall_tone_send are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL. --- src/stk.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/stk.c b/src/stk.c index bec46ea..932e49a 100644 --- a/src/stk.c +++ b/src/stk.c @@ -2170,11 +2170,6 @@

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Sjur, On 01/06/2011 11:45 AM, Sjur Brændeland wrote: Hi Marcel and Denis. I thought that we came to the conclusion that CID=0 is pretty much a really bad idea. So I would prefer that your modem is actually not using CID=0 ever. Yea, I know you or Denis said so, but I'm not sure we

Re: [PATCH] stk: Remove unwanted error check

2011-01-06 Thread Marcel Holtmann
Hi Jeevaka, Possible return values of __ofono_voicecall_tone_send are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL. --- src/stk.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) patch has been applied. Thanks. Regards Marcel ___

[PATCH 0/3] Make Message state feature independent of the stack

2011-01-06 Thread Faiyaz Baxamusa
This set of patches enable the org.ofono.Message interface code to be independent of the protocol stack. This will enable both GSM and CDMA SMS stack to reuse the interface code. The changes have been tested with phonesim using send-sms script. Faiyaz Baxamusa (3): doc: Add message state API

[PATCH 1/3] doc: Add message state API

2011-01-06 Thread Faiyaz Baxamusa
--- Makefile.am |2 +- doc/cdma-message-api.txt |5 + doc/message-api.txt | 24 +--- doc/message-state-api.txt | 27 +++ 4 files changed, 34 insertions(+), 24 deletions(-) create mode 100644

[PATCH 2/3] include: Introduce message

2011-01-06 Thread Faiyaz Baxamusa
--- Makefile.am |2 +- include/message.h | 67 + 2 files changed, 68 insertions(+), 1 deletions(-) create mode 100644 include/message.h diff --git a/Makefile.am b/Makefile.am index 14f53ef..8b19eef 100644 --- a/Makefile.am +++

[PATCH 3/3] message: Code independent of protocol stack

2011-01-06 Thread Faiyaz Baxamusa
--- Makefile.am |2 +- src/message.c | 257 src/ofono.h |2 + src/sms.c | 258 4 files changed, 297 insertions(+), 222 deletions(-) create mode 100644 src/message.c

[PATCH 0/2] Add additional information for mandatory general result

2011-01-06 Thread Jeevaka Badrappan
Hi, As per the ETSI TS 102 223 specification section 8.12.2, For the general result terminal currently unable to process command, it is mandatory for the terminal to provide additional information. Defined values for additional information can be found in the same section. Coding '00' shall be

[PATCH 1/2] stk: add additional info for terminal busy result

2011-01-06 Thread Jeevaka Badrappan
As per the ETSI TS 102 223 specification 8.12.2, it is mandatory to provide additional information for the general result ME currently unable to process command. --- src/stk.c | 45 + 1 files changed, 37 insertions(+), 8 deletions(-) diff --git

Re: [PATCH v2, 3/7] cdma-sms: Add CDMA SMS Support

2011-01-06 Thread Denis Kenzior
Hi Lei, So it looks to me like this function takes arbitrary bit fields from a stream. Is this a 'peculiarity' of the address field or will this be used elsewhere? Yes, your interpretation of the function is correct. Actually, cross CDMA SMS spec (and also other CDMA protocol specs), a

RE: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-06 Thread Bastian, Waldo
plugins/ifx.c | 76 +--- 1 files changed, 66 insertions(+), 10 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index c0a69c2..e0eb982 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -71,6 +71,8 @@ #define

RE: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-06 Thread Robertino Benis
Hi, The IFX modem we are targetting implements this with two AT commands. Another question that I did ask is to see some sample results from these test cases in failure and success case. Robertino? I think you meant except form the log, such as this: ofonod[1342]: Using multiplexer

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
-Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Friday, January 07, 2011 1:45 AM To: ofono@ofono.org Subject: Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1 Hi Martin,

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Marcel Holtmann
Hi Martin, src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Xu, Martin
Hi Marcel: it is a false positive. The only caller that uses the cond value is sim_set_cf_indicator. And it only uses conf if the return value is TRUE. So where can this go wrong? You are right. I will ask MeeGo tool chain guy to resolve it. Marcel