return values of org.ofono.SupplementaryServices.Initiate

2010-10-05 Thread Alexander Kanavin
Hi, doc/supplementaryservices-api.txt says nothing about return values of SupplementeryServices.Initiate method (or that the method can take SS requests in addition to USSD). Can the API designer/implementer fix this please? string, variant Initiate(string command)

[PATCH] sms: fix type error

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- src/sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sms.c b/src/sms.c index b7051b9..aee9a61 100644 --- a/src/sms.c +++ b/src/sms.c @@ -69,7 +69,7 @@ struct ofono_sms { struct sms_assembly *assembly;

[RFC online/offline atoms PATCH 3/4] gprs: watch modem state

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Indicate detach when modem is in offline state. --- src/gprs.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 3f085ed..431275c 100644 --- a/src/gprs.c +++ b/src/gprs.c @@

[RFC online/offline atoms PATCH 0/4] modem: add modem state watch

2010-10-05 Thread Pekka . Pessi
Hello all, Here is a proposal for adding a mechanism for atoms to follow modem states, with main interest in online and offline. There are also examples of two atoms, sms and gprs, using the watch. The final patch modifies the isigen driver so that it will create sms and gprs atoms already in

[RFC online/offline atoms PATCH 1/4] modem: add modem state watch

2010-10-05 Thread Pekka . Pessi
From: Andras Domokos andras.domo...@nokia.com Modem state notifiers get called after modem state has been changed and atoms have been added or flushed. The modem state watch benefit the atoms that are active in several states, such as voicecall, sms, or gprs. --- src/modem.c | 64

[RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- plugins/isigen.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index db61fdb..d550a34 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -395,22 +395,29 @@ static

[RFC online/offline atoms PATCH 2/4] sms: watch modem state

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Allow use of SMS atom in online and offline states. The messages are queued but not sent in offline mode. Errors occurring when an SMS is being sent while transition from online to offline are handled gracefully. --- src/sms.c | 46

Re: [PATCH] sms: fix type error

2010-10-05 Thread Marcel Holtmann
Hi Pekka, --- src/sms.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sms.c b/src/sms.c index b7051b9..aee9a61 100644 --- a/src/sms.c +++ b/src/sms.c @@ -69,7 +69,7 @@ struct ofono_sms { struct sms_assembly *assembly; guint ref;

Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state

2010-10-05 Thread Marcel Holtmann
Hi Pekka, Allow use of SMS atom in online and offline states. The messages are queued but not sent in offline mode. Errors occurring when an SMS is being sent while transition from online to offline are handled gracefully. do we really want this? How is this suppose to work from the user

Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Marcel Holtmann
Hi Pekka, --- plugins/isigen.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index db61fdb..d550a34 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -395,22 +395,29 @@ static void

Re: return values of org.ofono.SupplementaryServices.Initiate

2010-10-05 Thread Marcel Holtmann
Hi Alex, doc/supplementaryservices-api.txt says nothing about return values of SupplementeryServices.Initiate method (or that the method can take SS requests in addition to USSD). Can the API designer/implementer fix this please? why don't you just send a patch for it if it is unclear?

Re: return values of org.ofono.SupplementaryServices.Initiate

2010-10-05 Thread Alexander Kanavin
On 05.10.2010 15:06, ext Marcel Holtmann wrote: doc/supplementaryservices-api.txt says nothing about return values of SupplementeryServices.Initiate method (or that the method can take SS requests in addition to USSD). Can the API designer/implementer fix this please? why don't you just send a

Error in setting VoiceNoReplyTimeout property in call-forwarding

2010-10-05 Thread sai koushik
Hi, we are working on use-case to activate call-forwarding rule when no reply , but ofono is returning error Invalid arguments in method call when trying to set the reply-timeout value. below is the code for the use-case GValue val={0,{{0}}}; g_value_init(val,G_TYPE_UINT); uint value=30;

Need Help with GetProperties() method on SimManager interface.

2010-10-05 Thread sai koushik
Hi, We are testing SimManager interface , In that we want to check the whether sim is present or not. To do that we are invoking GetProperties method on SimManager interface , but in return we are getting all the properties on the given interface . As a result of this we are

Re: Need Help with GetProperties() method on SimManager interface.

2010-10-05 Thread Marcel Holtmann
Hi Sai, We are testing SimManager interface , In that we want to check the whether sim is present or not. To do that we are invoking GetProperties method on SimManager interface , but in return we are getting all the properties on the given interface . As a result of this

[PATCH] TODO: ofono_sim_ready_notify()

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 8d4a26e..5589bb1 100644 --- a/TODO +++ b/TODO @@ -137,6 +137,7 @@ SIM / SIM File system Priority: High Complexity: C2 + Owner: Pekka Pessi

Re: [PATCH] TODO: ofono_sim_ready_notify()

2010-10-05 Thread Marcel Holtmann
Hi Pekka, --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) I applied this patch. However you do remember that we had issues when we tried this the first time. It looked simpler on paper then it was when trying to make this work with all modem plugins. Remember that this

[RFC sim-ready-v0 PATCH 3/3] isimodem/sim: added PIN and SIM state handling

2010-10-05 Thread Pekka . Pessi
From: Jukka Saunamaki jukka.saunam...@nokia.com Using ofono_sim_ready_notify(). --- drivers/isimodem/debug.c | 30 +++ drivers/isimodem/debug.h |3 + drivers/isimodem/sim.c | 558 +++--- drivers/isimodem/sim.h | 50 - 4 files changed, 605

[RFC sim-ready-v0 PATCH 0/3] ofono_sim_ready_notify

2010-10-05 Thread Pekka . Pessi
Hi all, Here is my stab at the ofono_sim_ready_notify(). If SIM is not ready, the ofono_sim_driver indicates that with query_passwd_state callback returning OFONO_SIM_PASSWORD_INVALID. After the driver determines that the SIM is ready, it calls ofono_sim_ready_notify(). The patches has

[RFC sim-ready-v0 PATCH 1/3] sim: add ofono_sim_ready_notify

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com If SIM is not ready, the ofono_sim_driver indicates that with query_passwd_state callback returning OFONO_SIM_PASSWORD_INVALID. After the driver determines that SIM is ready, it calls ofono_sim_ready_notify(). Based on patches by Kristen Accardi and Denis

[RFC sim-ready-v0 PATCH 2/3] atmodem/sim: use ofono_sim_ready_notify

2010-10-05 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com The ofono_sim_driver-query_passwd_state callback will return OFONO_SIM_PASSWORD_INVALID if SIM is not really ready yet. When the sim gets ready or timeout occurs, ofono_sim_ready_notify() is called. --- drivers/atmodem/sim.c | 92

Re: [PATCH] TODO: ofono_sim_ready_notify()

2010-10-05 Thread Pekka Pessi
Hi Marcel, 2010/10/5 Marcel Holtmann mar...@holtmann.org: However you do remember that we had issues when we tried this the first time. It looked simpler on paper then it was when trying to make this work with all modem plugins. Remember that this has to work with all modem plugins and not

Re: [RFC sim-ready-v0 PATCH 2/3] atmodem/sim: use ofono_sim_ready_notify

2010-10-05 Thread Marcel Holtmann
Hi Pekka, The ofono_sim_driver-query_passwd_state callback will return OFONO_SIM_PASSWORD_INVALID if SIM is not really ready yet. When the sim gets ready or timeout occurs, ofono_sim_ready_notify() is called. this reminds me that the current quirks won't work when entering the PUK. The only

Re: [PATCH] TODO: ofono_sim_ready_notify()

2010-10-05 Thread Marcel Holtmann
Hi Pekka, However you do remember that we had issues when we tried this the first time. It looked simpler on paper then it was when trying to make this work with all modem plugins. Remember that this has to work with all modem plugins and not just ISI or IFX for that matter. Yes, this

Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state

2010-10-05 Thread Denis Kenzior
Hi Marcel, On 10/05/2010 06:59 AM, Marcel Holtmann wrote: Hi Pekka, Allow use of SMS atom in online and offline states. The messages are queued but not sent in offline mode. Errors occurring when an SMS is being sent while transition from online to offline are handled gracefully. do we

Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Denis Kenzior
Hi Marcel, what advantage to we have from moving SMS and GPRS atom into the post_sim state? I am trying to really understand what this is trying to do and what is the difference of just doing it when in post_online state. We'd like to be able to toggle GPRS settings even if in offline state.

Re: Error in setting VoiceNoReplyTimeout property in call-forwarding

2010-10-05 Thread Denis Kenzior
Hi Sai, On 10/05/2010 09:49 AM, sai koushik wrote: Hi, we are working on use-case to activate call-forwarding rule when no reply , but ofono is returning error Invalid arguments in method call when trying to set the reply-timeout value. below is the code for the use-case GValue