Re: [PATCH 7/8] sierra: Support CDMA modems

2013-03-04 Thread Denis Kenzior
Hi Forest, On 03/04/2013 10:48 AM, Forest Bond wrote: Hi Denis, On Sun, Dec 30, 2012 at 08:34:29PM -0600, Denis Kenzior wrote: - ofono_netreg_create(modem, 0, "atmodem", data->modem); + if (data->have_gsm == TRUE) { + ofono_netreg_create(modem, 0, "atmodem", data->mod

Re: [PATCH v1 0/6] handsfree-audio: Add Agent NewConnection()

2013-03-04 Thread Denis Kenzior
Hi Claudio, On 03/04/2013 02:48 PM, Claudio Takahasi wrote: This patch series moves the SCO connection handling from hfp_hf_bluez5.c to src/handsfree-audio.c, and adds the Agent NewConnection() method call to pass the SCO file descriptor from oFono to the Agent implementation. Changes between v

[PATCH v1 6/6] handsfree-audio: Reject SCO if agent is unavailable

2013-03-04 Thread Claudio Takahasi
This patch rejects the incoming SCO connection if there isn't a Handsfree Audio Agent registered. --- src/handsfree-audio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c index 857c258..73c6183 100644 --- a/src/handsfree-audio.c +++ b/src/ha

[PATCH v1 5/6] handsfree-audio: Reject SCO if Card is not ready

2013-03-04 Thread Claudio Takahasi
The Audio Card is being created when the NewConnection from BlueZ Profile is received, and registered when the service level connection negotiation finishes. This patch rejects SCO connection if the SCO incoming connection arrives when the service level negotiation is ongoing. --- src/handsfree-au

[PATCH v1 4/6] handsfree-audio: Check local SCO address

2013-03-04 Thread Claudio Takahasi
This patch verifies if the local Bluetooth address of the incoming connection also matches with one of available audio cards. --- src/handsfree-audio.c | 44 +++- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/src/handsfree-audio.c b/src/han

[PATCH v1 3/6] handsfree-audio: Add NewConnection

2013-03-04 Thread Claudio Takahasi
This patch adds Agent NewConnection call. The card object path, the SCO file descriptor, and the codec are being passed to the agent. This initial version supports CVSD codec only. --- src/handsfree-audio.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --

[PATCH v1 2/6] handsfree-audio: Move SCO to handsfree-audio.c

2013-03-04 Thread Claudio Takahasi
This patch moves the SCO socket handling from hfp_hf_bluez5 plugin to handsfree-audio.c file. This is the initial step to be able to support sending the file descriptor through the Agent NewConnection method. This patch replaces the handsfree modem verification by the Audio Card. Audio Cards are c

[PATCH v1 1/6] bluetooth: Add new Bluetooth header

2013-03-04 Thread Claudio Takahasi
This patch moves the Bluetooth utility funtions and socket type declarations to a new header src/bluetooth.h, allowing to share it between core, and plugins. --- Makefile.am | 2 +- plugins/bluez5.c| 17 plugins/bluez5.h| 41 p

[PATCH v1 0/6] handsfree-audio: Add Agent NewConnection()

2013-03-04 Thread Claudio Takahasi
This patch series moves the SCO connection handling from hfp_hf_bluez5.c to src/handsfree-audio.c, and adds the Agent NewConnection() method call to pass the SCO file descriptor from oFono to the Agent implementation. Changes between v0-v1: * Merged commits "Move SCO to handsfree-audio.c" and "Rem

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Claudio Takahasi
Hi Denis: On Mon, Mar 4, 2013 at 4:30 PM, Denis Kenzior wrote: > Hi Marcel, > > >>> >>> I don't see why not. Both Codec Negotiation and Wide-band speech are >>> labeled optional for HF/AG in Table 3.1. The only note there says: "If Wide >>> Band Speech is supported, Codec Negotiation shall also

[PATCH 13/13] dundee: Handle Profile connect and disconnect

2013-03-04 Thread Paulo Borges
--- dundee/bluez5.c | 115 ++- 1 file changed, 105 insertions(+), 10 deletions(-) diff --git a/dundee/bluez5.c b/dundee/bluez5.c index 31bdfea..a92cbae 100644 --- a/dundee/bluez5.c +++ b/dundee/bluez5.c @@ -41,16 +41,63 @@ struct bluetooth_devi

[PATCH 12/13] dundee: Add dundee disconnect function

2013-03-04 Thread Paulo Borges
--- dundee/device.c | 14 +++--- dundee/dundee.h |3 +++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dundee/device.c b/dundee/device.c index e5f6424..2d84aaa 100644 --- a/dundee/device.c +++ b/dundee/device.c @@ -270,11 +270,13 @@ err: device->pending = NU

[PATCH 11/13] dundee: Add support for driver connect

2013-03-04 Thread Paulo Borges
This patch glues together the dundee driver interface with the D-Bus Profile1 interface. When the dundee driver requests a connection, it will call the Device1's ConnectProfile. --- dundee/bluez5.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dundee/bluez5.c b/dund

[PATCH 10/13] dundee: Add BlueZ Profile handler

2013-03-04 Thread Paulo Borges
This patch declares the external dundee Profile handler. It contains the initial implementation of the D-Bus Profile1 interface and methods responsible for handling Bluetooth connections. --- dundee/bluez5.c | 68 +++ 1 file changed, 68 inserti

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Denis Kenzior
Hi Marcel, I don't see why not. Both Codec Negotiation and Wide-band speech are labeled optional for HF/AG in Table 3.1. The only note there says: "If Wide Band Speech is supported, Codec Negotiation shall also be supported." However, there is no note vice-versa. So my interpretation is

[PATCH 09/13] dundee: Register/unregister dundee device

2013-03-04 Thread Paulo Borges
This patch adds the dundee device struct to the our Bluetooth device representation. --- dundee/bluez5.c | 25 + 1 file changed, 25 insertions(+) diff --git a/dundee/bluez5.c b/dundee/bluez5.c index 19111e7..12f0cf0 100644 --- a/dundee/bluez5.c +++ b/dundee/bluez5.c @@ -

[PATCH 07/13] dundee: Listen to devices property changes

2013-03-04 Thread Paulo Borges
When a bluetooth device property change and this property is Alias or UUIDs, we need to refresh our representation of this device. --- dundee/bluez5.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/dundee/bluez5.c b/dundee/bluez5.c index 8d8e656..6

[PATCH 08/13] dundee: Add dundee device driver skeleton

2013-03-04 Thread Paulo Borges
This patch adds the functions to be called when the dundee will connect or disconnect with a Bluetooth device. --- dundee/bluez5.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/dundee/bluez5.c b/dundee/bluez5.c index 623201f..19111e7 100644 --- a/dundee/bluez5.c +++ b/d

[PATCH 06/13] dundee: Add tracking of bluetooth devices

2013-03-04 Thread Paulo Borges
This patch tracks the GDBusProxy for Bluetooth devices in order to be able to get their properties and register them when they implement DUN. --- dundee/bluez5.c | 90 +++ 1 file changed, 90 insertions(+) diff --git a/dundee/bluez5.c b/dundee/

[PATCH 05/13] dundee: Add mechanism to store bluetooth devices

2013-03-04 Thread Paulo Borges
This patch adds a hash that will store every known bluetooth device that implements DUN service. --- dundee/bluez5.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/dundee/bluez5.c b/dundee/bluez5.c index 40df700..970f3a2 100644 --- a/dundee/bluez5.c +++ b/dundee/blu

[PATCH 04/13] dundee: Initial GDBusClient for BlueZ 5

2013-03-04 Thread Paulo Borges
This patch adds the callbacks to track additions and removals of BlueZ related interfaces and property changes in these interfaces. --- dundee/bluez5.c | 60 +++ dundee/dundee.h |2 ++ 2 files changed, 62 insertions(+) diff --git a/dundee/

[PATCH 03/13] bluez5: Add DUN_UUID

2013-03-04 Thread Paulo Borges
--- plugins/bluez5.h |1 + 1 file changed, 1 insertion(+) diff --git a/plugins/bluez5.h b/plugins/bluez5.h index f7f3d7e..09654b7 100644 --- a/plugins/bluez5.h +++ b/plugins/bluez5.h @@ -25,6 +25,7 @@ #define BLUEZ_DEVICE_INTERFACE BLUEZ_SERVICE ".Device1" #define BLUEZ_ERROR_INTERF

[PATCH 02/13] dundee: Start BlueZ 5 support

2013-03-04 Thread Paulo Borges
This patch adds the BlueZ 5 support file for dundee. --- Makefile.am | 16 ++-- dundee/bluez5.c | 37 + 2 files changed, 47 insertions(+), 6 deletions(-) create mode 100644 dundee/bluez5.c diff --git a/Makefile.am b/Makefile.am index ed3598

[PATCH 01/13] dundee: Rename dundee BlueZ 4 support

2013-03-04 Thread Paulo Borges
The BlueZ 4 support file for dundee has now been renamed to bluez4.c to make it easier to add a BlueZ 5 support file. --- Makefile.am|2 +- dundee/bluetooth.c | 297 dundee/bluez4.c| 297

[PATCH 00/13] Add support for BlueZ 5 Profile1 API to dundee

2013-03-04 Thread Paulo Borges
This series implements support for BlueZ 5 to dundee. It uses the org.bluez.Profile1 API to register an external profile. While the interface between BlueZ and dundee has changed, the interfaces "org.ofono.dundee.Device" and "org.ofono.dundee.Manager" remains unchanged. Paulo Borges (13): dunde

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Marcel Holtmann
Hi Denis, This patch adds a new function to read the local supported Handsfree Profile version. --- include/handsfree-audio.h | 1 + src/handsfree-audio.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/handsfree-audio.h b/include/h

Re: [PATCH] bluez5: Add bt_register_profile_with_role

2013-03-04 Thread Denis Kenzior
Hi Paulo, On 03/01/2013 03:58 PM, Paulo Borges wrote: This function allows to specify which role is registering when the profile does not have specific UUIDs for each role. --- plugins/bluez5.c | 15 +-- plugins/bluez5.h |4 2 files changed, 17 insertions(+), 2 deletio

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Denis Kenzior
Hi Claudio, On 03/04/2013 10:02 AM, Claudio Takahasi wrote: Hi Denis: On Fri, Mar 1, 2013 at 4:40 PM, Denis Kenzior wrote: Hi Claudio, On 02/28/2013 12:52 PM, Claudio Takahasi wrote: This patch adds a new function to read the local supported Handsfree Profile version. --- include/hands

Re: [PATCH 7/8] sierra: Support CDMA modems

2013-03-04 Thread Forest Bond
Hi Denis, On Sun, Dec 30, 2012 at 08:34:29PM -0600, Denis Kenzior wrote: > >-ofono_netreg_create(modem, 0, "atmodem", data->modem); > >+if (data->have_gsm == TRUE) { > >+ofono_netreg_create(modem, 0, "atmodem", data->modem); > >+} else if (data->have_cdma == TRUE) { > >+

Re: [PATCH v0 09/10] handsfree-audio: Add function to get hfp version

2013-03-04 Thread Claudio Takahasi
Hi Denis: On Fri, Mar 1, 2013 at 4:40 PM, Denis Kenzior wrote: > Hi Claudio, > > > On 02/28/2013 12:52 PM, Claudio Takahasi wrote: >> >> This patch adds a new function to read the local supported Handsfree >> Profile version. >> --- >> include/handsfree-audio.h | 1 + >> src/handsfree-audio.c

Re: [PATCH v0 03/10] handsfree-audio: Remove modem dependency

2013-03-04 Thread Claudio Takahasi
Hi Denis: On Fri, Mar 1, 2013 at 4:29 PM, Denis Kenzior wrote: > Hi Claudio, > > > On 02/28/2013 12:52 PM, Claudio Takahasi wrote: >> >> This patch replaces the handsfree modem verification by the Audio Card. >> Audio Cards are created when the RFCOMM fd descriptor is received, and >> registered

Re: [PATCH v0 02/10] handsfree-audio: Move SCO to handsfree-audio.c

2013-03-04 Thread Claudio Takahasi
Hi Denis On Fri, Mar 1, 2013 at 4:20 PM, Denis Kenzior wrote: > Hi Claudio, > > > On 02/28/2013 12:52 PM, Claudio Takahasi wrote: >> >> This patch moves the SCO socket handling from hfp_hf_bluez5 plugin to >> handsfree-audio.c file. >> >> This is the initial step to be able to support sendi