Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Marcel Holtmann
Hi Sjur, I thought that we came to the conclusion that CID=0 is pretty much a really bad idea. So I would prefer that your modem is actually not using CID=0 ever. Yea, I know you or Denis said so, but I'm not sure we understood your concern... I really thought it became pretty much

Re: [PATCH] stk: Remove unwanted error check

2011-01-06 Thread Marcel Holtmann
Hi Jeevaka, Possible return values of __ofono_voicecall_tone_send are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL. --- src/stk.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) patch has been applied. Thanks. Regards Marcel ___

RE: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread Marcel Holtmann
Hi Martin, src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static

Re: [PATCH v3] ifx: Adding modem selftest for Infineon modem

2011-01-05 Thread Marcel Holtmann
Hi Robertino, This is another attempt to submit a patch that triggers Infineon modem selftest during ofono boot. Patch addresses issues raised by Marcel from the previous submissions. --- as a general comment, changelogs and notes for the reviewer have to between --- and the diffstat. They

Re: [PATCHv4 1/1] plugin: Add ste modem initd integration

2011-01-05 Thread Marcel Holtmann
Hi Sjur, This patch introduces auto discovery of ST-Ericsson modems. ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a Modem Init Daemon responsible for start, power cycles, flashing etc. This STE plugin monitors the modem state exposed from the Modem Init Damon's Dbus API. When the

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-05 Thread Marcel Holtmann
Hi Redouane, gprs: add function to handle activated context ofono_gprs_context_activated : this function is symetric to ofono_gprs_context_deactivated. This function must be call by any gprs-context driver when a context has been activated without explicit request. Behavior of the

Re: [PATCH] dbus: fix appending on dict for types other than string

2011-01-05 Thread Marcel Holtmann
Hi Lucas, According to dbus documentation, dbus_message_iter_append_basic() expects a const char** if type is string and a simple pointer for other types. Since we a iterating an array, the value passed is already a pointer. --- src/dbus.c | 20 ++-- 1 files changed, 18

Re: [PATCHv3] network: query signal strength

2011-01-05 Thread Marcel Holtmann
Hi Marit, Signal strength is set to -1 whenever registration status changes and differs from registered or roaming. When registration status changes again to registered or roaming, the signal strength needs to be updated, added query towards driver to get it. --- src/network.c | 29

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-04 Thread Marcel Holtmann
Hi Jukka, thinking about this a bit more and with the background that there is already an existing public database, we might should just enable a provision driver inside the oFono core. Meaning that we can have multiple implementations of different databases with just different

Re: [PATCHv3] stemodem: Fix for MT call not working when caller id is hidden.

2011-01-04 Thread Marcel Holtmann
Hi Marit, In *ECAV, the number will not be included if caller id is hidden. Set it to an empty string in that case, and set number type to 128, unknown number type. --- drivers/stemodem/voicecall.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-04 Thread Marcel Holtmann
Hi Kalle, thinking about this a bit more and with the background that there is already an existing public database, we might should just enable a provision driver inside the oFono core. Meaning that we can have multiple implementations of different databases with just different

Re: [PATCHv4] stemodem: Fix for MT call not working when caller id is hidden.

2011-01-04 Thread Marcel Holtmann
Hi Marit, In *ECAV, the number will not be included if caller id is hidden. Set it to an empty string in that case, and set number type to 128, unknown number type. --- drivers/stemodem/voicecall.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) patch has been

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-04 Thread Marcel Holtmann
Hi Jukka, the oFono plugins work like kernel modules. They are pretty much generic. Inside the init function you can a driver register function and inside the exit function, you call the driver unregister function. Right, that seems clear enough. static int setup_context(struct

Re: [PATCH 0/4 v2] Network Time plugin

2011-01-04 Thread Marcel Holtmann
Hi Remi, So the idea of having an oFono D-Bus API to export time information is just wrong from my point of view. The plugin inside oFono should tell the time daemon about this. That would be race-prone by design. For all we know, the time daemon might be started after oFono

Re: [PATCHv2] plugin: Add ste modem initd integration

2011-01-04 Thread Marcel Holtmann
Hi Sjur, what about potential USB based CAIF devices? Good question, but in a Bridge Setup for a phone this will not really be devices that come and go. I belive it will still be a fixed HW setup where the Modem Init Daemon will have static knowledge of the USB modems. But I'll discuss

Re: [RFC sim-authenticate PATCH 2/3] Added doc/sim-authentication-api.txt.

2011-01-04 Thread Marcel Holtmann
Hi Pekka, Andrew is currently looking on how to do SIM application discovery. So I like to get his input on this as well. The AT+CUAD looks straightforward enough. Unfortunately I've yet to see a modem implementing AT+CUAD. the MBM F35xx does support this. At least when I quickly check

Re: [PATCH] dbus: fix appending on dict for types other than string

2011-01-04 Thread Marcel Holtmann
Hi Lucas, According to dbus documentation, dbus_message_iter_append_basic() expects a const char** if type is string and a simple pointer for other types. Since we a iterating an array, the value passed is already a pointer. --- src/dbus.c |9 +++-- 1 files changed, 7

Re: [PATCH] dbus: fix appending on dict for types other than string

2011-01-04 Thread Marcel Holtmann
Hi Lucas, the append_basic D-Bus function works fine on **char and *uint8. So either a pointer to a string (*char) or pointer to a byte (uint8. You differentiate between pointer to a string and pointer to a byte in that function. So it is different since normally it is the caller that

Re: [PATCH 0/4 v2] Network Time plugin

2011-01-04 Thread Marcel Holtmann
Hi Aki, But then it is far simpler to have a D-Bus getter and a D-Bus signal by any sane measure of complexity. So you did consider the complexity on both sides, ofonod and timed? And not just looked at one side of picture? Timed also needs to follow the registration status,

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-03 Thread Marcel Holtmann
Hi Aki, Any particular reason why you can't use the same format as in mobile-broadband-provider-info? I think reusing the format here makes sense, actually. If not for anything else than to be able to use an existing database for testing. my thinking was that we should read the MBPI

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-03 Thread Marcel Holtmann
Hi Jukka, Well, my intention was to make format simple and fast to parse, but still be extensible enough, which I think my proposed format fulfills. These access-elements contain just data needed for GPRS context settings (as attributes), and if there is need for any other

Re: [RFC PATCHv2 1/4] sim: add ofono_sim_get_mnc_length

2011-01-03 Thread Marcel Holtmann
Hi Jukka, include/sim.h |1 + src/sim.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..3d0c6b7 100644 --- a/include/sim.h +++ b/include/sim.h @@ -173,6 +173,7 @@ void ofono_sim_set_data(struct

Re: [PATCH 5/5] cell-info: Documentation

2011-01-03 Thread Marcel Holtmann
Hi Aki, What is the reason behind a{sv}aa{sv} here? Wouldn't it be simpler to just go with aa{sv} and declare that the first dict is always the current serving cell? Are the information from the current cell really that different than from the neighbors? The rationale is that this is

Re: [PATCH 0/4 v2] Network Time plugin

2011-01-03 Thread Marcel Holtmann
Hi Remi, So the idea of having an oFono D-Bus API to export time information is just wrong from my point of view. The plugin inside oFono should tell the time daemon about this. That would be race-prone by design. For all we know, the time daemon might be started after oFono (or

Re: [RFC sim-authenticate PATCH 2/3] Added doc/sim-authentication-api.txt.

2011-01-03 Thread Marcel Holtmann
Hi Pekka, The EAP applications on SIM should be handled separately. The EapSimAuthenticate and EapAkaAuthenticate do not require a special EAP application on SIM, but they use ordinary cellular authentication. --- doc/sim-authentication-api.txt | 66

Re: [PATCHv2] plugin: Add ste modem initd integration

2011-01-03 Thread Marcel Holtmann
Hi Sjur, is this the full API or only part of it. If it is just a part of it, please send the full API for the daemon. Just looking at this piece, I am not really thinking that this is a good API. It is actually pretty much broken :( Ok, here's an updated version of the Modem Init

Re: [PATCHv2] plugin: Add ste modem initd integration

2011-01-03 Thread Marcel Holtmann
Hi Sjur, Signals StateChange(string State) The modems state sent from when a modem state change occurs. State is the only dynamic property in this Interface. I would personally just go straight for

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-03 Thread Marcel Holtmann
Hi Jukka, Here is another RFC patchset about implementing automatic provisioning of Internet and MMS GPRS context settings. (Internet Access Provider database TODO item). In case there are no previously configured contexts found during gprs atom registration, this code tries to

Re: [PATCH] doc: New file about using the calypso modem

2010-12-31 Thread Marcel Holtmann
Hi Neil, doc/calypso-modem.txt | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) create mode 100644 doc/calypso-modem.txt patch has been applied, but you might also wanna add this to Makefile.am so it becomes part of the tarballs. Regards Marcel

Re: [PATCH] doc: Include doc/calypso-modem.txt in distribution

2010-12-31 Thread Marcel Holtmann
Hi Neil, Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] doc: New file about using the calypso modem

2010-12-28 Thread Marcel Holtmann
Hi Neil, doc/calypso-modem.txt | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) create mode 100644 doc/calypso-modem.txt diff --git a/doc/calypso-modem.txt b/doc/calypso-modem.txt new file mode 100644 index 000..ea3e0bb --- /dev/null +++

Re: [PATCH 5/5] cell-info: Documentation

2010-12-28 Thread Marcel Holtmann
Hi Antti, doc/cell-info.txt | 124 + 1 files changed, 124 insertions(+), 0 deletions(-) create mode 100644 doc/cell-info.txt diff --git a/doc/cell-info.txt b/doc/cell-info.txt new file mode 100644 index 000..b288e69 ---

Re: [PATCH 2/3] call-settings: rename CalledLine* properties

2010-12-28 Thread Marcel Holtmann
Hi Lucas, COLP and COLR are better named respectively as ConnectedLinePresentaion and ConnectedLineRestriction as stated in 27.007 sections 7.8 and 7.31. don't forget the scripts in the test directory. Regards Marcel ___ ofono mailing list

Happy holidays to everyone

2010-12-26 Thread Marcel Holtmann
. Developers with the most changed lines -- Denis Kenzior 80016 (34.2%) Andrzej Zaborowski27962 (11.9%) Yang Gu 25203 (10.8%) Marcel Holtmann 24574 (10.5%) Aki Niemi 19997 (8.5%) Looking from

Re: n900 not recongnized by ofono?

2010-12-26 Thread Marcel Holtmann
Hi Antti, It appears that after commit 374dd32812026c3d728f2a14f78357463f12a3f8 ofono is no longer registering n900 properly. At least 'list-modems' shows empty list even if two commit earlier [isigen0] is there as it should. Has the functionality changed or is this regression? the

Re: oFono release plan?

2010-12-23 Thread Marcel Holtmann
Hi Aki, - SIM authentication API (EAP-SIM, EAP-AKA, IMS and GBA) Can you please add more light on what is supported. I could not find this info in the todo list. In short, we need to expose certain security services offered by the SIM card that utilize the crypto algorithms on

RE: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

2010-12-23 Thread Marcel Holtmann
Hi Antti, --- include/cell-info.h | 133 +++ 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 include/cell-info.h diff --git a/include/cell-info.h b/include/cell-info.h new file mode 100644 index

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-22 Thread Marcel Holtmann
Hi Neil, Then I didn't look far back enough (or I'm simply blind). But I still prefer this to be inside the driver or HACKING.calypso for easier access. I am with you that this needs to be documented better than GIT commit logs. However I do prefer doc/calypso-modem.txt and

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

2010-12-22 Thread Marcel Holtmann
Hi Lei, Makefile.am | 10 ++ plugins/cdmaphonesim.c| 328 + plugins/cdmaphonesim.conf | 14 ++ 3 files changed, 352 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmaphonesim.c create mode 100644

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-22 Thread Marcel Holtmann
Hi Aki, There is no problem. If you still think there is a problem, you need to continue the previous thread on this subject and prove your point. And in case timed is not running it should just set the current time directly. You're welcome to write such a plugin -- this is why nettime

Re: [PATCHv2] plugin: Add ste modem initd integration

2010-12-22 Thread Marcel Holtmann
Hi Sjur, This is a bad D-Bus API btw. Using a D-Bus method to trigger signal sending. You will wake up any listener for that signal. What is wrong with just having a GetState? My problem is that I need to get the path, or modem serial-number if you like, to the modem(s). As I

Re: [RFC PATCH 0/4] Atom for Neighbour Cell Info

2010-12-21 Thread Marcel Holtmann
Hi Antti, This series of patches implements an interface for client application to fetch the ECID information of neighbouring cells using DBUS. src/cell-info.c | 537 +++ include/cell-info.h | 66

Re: [PATCH] udev: Fix warning in compilation

2010-12-21 Thread Marcel Holtmann
Hi Antti, plugins/udev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [RFC PATCH 0/4] Automatic provisioning of GPRS context settings

2010-12-21 Thread Marcel Holtmann
Hi Jukka, Here is a first attempt to implement automatic provisioning of Internet and MMS GPRS context settings. (Internet Access Provider database TODO item). In case there are no previously configured contexts found during gprs atom registration, this code tries to provision Internet and

Re: oFono release plan?

2010-12-21 Thread Marcel Holtmann
Hi Sjur, Do you have a release plan defined for oFono? When will you release oFono 1.0? We do not have a concrete plan as of yet. For the most part we were quite happy with the current set of oFono APIs, however with LTE support on the horizon we might have to revisit some of them.

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-21 Thread Marcel Holtmann
Hi Antti, please do not top-post on this mailing list. Could someone review this patch. It has been waiting for review a while now. Thanks. snip This series of patches introduces the network time part of the NITZ feature as outlined in 3GPP spec 22.042. The Network Time plugin has two

Re: [PATCHv2 1/2] stemodem: Create network interfaces statically

2010-12-21 Thread Marcel Holtmann
Hi Sjur, Changes: o Restructure code so interfaces are created statically when probe is called, instead of creating interfaces dynamically at activation. o Changed debug messages. o Removed some of the unnecessary initializations at declaration. o No longer reporting default gateway for

Re: [PATCHv2 2/2] stemodem: Use RTNL to create network interfaces.

2010-12-21 Thread Marcel Holtmann
Hi Sjur, drivers/stemodem/gprs-context.c | 43 -- 1 files changed, 36 insertions(+), 7 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCHv2] plugin: Add ste modem initd integration

2010-12-21 Thread Marcel Holtmann
Hi Sjur, + +/* ResetState requests resending of StateChange. */ +#define MID_RESEND_STATE ResendState This is a bad D-Bus API btw. Using a D-Bus method to trigger signal sending. You will wake up any listener for that signal. What is wrong with just having a GetState? My

Re: oFono release plan?

2010-12-21 Thread Marcel Holtmann
Hi Aki, the upcoming LTE support holds us a little bit back. So Denis and I are a bit careful about calling it 1.0 just yet. Can you elaborate here? I thought the conclusion of our discussions was that the D-Bus API will see practically no changes due to LTE. we don't know that yet for

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-21 Thread Marcel Holtmann
Hi Aki, I am still saying that the plugin should monitor the presence of timed and then just send a D-Bus message to timed. That saves us the problem with the timestamping. There is no problem. If you still think there is a problem, you need to continue the previous thread on this

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
Hi Denis, I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should be as simple as: KERNEL==ttySAC0, ENV{OFONO_DRIVER}=calypso Do you mean in another file than 97-ofono.rules? Yep. I prefer not to have this inside ofono.git at all.

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
isn't even documented in git commit logs. I looked ;) commit 3443a7a177fbaca24c84658968aff0a55db8a51d Author: Marcel Holtmann mar...@holtmann.org Date: Sat Sep 18 22:08:41 2010 +0900 udev: Add support for IFX device detection The IFX device detection is pretty static, but instead

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

2010-12-21 Thread Marcel Holtmann
isn't even documented in git commit logs. I looked ;) commit 3443a7a177fbaca24c84658968aff0a55db8a51d Author: Marcel Holtmann mar...@holtmann.org Date: Sat Sep 18 22:08:41 2010 +0900 udev: Add support for IFX device detection The IFX device detection is pretty static

Re: [PATCH v2] ifx: Adding modem selftest to Infineon modem

2010-12-18 Thread Marcel Holtmann
Hi Robertino, diff --git a/plugins/ifx.c b/plugins/ifx.c index 2f4c65b..3647dbc 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -71,6 +71,8 @@ #define GPRS3_DLC 4 #define AUX_DLC 5 +#define IFX_SELF_TESTS_TIMEOUT 5 + this is not what I meant actually. Adding a comment

Re: [PATCH v2 8/9] udev: Add cdmagen

2010-12-18 Thread Marcel Holtmann
Hi Dara, struct ofono_modem *modem; @@ -533,6 +552,8 @@ done: add_isi(modem, udev_device); else if (g_strcmp0(driver, n900) == 0) add_isi(modem, udev_device); + else if (g_strcmp0(driver, cdmagen) == 0) + add_cdmagen(modem,

Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device

2010-12-18 Thread Marcel Holtmann
Hi Dara, plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index da8a8ef..34698f0 100644 --- a/plugins/ofono.rules +++ b/plugins/ofono.rules @@ -429,6 +429,10 @@ ATTRS{idVendor}==0930,

Re: Voice call audio routing

2010-12-16 Thread Marcel Holtmann
Hi Niko, While testing an e169 huawei card I was able to make voice calls and hear something with aplay and /dev/ttyUSB1. On the openmoko/freerunner is a matter of HW switches, on the n900 IIRC is done with pulseaudio. I guess that voice call audio routing is not in oFono plans, if I'm

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-12 Thread Marcel Holtmann
Hi Waldo, The conclusion was that these two test commands should be issued from the AP to ensure that the modem is functioning properly. I am not aware of the conclusion. My understanding is still that the modem firmware is suppose to do its selftests all by itself. It does not.

Re: [PATCH] ifx: adding Infineon modem self test

2010-12-12 Thread Marcel Holtmann
Hi Robertino, static const char *none_prefix[] = { NULL }; static const char *xdrv_prefix[] = { +XDRV:, NULL }; +static const char *empty_prefix[] = { , NULL }; this is essentially to just passing NULL as argument. What are you trying to achieve here? +static const char

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-11 Thread Marcel Holtmann
Hi Remi, Personally I think the every-10sec interval is too short. It's also highly system specific when wakeups start to get too costly, so picking up one value seems difficult. My take here is that a granularity of 1 minute is enough. There are definitely call

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-11 Thread Marcel Holtmann
Hi Waldo, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the

Re: [PATCH] ifx: adding Infineon modem self test

2010-12-10 Thread Marcel Holtmann
Hi Robertino, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the modem

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-10 Thread Marcel Holtmann
Hi Remi, Personally I think the every-10sec interval is too short. It's also highly system specific when wakeups start to get too costly, so picking up one value seems difficult. My take here is that a granularity of 1 minute is enough. There are definitely call fares with

RE: [PATCH 0/3] Attach GPRS on demand

2010-12-09 Thread Marcel Holtmann
Hi Mika, I'm not quite sure what you mean here. There are many different cases, where the network can detach a UE from GPRS service. See possible detach causes in 24.008. Currently, oFono does not recover at all. Trying to figure out when GPRS is again available can get pretty

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-09 Thread Marcel Holtmann
Hi Kai, - lots of modems still handle all audio and PA will know nothing about calls at all with these modems actually Denis raised the same question, but then again this is for a product specific requirement. And for that product we know that PA will do the audio processing.

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-09 Thread Marcel Holtmann
Hi Kai, I share the concern for the IO/CPU cost, but I don't think it matters much in which daemon this is done. Especially if some slack is allowed for the timers (which should be the case), ofonod will be scheduled when the CPU is anyways woken up (e.g. modem/audio interrupts wake up

Re: CAIF Protocol : oFono

2010-12-09 Thread Marcel Holtmann
Hi Sjur, We understand that CAIF is coming as kernel driver in linux 2.6.36. We are trying to write some test application which will make use of CAIF kernel driver to interact with ST-Ericsson Modem. When we connect any modem how OFono recognizes it? Is it based on rule mentioned in

Re: [RESEND PATCH] plugin: Add ste modem initd integration

2010-12-09 Thread Marcel Holtmann
Hi Sjur, This patch introduces auto discovery of ST-Ericsson modems. ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a Modem Init Daemon that is responsible for start/stop/restart flashing etc. This STE plugin monitors the modem state exposed from the Modem Init Damon Dbus API. When

Re: [RESEND PATCHv2 2/2] stemodem: Use RTNL to create network interfaces.

2010-12-09 Thread Marcel Holtmann
Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index bfc0d65..21ca126 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -47,6 +47,7 @@ #include stemodem.h #include caif_socket.h #include if_caif.h +#include

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Marcel Holtmann
Hi Aki, where is this timed running? I prefer the plugin just send a D-Bus message to the timed directly instead of a Get/Changed API kind of thing. AFAIK, timed is in system bus. However, I fail to see how you can make this any simpler. In the end, one of the two entities has to

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Aki, Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters are updated periodically when there is an

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, Updates in Makefile.am - adding of isimodem2.5 Adding of drivers/isimodem2.5/ files to fully listed functionality. Regards, Jessica Nilsson --- Makefile.am| 36 +- drivers/isimodem2.5/call-barring.c | 503 ++

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, This set of patches introduces the isimodem2.5. WG2.5 (isimodem2.5) Supported features list: General: Online / Offline mode (RF on/off) Voice call: MO/MT call Multiparty call (max 7 calls) Transfer call Swap calls Hold calls Hang up all Hang up specific call

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Aki, so Denis and I talked about this a little bit and I am not fine with this at all. Next time, can you invite me to join your little talk? because you are not sitting next to me right now ;) Lets take this one step and please explain to me what your requirements and objectives

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, So please split this into one patch per atom driver. We are starting to look at this split up. Do you have any other suggestions? I really want one patch per atom driver. In addition, I don't a point in a filename. So isimodem25 or isimodem2 or something like that

Re: [PATCH 2/4]simutil: Changes to prepare for isimodem2.5

2010-12-08 Thread Marcel Holtmann
Hi Jessica, updates in src/simutil.h Adding some sim file id and sim dir id mostly related to phonebook usim/sim. please write a proper commit message here. The subject is not acceptable since it misleads what this patch is doing. Also updates in src/... comments are not really useful. We

Re: [PATCH 7/9] gdbus: explicitly compare pointers to NULL

2010-12-08 Thread Marcel Holtmann
Hi Lucas, This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c |

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Andras, Lets take this one step and please explain to me what your requirements and objectives are. I also wanna see a top to bottom from UI down to the modem usage of this API. We need a UI showing total MO and MT call times. They also need to be able to be reset, if the

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Andras, The call counters are shown to the user when he or she opens up an application/applet whatever UI component that is meant for showing this information. do we have a clear use case requirement from an UI point of view on how this is expected to be working.

RE: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Marcel Holtmann
Hi Kai, So I am actually thinking that doing that inside PulseAudio is a lot more efficient solution. The idea is that PA already runs in the user session and has to monitor the uplink/downlink state (and additionally could monitor call states as well if needed). So it knows when a

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Marcel Holtmann
Hi Remi, where is this timed running? I prefer the plugin just send a D-Bus message to the timed directly instead of a Get/Changed API kind of thing. AFAIK, Get/Changed is the simplest functional way to avoid races, where say oFono would receive the time before timed can

Re: [PATCH] Mark ofono/*.h symbolink links as built sources

2010-12-07 Thread Marcel Holtmann
Hi Remi, This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. --- Makefile.am |6 +++--- 1 files changed,

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

2010-12-07 Thread Marcel Holtmann
Hi Tonny, plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@ static void huawei_disconnect(gpointer user_data)

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-05 Thread Marcel Holtmann
Hi Aki, where is this timed running? I prefer the plugin just send a D-Bus message to the timed directly instead of a Get/Changed API kind of thing. AFAIK, timed is in system bus. However, I fail to see how you can make this any simpler. In the end, one of the two entities has to

Re: [RESEND] [PATCH] Mark ofono/*.h symbolink links as built sources

2010-12-03 Thread Marcel Holtmann
Hi Remi, This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. I have run some tests on this and seems fine to

Re: [PATCH] HACKING: Add ofono.conf file copy command required

2010-12-01 Thread Marcel Holtmann
Hi Daniel, + Copy configuration file which specifies the required security policies +# sudo cp ./src/ofono.conf /etc/dbus-1/system.d/ + Considered to add this too? sudo killall -HUP dbus-daemon that is actually a bad idea. I would not recommend it. The dbus-daemon should be

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Marcel Holtmann
Hi Remi, do me a favor and try not to break the threading next time. * At Nokia, we also have some non-standard commands for internal use. * Some operators require some funky AT commands of their own. It might not be possible to open-source them, even if we want to. And these

Re: ConnectionContext creation for LTE PDN Connection.

2010-11-30 Thread Marcel Holtmann
Hi Remi, as I mentioned before, please do NOT break threading. why would bringing an interface up interfere? We are doing this right now. Just the IP assignment is done by ConnMan, but the interface up/down status is controlled by oFono or even BlueZ in case of Bluetooth. Logically

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Marcel Holtmann
Hi Aki, I am getting a bit sick of this secrecy. oFono is for all intense and purposes open source. So if you want a proper discussion here then please list the AT command in question. So this patch seems to be to enable reporting call direction as part of reporting call status using

Re: [PATCH] Mark ofono/*.h symbolink links as built sources

2010-11-29 Thread Marcel Holtmann
Hi Remi, This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. I had this before, but it caused problems with

Re: [PATCH] configure: do not hard-code the C run-time library name

2010-11-29 Thread Marcel Holtmann
Hi Remi, Since oFono does (obviously) not use -nostdlib, this only broke support for alternative C run-times. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) looks good enough to me. Patch has been applied. Regards Marcel

Re: [PATCH 2/3] Use %m instead of strerror() in syslog messages

2010-11-29 Thread Marcel Holtmann
Hi Remi, strerror() is not thread-safe, nor in the glibc implementation, nor in the POSIX specification. In my experience, it will infrequently crash when another thread uses locale data in any way, including string formatting and such... Since the Huawei driver uses thread, we

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-29 Thread Marcel Holtmann
Hi Remi, This becomes a problem if we have more than one application managing voice calls. And I expect that will _be_ the most common case. You have the main call UI, but you also have the Bluetooth headset/carkit, the USB AT commands port, and possibly some third party call

Re: ConnectionContext creation for LTE PDN Connection.

2010-11-29 Thread Marcel Holtmann
Hi Remi, Or should oFono automatically create a Connection Context? Furthermore, should oFono automatically proceed and set Active=true, bind the connection to a network interface and set network interface in state UP, Definitely not. This would interfere with any other existing IP

RE: How to get the OMA DRM right object file coming from WAP Push?

2010-11-25 Thread Marcel Holtmann
Hi Aki, Can the two methods help me to handle files from WAP push? Yes. You need to implement the PushNotificationAgent interface, and register this object with oFono using the RegisterAgent() method. there is actually a test/test-push-notification Python example in the code base that

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-23 Thread Marcel Holtmann
Hi Jaakko, To be honest, the more and more I think about this, the more my conclusion is to not support phonebook export. It is a bad idea. It is highly complex and it is not a feature that will be used anyway. Ok, got it. Do you have any insight if MeeGo still wants this

Re: [RERESEND] [PATCH 2/2] Update the network documentation

2010-11-23 Thread Marcel Holtmann
Hi Remi, doc/network-api.txt |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 083e918..9fb9974 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -125,8 +125,9 @@ Propertiesstring Mode

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-22 Thread Marcel Holtmann
Hi Jaakko, no index number. We will never use them. It is either the full phonebook at once or nothing. The write function has to empty out left over entries. ... Actually I prefer we use proper Dict field names. We never use anything literally from the specifications in this area.

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-21 Thread Marcel Holtmann
Hi Jaako, Is there already a specification/draft of the format of this dict? If not, I would be tempted to use the 27.007 +CPBR/W field names as keys (e.g. index, number, type, text, adnumber, secondtext, sip_uri, etc.) there is not. So you need to propose one here. For simplicity,

<    1   2   3   4   5   6   7   8   9   10   >